From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:46346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grjPQ-0001LK-Go for guix-patches@gnu.org; Thu, 07 Feb 2019 08:08:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grjPP-0003N7-Ox for guix-patches@gnu.org; Thu, 07 Feb 2019 08:08:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37354) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grjPO-0003Md-LG for guix-patches@gnu.org; Thu, 07 Feb 2019 08:08:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1grjPO-0006uA-2r for guix-patches@gnu.org; Thu, 07 Feb 2019 08:08:02 -0500 Subject: [bug#34365] [PATCH] gnu: Add python-daemon. Resent-Message-ID: References: <87va1w6iki.fsf@ponder> <874l9gexmz.fsf@elephly.net> <87sgwz7rkq.fsf@ponder> From: Ricardo Wurmus In-reply-to: <87sgwz7rkq.fsf@ponder> Date: Thu, 07 Feb 2019 14:07:12 +0100 Message-ID: <87va1v4uin.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Vagrant Cascadian Cc: 34365@debbugs.gnu.org Vagrant Cascadian writes: >> Before pushing this I=E2=80=99ll add a final #T to this phase. (In the = past #F >> would indicate failure, but that=E2=80=99s on longer the case. =E2=80= =9Csubstitute*=E2=80=9D >> annoyingly returns an unspecified value.) > > My eyes still have trouble identifying where exactly this would > go... and #T/#F vs. #t/#f has me a bit confused for good measure! Oh sorry. It should go after the (substitute* =E2=80=A6) clause. We somet= imes capitalize variable names and values when referring to them. We would write =E2=80=9C#t=E2=80=9D here. >>> + (license (list license:asl2.0 license:gpl3+)))) >> >> What does this list mean? > > I guess it's best practice in Guix to make a comment when multiple > licenses are listed? Yes. We don=E2=80=99t have a syntactic way to express license algebra, so = we usually add a comment when a list of licenses applies. > Apparently only setup.py is gpl3+, everything else is apache 2.0 > licensed. That was my quick look at the code itself, and basically > confirmed by: > > https://sources.debian.org/src/python-daemon/2.2.3-1/debian/copyright/ Excellent. This can be added as a short comment above the license field. Thanks! -- Ricardo