From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: Package gmsh: best practise with test-suite?
Date: Tue, 12 Feb 2019 08:45:34 +0100
Message-ID: <87va1pjvq9.fsf@elephly.net>
References: <CAJ3okZ2yUNko9h2rb630Hib=NtCWxu+JWRZ0GZA+=LvewhTBRw@mail.gmail.com>
	<875ztqdsjt.fsf@cbaines.net>
	<CAJ3okZ3pFVbYSDiYo+ynZYyXMb8eLWTaT7QzJzsvPSOWQDuUUQ@mail.gmail.com>
	<874l9adqk5.fsf@cbaines.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:41544)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1gtWIP-0000To-FK
	for guix-devel@gnu.org; Tue, 12 Feb 2019 06:32:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1gtWIJ-0007NY-V1
	for guix-devel@gnu.org; Tue, 12 Feb 2019 06:32:11 -0500
Received: from sender-of-o51.zoho.com ([135.84.80.216]:21020)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <rekado@elephly.net>) id 1gtWIE-000751-N3
	for guix-devel@gnu.org; Tue, 12 Feb 2019 06:32:04 -0500
In-reply-to: <874l9adqk5.fsf@cbaines.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: Guix Devel <guix-devel@gnu.org>


Christopher Baines <mail@cbaines.net> writes:

>> If I understand well, the idea should be to turn off the all tests
>> ("#:tests? #f") and to add a final phase calling "ctest" with the
>> correct tests. Does this make sense?
>
> That would work, but in my opinion a neater approach would be to keep
> #:tests? as #t, and replace the 'check phase to call ctest with the
> required arguments. Then #:tests? still works as an argument. Something
> like...
>
> (arguments
>  '(#:phases
>    (modify-phases %standard-phases
>      (replace 'check
>        (lambda* (#:key tests? #:allow-other-keys)
>          (when tests?
>            (invoke "ctest" "--exclude-regex" "..."))
>          #t)))))

You can also set test arguments in an earlier phase as is done in
=E2=80=9Cdune-common=E2=80=9D, for example.

--8<---------------cut here---------------start------------->8---
         (add-after 'unpack 'disable-failing-tests
           (lambda _
             (setenv "ARGS"
                     (string-append "--exclude-regex '("
                                    (string-join
                                     (list
                                      "remoteindicestest"
                                      "remoteindicestest-mpi-2"
                                      "syncertest"
                                      "syncertest-mpi-2"
                                      "variablesizecommunicatortest"
                                      "variablesizecommunicatortest-mpi-2"
                                      "arithmetictestsuitetest"
                                      "assertandreturntest"
                                      "assertandreturntest_ndebug"
                                      "concept"
                                      "debugaligntest"
                                      "mpicollectivecommunication"
                                      "mpicollectivecommunication-mpi-2"
                                      "mpiguardtest"
                                      "mpiguardtest-mpi-2"
                                      "mpihelpertest"
                                      "mpihelpertest-mpi-2"
                                      "mpihelpertest2"
                                      "mpihelpertest2-mpi-2")
                                     "|")
                                    ")'"))
             #t))
--8<---------------cut here---------------end--------------->8---

--=20
Ricardo