From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtpwk-0005Jo-3f for guix-patches@gnu.org; Wed, 13 Feb 2019 03:31:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtpnv-0006S8-SX for guix-patches@gnu.org; Wed, 13 Feb 2019 03:22:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46471) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtpnu-0006RK-Is for guix-patches@gnu.org; Wed, 13 Feb 2019 03:22:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gtpnu-0004Vb-AU for guix-patches@gnu.org; Wed, 13 Feb 2019 03:22:02 -0500 Subject: bug#34240: [PATCH 4/5] gnu: Add system-config-printer. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <87a7jjr8y3.fsf@cbaines.net> <20190129114242.32481-1-mail@cbaines.net> <20190129114242.32481-4-mail@cbaines.net> <87bm3zpfwp.fsf@elephly.net> From: Christopher Baines In-reply-to: <87bm3zpfwp.fsf@elephly.net> Date: Wed, 13 Feb 2019 08:21:04 +0000 Message-ID: <87va1ot7yn.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 34240-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ricardo Wurmus writes: > Christopher Baines writes: > >> * gnu/packages/gnome.scm (system-config-printer): New variable. > [=E2=80=A6] >> + (arguments >> + `(#:imported-modules ((guix build python-build-system) >> + ,@%glib-or-gtk-build-system-modules) >> + #:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'patch-Makefile.am >> + (lambda _ >> + ;; The Makefile generates some scripts, so set a valid she= bang >> + (substitute* "Makefile.am" >> + (("/bin/bash") (which "bash"))) >> + #t)) > [=E2=80=A6] >> + (add-before 'configure 'bootstrap >> + (lambda _ >> + ;; Run ./bootstrap as otherwise the build fails with >> + ;; automake-1.15: command not found >> + (invoke "./bootstrap") >> + #t)) > > The build system already provides a =E2=80=9Cbootstrap=E2=80=9D phase, so= maybe it would > be better to delete =E2=80=9Cconfigure=E2=80=9D in =E2=80=9Cpatch-Makefil= e.am=E2=80=9D to activate the > bootstrap phase. > > Otherwise looks good to me. Thanks! Great, I've made that change to the system-config-printer phases and pushed these patches now. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlxj03BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XckkQ/7BGn0jXNxLFVApCESoN0L407O+ddQZ3stFyGioqHIvA3YpCRIMv1NmbhK vUiGl/QyUHNSsxrpmRb9KVNE1k4dsVBMl7HEtGGGUFXFCHh2vaRaytLC4ZzmT+N/ NCaXxN2h0HfkFyWcMDfoVShuwx3xmrQVa1fbCNq6CaayaSHNi8IPln1fYpw9NQ2N CxGXYL1d/4WX2ZxWGQ8nIVHs+s7tU39EQX1wgo4jNlTPdQalF9d4HROfWgGlNbtM W11dcF040bgFsy0ERY+htuWLXBAlCiNcCxe5edFZzqhYXkf85E1TqSTPyCljjiQ/ vM+McKtEsmJt272d0BZIrI1W7mGC+2jxjXbIolnygOB3QSPjgyK+aCvW7F2xh4F2 NqXFLG950Gm9nBYKqD0z6FT8/jVNoEaxAh4YlFrQCnvoDNNYddeWOsisRqsQ3qEH nSsYoUwoOmwS4Q/mau6+XTWVBlWlojfwbbqcaBvQ8FNtq90fkZpnorF6wI5zHFZt UdctvbrtG9c2pfS6oKUmTVd/ZDOZ/yKx7sB46fFoRDmwTb2DqIJS4icfLo32SP2r x45pVW1RqWiFOK76mm9t1LpfuRgLu9vJrSkuF/yBjkab181sdGKhmS02vD88FlUZ ATwHI7JSQoMz04RVLDJPcTv7Ii8zQOA2W2vy5xaVQZ9JgvSmXOc= =GbE6 -----END PGP SIGNATURE----- --=-=-=--