bug#34799: font breakage, square boxes, font-terminus

[Tobias Geerinckx-Rice <somebody@not-sent-or-endorsed-by.tobias.gr>]

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

Bradley,

Bradley Haggerty wrote:
> This issue may be a lot simpler than it initially seemed. I've 
> had success
> upgrading all those packages except for font-terminus. I also 
> realized that
> the broken font in all places I can think of was the same. It 
> was Terminus.
> So, this bug is likely specific to font-terminus and for now I 
> will just
> hold it back in my upgrades.

I updated font-terminus from 4.40 to 4.47 in commit 73c5c482.  I 
wonder if your problem could be caused by this intermediate 
upstream change[0]:

  Version 4.46:
    The X11 8-bit code pages are not installed by default.

Indeed, I'd noticed that some half of the 4.40 files were 
‘missing’ from 4.47, but my fonts continued to work just fine and 
we don't (usually…) diverge from upstream without good reason.

This is probably a good reason :-)  Does the attached patch fix 
your problem?

Kind regards,

T G-R

[0]: http://terminus-font.sourceforge.net


[-- Attachment #2: 0001-XXX-gnu-font-terminus-Install-X11-8-bit-code-pages.patch --]
[-- Type: text/x-patch, Size: 1678 bytes --]

From 0d9b645937abfdddaf3d8088f81c58220c8d0026 Mon Sep 17 00:00:00 2001
From: Tobias Geerinckx-Rice <me@tobias.gr>
Date: Sun, 10 Mar 2019 12:12:08 +0100
Subject: [PATCH] XXX gnu: font-terminus: Install X11 8-bit code pages.

* gnu/packages/fonts.scm (font-terminus)[arguments]: Add a new phase
to build & install 8-bit fonts that were installed by default pre-4.46.
---
 gnu/packages/fonts.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 296e46ec6f..0d327a51b7 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -360,7 +360,16 @@ Biolinum is available in both Regular and Bold weights.")
        ("pkg-config" ,pkg-config)
        ("python" ,python)))
     (arguments
-     `(#:tests? #f))                    ; no test target in tarball
+     `(#:tests? #f                      ; no test target in tarball
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'install-more-bits
+           ;; X11 8-bit code pages are not installed by default (they were
+           ;; until version 4.46).  Install them manually.
+           ;; XXX This builds at least as many fonts as the ‘build’ phase
+           ;;     does.  Split up into build- and install- when merging?
+           (lambda* (#:key make-flags outputs #:allow-other-keys)
+             (apply invoke "make" "install-pcf-8bit" make-flags))))))
     (home-page "http://terminus-font.sourceforge.net/")
     (synopsis "Simple bitmap programming font")
     (description "Terminus Font is a clean, fixed-width bitmap font, designed
-- 
2.20.1