From: Ricardo Wurmus <rekado@elephly.net>
To: Mark H Weaver <mhw@netris.org>
Cc: 35530@debbugs.gnu.org
Subject: bug#35530: NSS-3.43 fails its test suite on armhf-linux
Date: Sat, 04 May 2019 18:45:49 +0200 [thread overview]
Message-ID: <87v9yqf9s2.fsf@elephly.net> (raw)
In-Reply-To: <878svowm4h.fsf@elephly.net>
Ricardo Wurmus <rekado@elephly.net> writes:
> Mark H Weaver <mhw@netris.org> writes:
>
>> NSS-3.43 fails its test suite on armhf-linux:
>>
>> https://hydra.gnu.org/build/3484222
>
> I can reproduce this. Looks like all problems are with the tests in
> ssl_drop_unittest.cc:
>
> ssl_drop_unittest.cc:182: Failure
> ssl_drop_unittest.cc:71: Failure
> ssl_drop_unittest.cc:182: Failure
> ssl_drop_unittest.cc:71: Failure
> ssl_drop_unittest.cc:422: Failure
> ssl_drop_unittest.cc:451: Failure
> ssl_drop_unittest.cc:380: Failure
> ssl_drop_unittest.cc:474: Failure
> ssl_drop_unittest.cc:474: Failure
> ssl_drop_unittest.cc:71: Failure
> ssl_drop_unittest.cc:71: Failure
> ssl_drop_unittest.cc:71: Failure
> ssl_drop_unittest.cc:95: Failure
>
> It’s a bit difficult to find actual test failures in the logs because it
> mentions “error” and “failed” and the like a lot. This is a test that
> counts ACKs after dropping parts of the messages / datagrams /
> handshake. The failing tests seem to consistently come up short on ACKs
> – they are not always zero but usually much lower than they are expected
> to be.
Just disabling the ssl_drop_unittest.cc was not sufficient. It was only
when I forced the build to take place on one of the Overdrive machines
that the build succeeded.
I only built it with the ssl_drop_unittest.cc disabled:
--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm
index 480f64a046..57d83313eb 100644
--- a/gnu/packages/nss.scm
+++ b/gnu/packages/nss.scm
@@ -116,6 +116,12 @@ in the Mozilla clients.")
`((setenv "USE_64" "1")))
(_
'()))
+ ;; XXX Disable broken tests on armhf
+ ,@(match (%current-system)
+ ("armhf-linux"
+ '((substitute* "nss/gtests/ssl_gtest/ssl_gtest.gyp"
+ (("'ssl_drop_unittest.cc',") ""))))
+ (_ '()))
#t))
(replace 'check
(lambda _
--8<---------------cut here---------------end--------------->8---
It’s possible that this is not actually necessary.
--
Ricardo
prev parent reply other threads:[~2019-05-04 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 22:41 bug#35530: NSS-3.43 fails its test suite on armhf-linux Mark H Weaver
2019-05-02 22:02 ` Ricardo Wurmus
2019-05-04 16:45 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9yqf9s2.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=35530@debbugs.gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.