* [bug#35970] [PATCH] gnu: Add qview.
@ 2019-05-28 22:51 Nicolas Goaziou
2019-06-01 13:06 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2019-05-28 22:51 UTC (permalink / raw)
To: 35970
* gnu/packages/image-viewers.scm (qview): New variable.
---
gnu/packages/image-viewers.scm | 48 ++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 82b44a4900..8dee417cdb 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -9,6 +9,7 @@
;;; Copyright © 2017 nee <nee-git@hidamari.blue>
;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me@tobias.gr>
;;; Copyright © 2018, 2019 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2019 Nicolas Goaziou <mail@nicolasgoaziou.fr>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -429,3 +430,50 @@ imaging. It supports several HDR and LDR image formats, and it can:
a comic and manga reader. It supports a variety of container formats
including CBZ, CB7, CBT, LHA.")
(license license:gpl2+)))
+
+(define-public qview
+ (package
+ (name "qview")
+ (version "2.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jurplel/qView.git")
+ (commit version)))
+ (sha256
+ (base32
+ "1s29hz44rb5dwzq8d4i4bfg77dr0v3ywpvidpa6xzg7hnnv3mhi5"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (replace 'configure
+ (lambda _
+ (invoke "qmake")))
+ ;; Installation process hard-codes "/usr/bin", possibly
+ ;; prefixed.
+ (add-after 'configure 'fix-install-directory
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (substitute* "Makefile"
+ (("\\$\\(INSTALL_ROOT\\)/usr") out))
+ #t)))
+ ;; Don't phone home or show "Checking for updates..." in the
+ ;; About menu.
+ (add-before 'build 'disable-auto-update
+ (lambda _
+ (substitute* "src/qvaboutdialog.cpp"
+ (("ui->updateLabel->setText\\(updateText\\);") "")
+ (("requestUpdates\\(\\);") ""))
+ #t)))))
+ (inputs
+ `(("qtbase" ,qtbase)
+ ("qtsvg" ,qtsvg)
+ ("qtimageformats" ,qtimageformats)))
+ (home-page "https://interversehq.com/qview/")
+ (synopsis "Practical and minimal image viewer")
+ (description "qView is a Qt image viewer designed with visually
+minimalism and usability in mind. Its features include animated GIF
+controls, file history, rotation/mirroring, and multithreaded
+preloading.")
+ (license license:gpl3+)))
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#35970] [PATCH] gnu: Add qview.
2019-05-28 22:51 [bug#35970] [PATCH] gnu: Add qview Nicolas Goaziou
@ 2019-06-01 13:06 ` Ludovic Courtès
2019-06-01 20:52 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2019-06-01 13:06 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 35970
Salut,
Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:
> * gnu/packages/image-viewers.scm (qview): New variable.
[...]
> + (synopsis "Practical and minimal image viewer")
^~~~~~~~~
Did you mean “convenient”? :-)
(It surely is practical too, but the same could be said of all the image
viewers we have.)
Otherwise LGTM!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#35970] [PATCH] gnu: Add qview.
2019-06-01 13:06 ` Ludovic Courtès
@ 2019-06-01 20:52 ` Nicolas Goaziou
2019-06-01 21:53 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2019-06-01 20:52 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 35970
Hello,
Thank you for the review.
Ludovic Courtès <ludo@gnu.org> writes:
> Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:
>
>> * gnu/packages/image-viewers.scm (qview): New variable.
>
> [...]
>
>> + (synopsis "Practical and minimal image viewer")
> ^~~~~~~~~
>
> Did you mean “convenient”? :-)
> (It surely is practical too, but the same could be said of all the image
> viewers we have.)
OK. Bikeshedding time :)
I used the words from the developers themselves
<https://github.com/jurplel/qView>, so I didn't mean anything in
particular.
However, AFAIU, there is a difference between practical and convenient:
the latter suggests some ease of use that the former doesn't. For
example, the `find' utility is practical, but not what I would call
convenient.
Now, I don't have a strong opinion about it. I just wanted to be
faithful to the developers' words.
Bikeshedding time's over.
So, "Practical" or "convenient", or something different, like:
"Fully-featured yet unobtrusive image viewer"
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#35970] [PATCH] gnu: Add qview.
2019-06-01 20:52 ` Nicolas Goaziou
@ 2019-06-01 21:53 ` Ludovic Courtès
2019-06-05 21:45 ` bug#35970: " Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2019-06-01 21:53 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 35970
Hi!
Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:
> However, AFAIU, there is a difference between practical and convenient:
> the latter suggests some ease of use that the former doesn't. For
> example, the `find' utility is practical, but not what I would call
> convenient.
Yes, that’s what I meant.
I commented because I was quite sure “convenient” was meant and because
“practical” is a false friend in French, but it’s no big deal.
So please push with your preferred wording! :-)
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#35970: [PATCH] gnu: Add qview.
2019-06-01 21:53 ` Ludovic Courtès
@ 2019-06-05 21:45 ` Nicolas Goaziou
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2019-06-05 21:45 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 35970-done
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> I commented because I was quite sure “convenient” was meant and because
> “practical” is a false friend in French, but it’s no big deal.
>
> So please push with your preferred wording! :-)
Fair enough. I used "convenient" and pushed the commit.
Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-05 21:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-28 22:51 [bug#35970] [PATCH] gnu: Add qview Nicolas Goaziou
2019-06-01 13:06 ` Ludovic Courtès
2019-06-01 20:52 ` Nicolas Goaziou
2019-06-01 21:53 ` Ludovic Courtès
2019-06-05 21:45 ` bug#35970: " Nicolas Goaziou
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.