From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:42917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hYXmh-0004M9-7p
	for guix-patches@gnu.org; Wed, 05 Jun 2019 11:25:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hYXmg-0004K1-B4
	for guix-patches@gnu.org; Wed, 05 Jun 2019 11:25:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:34375)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hYXmg-0004JP-1D
	for guix-patches@gnu.org; Wed, 05 Jun 2019 11:25:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hYXmf-0003iZ-Sc
	for guix-patches@gnu.org; Wed, 05 Jun 2019 11:25:01 -0400
Subject: [bug#36071] [PATCH] gnu: Add leela-zero.
Resent-Message-ID: <handler.36071.B36071.155974830014281@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190603130611.32142-1-glv@posteo.net>
Date: Wed, 05 Jun 2019 17:24:48 +0200
In-Reply-To: <20190603130611.32142-1-glv@posteo.net> (Guillaume LE VAILLANT's
	message of "Mon, 3 Jun 2019 15:06:11 +0200")
Message-ID: <87v9xkyrzz.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Guillaume LE VAILLANT <glv@posteo.net>
Cc: 36071@debbugs.gnu.org

Hi,

Guillaume LE VAILLANT <glv@posteo.net> skribis:

> * gnu/packages/games.scm (leela-zero): New variable.
> * gnu/packages/patches/leela-zero-gtest.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

[...]

> +                 (replace 'check
> +                   (lambda _
> +                     (zero? (system* "./tests")))))))

Please use =E2=80=98invoke=E2=80=99 instead of (zero? (system* =E2=80=A6)).

> +    "Leela-zero is a Go engine with no human-provided knowledge, modeled
> +after the AlphaGo Zero paper.  The current best network weights file for
> +the engine can be downloaded from https://zero.sjeng.org/best-network.")
                                     ^~~~
Please use @url for URLs.

Does the game run at all if we don=E2=80=99t download additional network we=
ight
data?

There=E2=80=99s a debate as to whether trained neural network parameters ca=
n be
considered =E2=80=9Csource=E2=80=9D: <https://lwn.net/Articles/760142/>.

Thanks,
Ludo=E2=80=99.