From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:58372)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hYq5v-0006IQ-9O
	for guix-patches@gnu.org; Thu, 06 Jun 2019 06:58:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hYq5s-0005dp-0B
	for guix-patches@gnu.org; Thu, 06 Jun 2019 06:58:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:35528)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hYq5p-0005Qa-Nk
	for guix-patches@gnu.org; Thu, 06 Jun 2019 06:58:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hYq5p-0002wF-LM
	for guix-patches@gnu.org; Thu, 06 Jun 2019 06:58:01 -0400
Subject: [bug#36086] [PATCH] services: Add auditd.
Resent-Message-ID: <handler.36086.B36086.155981867311279@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190604073406.9297-1-dannym@scratchpost.org>
Date: Thu, 06 Jun 2019 12:57:25 +0200
In-Reply-To: <20190604073406.9297-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Tue, 4 Jun 2019 09:34:06 +0200")
Message-ID: <87v9xjm162.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 36086@debbugs.gnu.org

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/services/auditd.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi (Miscellaneous Services): Document it.

[...]

> +The @code{(gnu services auditd)} module provides the following service.
> +
> +@defvr {Scheme Variable} auditd-service-type
> +
> +This is the type of the service that runs
> +@url{https://people.redhat.com/sgrubb/audit/,auditd},
> +a daemon that track security-relevant information on your system.
                     ^^
=E2=80=9Ctracks=E2=80=9D

Could you add a few words, like whether/how it logs events, what kind of
events it tracks, etc.?

> +; /etc/audit/audit.rules
> +
> +(define-configuration auditd-configuration
> +  (audit
> +   (package audit)
> +   "Audit package."))

I suppose this record could eventually be extended, right?

> +(define auditd-service-type
> +  (service-type (name 'auditd)
> +                (extensions
> +                 (list
> +                  (service-extension shepherd-root-service-type
> +                                     auditd-shepherd-service)))
> +                (default-value (auditd-configuration))))

Please add a =E2=80=98description=E2=80=99.

Otherwise LGTM, thanks!

Ludo=E2=80=99.