From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39360) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiPCF-0001zR-HC for guix-patches@gnu.org; Tue, 02 Jul 2019 16:16:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiPC9-0006qb-OG for guix-patches@gnu.org; Tue, 02 Jul 2019 16:16:09 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39195) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiPC6-0006nR-KZ for guix-patches@gnu.org; Tue, 02 Jul 2019 16:16:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hiPC6-0007jQ-F1 for guix-patches@gnu.org; Tue, 02 Jul 2019 16:16:02 -0400 Subject: [bug#35790] [PATCH] scripts: lint: Handle warnings with a record type. Resent-Message-ID: References: <20190518093206.22069-1-mail@cbaines.net> <878suz27ke.fsf@gnu.org> <87ef4dxgvl.fsf@cbaines.net> <87pnnpj15u.fsf@gnu.org> <87h88pu1cc.fsf@cbaines.net> <875zp0lbmx.fsf@gnu.org> <875zovmqey.fsf@cbaines.net> <87pnn3cr7f.fsf@gnu.org> <87y31kli4q.fsf@cbaines.net> <87a7dyoryh.fsf@gnu.org> From: Christopher Baines In-reply-to: <87a7dyoryh.fsf@gnu.org> Date: Tue, 02 Jul 2019 21:15:16 +0100 Message-ID: <87v9wkkxbf.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35790@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > Christopher Baines skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Hi Chris, >>> >>> Christopher Baines skribis: >>> >>>> Thanks, so if I set the bindtextdomain, things do indeed work >>>> better. So, regarding these two patches, I've got the following things >>>> on my mind... >>>> >>>> - As they change so many things, I'm not sure what to add for the GNU >>>> changelog at the end of the commit message? >>> >>> I think you should try to write the commit log the usual way, by >>> listing every changed entity. It=E2=80=99s a bit tedious, but it=E2=80= =99s also a good >>> way to review everything (and Magit makes it relatively easy.) >> >> Ok, I've now made an initial attempt at this, and sent some updated >> patches. > > Perfect, thanks for taking the time to do it. Great :) > Time to push! :-) Well... I'm happy to push these patches to master, but I've got some more related changes in mind. It might be good to merge these all together, to avoid churning up the codebase more than necessary. I've sent another couple of patches, the first to move most of the functionality from (guix scripts lint) to a new (guix lint) module. The second patch then splits the checkers in to two groups, based on whether they attempt to access the network. This is still moving towards being able to easily lint all the packages and store this information in the Guix Data Serivce. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl0bu1RfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeqyRAAk/eqbAMa9gZviwrL7niIvHV8BrTSIIMNr0z0fPZTFXPHCso45DTZ5GPx FJ3uGS1l73QmYT76LbKszCE5q1BRLuUeQKVIK4wAUQuykq5pEP38OHMwFC4YDrcB 36J+kkD0UoPLq67QyK99QYj+WJxDZv0AV5UueIOFQGylMbpM+2uaK6lNcxeTA7Pu cS0ql6l5k9/QQokfkqIGFK//OA4oZvZhjTwFfa6CNixvFjYLK2R7Ey1DvOCY00Rm fp9M87MrNv1l9AV9++9A2cGMKrrczUqku98N/MOwtI+LtRUuAdLjwDfZvz9WaKp2 FW9lFAewoM80M7HVgFs/YYoJS28kSOFHyzfK4B+PyPEHznlwwN6usN6vqWYo9yLj 516Fqnh9u+91Irq3DjANKYAfS2lJ92sI3/Heix9BsLbQBWuzZbqrIGl7/bLcckdJ Yh+3+fkJlja2aQUA2SohHHsZq4vtGIwKlVL2kcYOSWUecTNCFtl4AzPXZpvEFBh1 HziabV/nfkIblbuIhifHJh983XhVf7Jor5KzP8rc4/x7qtbmVXq2BmUx6SAPJa+G H9A9b63PVfU8vP5wC717xaMaAy4hz9IvwA4H/01rMNl8LZWg9hEUO7zbbxVl6Pf1 SemtwEkOysgQKnJ6z11+rGG4YkA6OzIGiFeu8PLI3mOOz5lu8t4= =n67x -----END PGP SIGNATURE----- --=-=-=--