From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:47813) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmj5T-0004qV-AJ for guix-patches@gnu.org; Sun, 14 Jul 2019 14:19:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmj5S-0004x6-7c for guix-patches@gnu.org; Sun, 14 Jul 2019 14:19:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37100) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmj5S-0004x0-2x for guix-patches@gnu.org; Sun, 14 Jul 2019 14:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmj5R-00010h-Oy for guix-patches@gnu.org; Sun, 14 Jul 2019 14:19:01 -0400 Subject: [bug#35790] [PATCH 2/2] lint: Separate checkers by dependence on the internet. Resent-Message-ID: References: <87a7dyoryh.fsf@gnu.org> <20190702192542.16179-1-mail@cbaines.net> <20190702192542.16179-2-mail@cbaines.net> <87lfx3gvxf.fsf@gnu.org> From: Christopher Baines In-reply-to: <87lfx3gvxf.fsf@gnu.org> Date: Sun, 14 Jul 2019 19:17:55 +0100 Message-ID: <87v9w4h44s.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35790@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > Christopher Baines skribis: > >> I think there are a couple of potential uses for this. It's somewhat a >> separation in to what checkers are just checking the contents of the >> repository (line length for example), and other checkers which are bring= ing in >> external information which could change. >> >> I'm thinking particularly, about treating network dependant checkers >> differently when automatically running them, but this commit also adds a >> --no-network flag to guix lint, which selects the checkers that don't ac= cess >> the network, which could be useful if no network access is available. >> >> * guix/lint.scm (%checkers): Rename to %all-checkers. >> (%local-checkers, %network-dependant-checkers): New variables. >> * guix/scripts/lint.scm (run-checkers): Make the checkers argument manda= tory. >> (list-checkers-and-exit): Handle the checkers as an argument. >> (%options): Adjust for changes to %checkers, add a --no-network option, = and >> change how the --list-checkers option is handled. >> (guix-lint): Adjust indentation, and update how the checkers are handled. > > Nice. > >> +(define %network-dependant-checkers > ^ > Shouldn=E2=80=99t it be =E2=80=9Cdependent=E2=80=9D with an =E2=80=98e=E2= =80=99? I'm definitely not an authority on spelling, but yeah, it seems like dependent is preferred as the adjective, especially in American English. > Otherwise LGTM, thanks! Great :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl0rcdNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfvJhAAucGfOBkdvlC8Zrxbhpv+7L2dIowpxNGCdnCVLSGfwFzFQKM7yKsK1MLj LcGPONjYjdk80Cii2+iEwG2gdNemG/e8821FQNlKglWaduvPIAww/q+z9ulWe9ia FGLRVHVOmXgIcxcFohjq9wwL5LKu44VQrl+HHU6BvY8Uo7h7pDHRaPKaqTBWhhf9 S8khh1Yq7wO09O07F0lzRudjUHUlIqAJjAdSLpgGGGhM3vt8xH9yHE+bqywOf+4C rc9qYyh4BkMSvHpJiS6OtmgmgkY6c2M5TR7JlFcPOlXutEtC3h9ycOVnQsQ2SO6f DDVyZNtLPFVY8Ellx3w+cptOf/jjnGqEBD0EZ/MkpfnIBQZ5FIBq7m0If48gAJbC xltZgxgripyovUeQQ3C3TEVxZQhSzxw/ZRBvVQx2ysDNntfRURKsiORV3js+Utc9 4HRYr+d8OliOp3KvxmCRO4FiLgTve8TsRVGoK7VAzAfnVxyngR8yrGeAjAHLoE3a HBDVW68Zgffwn4aVeItagJw4+L5cJ9ytTzJCC+HlRnfzYib3p4yBsO+amAqNjz8w d0KzeAQg1qS/F+XAK/xgJLrS7uW1V3a1KOPgY45imgT1xA1QxpycTIT/qMZzphhi hRPe5jG/n5vyrP/D582lbLYAPcqTIhyEhLLZnBwmSnFaJyYGWNg= =sKPD -----END PGP SIGNATURE----- --=-=-=--