From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:40522) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3JV5-00067W-IX for guix-patches@gnu.org; Thu, 29 Aug 2019 08:26:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i3JV4-0008CB-8l for guix-patches@gnu.org; Thu, 29 Aug 2019 08:26:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42897) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i3JV4-0008C4-5J for guix-patches@gnu.org; Thu, 29 Aug 2019 08:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i3JV4-0004Cx-0Q for guix-patches@gnu.org; Thu, 29 Aug 2019 08:26:02 -0400 Subject: [bug#37121] [PATCH 32/40] gnu: libxklavier: Update to 5.4. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20190820215043.32077-1-guix@lprndn.info> <20190820215043.32077-32-guix@lprndn.info> <87v9uhgsty.fsf@gnu.org> <87blw91140.fsf@lprndn.info> Date: Thu, 29 Aug 2019 14:24:57 +0200 In-Reply-To: <87blw91140.fsf@lprndn.info> (L. p. R. n. d. n.'s message of "Wed, 28 Aug 2019 22:33:35 +0200") Message-ID: <87v9ugi2g6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: L p R n d n Cc: 37121@debbugs.gnu.org L p R n d n skribis: > Ludovic Court=C3=A8s writes: > >> Hello, >> >> L p R n d n skribis: >> >>> * gnu/packages/gnome.scm (libxklavier): Update to 5.4. >>> [source] Switch to git source. >>> [arguments] Add no-configure phase. Disable xmodmap in #:configure-flag= s. >>> [inputs] Add which, intltool, gtk-doc, which, automake, autoconf and li= btool. >> >> [...] >> >>> - (version "5.3") >>> + (version "5.4") >>> (source (origin >>> - (method url-fetch) >>> - (uri (string-append "mirror://gnome/sources/" name "/" >>> - version "/" name "-" version ".tar.x= z")) >>> + (method git-fetch) >>> + (uri >>> + (git-reference >>> + (url (string-append "https://anongit.freedesktop.org/g= it/" name)) >>> + (commit "396955bd2ba2db34a42b3807b03155fcc11dfe50"))) >>> (sha256 >>> (base32 >>> - "016lpdv35z0qsw1cprdc2k5qzkdi5waj6qmr0a2q6ljn9g2kpv7b"= )))) >>> + "1w1x5mrgly2ldiw3q2r6y620zgd89gk7n90ja46775lhaswxzv7a"= )) >>> + (file-name (git-file-name name version)))) >> >> How does this commit relate to version 5.4? >> says that >> release tarballs are available on the GNOME web site, and there=E2=80=99= s no 5.4 >> there. > > That's true, it's only available through git. The commit seems to be > 6 years old and after some invastigation, 5.4 appears to be used > by other distributions (at least Nixos, Arch and Debian) for several > years. I don't know what are upstream's plans nor why it's not available > on GNOME's website though. OK. I see there=E2=80=99s a =E2=80=98libxklavier-5.4=E2=80=99 tag in the G= it repo above. Could you explicitly use this tag in the source rather than a commit ID, for clarity? Like so: (git-reference (url =E2=80=A6) (commit (string-append "libxklavier-" version))) >> Was this change necessary for the Xfce upgrade? > > Yeah, I'm not really confortable with this either but xfce4-xkb-plugin > explicitely ask for at least libxklavier 5.4. On the other hand > xfce4-xbd-plugin is not part of xfce's core so that update is arguable. OK. Then we=E2=80=99ll make sure to apply the libxklavier upgrade before t= he Xfce upgrade. Thanks! Ludo=E2=80=99.