From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: Help needed packaging rust-cbindgen, a dependency of IceCat 68 Date: Tue, 22 Oct 2019 15:56:42 -0400 Message-ID: <87v9sgzh7u.fsf@netris.org> References: <874l012t91.fsf@netris.org> <20191022185416.GA20347@E5400> <87zhhszhuv.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:40670) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iN0Hu-00067J-GF for guix-devel@gnu.org; Tue, 22 Oct 2019 15:57:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iN0Hq-00019b-JN for guix-devel@gnu.org; Tue, 22 Oct 2019 15:57:48 -0400 Received: from world.peace.net ([64.112.178.59]:51984) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iN0Ho-00017h-Th for guix-devel@gnu.org; Tue, 22 Oct 2019 15:57:46 -0400 In-Reply-To: <87zhhszhuv.fsf@netris.org> (Mark H. Weaver's message of "Tue, 22 Oct 2019 15:42:53 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel@gnu.org Hi Efraim, Mark H Weaver writes: > Efraim Flashner writes: >> Here's what I have for rust-cbindgen based more-or-less on my >> re-imagining of the cargo-build-system and the rust inputs. > > Thank you very much for this! Notably, I see that every package in your > source has a proper 'license' field, and that there are *far* fewer > dependencies here than 'guix import crate -r cbindgen' pulled in. > > What's the feasibility of turning this file into a set of commits that > could be applied to 'master' in the next day or two? If that could be > done, it would be tremendously helpful. I think it's okay if these > "re-imagined" Rust packages are all 'hidden' for now and put in a > separate module, to avoid breaking anything else or interfering with the > packages in crates.io. > > Would you like to do it? I looked again, and I see that you _already_ marked all of the packages 'hidden' except for 'rust-cbindgen' itself. Perfect! Somehow I managed to miss that on my first perusal of the code. The only additional suggestion I'd make is to change 'define-public' to 'define' for all of these packages except for 'rust-cbindgen', to avoid possible conflicts in modules that import both 'cbindgen.scm' and 'crates-io.scm'. How about simply putting this file in (gnu packages rust-cbindgen) for now, with the file header comment changed to match other files in Guix, and with the trailing 'rust-cbindgen' at the bottom removed. Would you like to do this? If not, I could do it. Thanks again! This is a great help and an enormous relief to me. Mark