From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:42764) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1io3HM-0003Tw-Nm for guix-patches@gnu.org; Sun, 05 Jan 2020 05:37:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1io3HK-0008DQ-Et for guix-patches@gnu.org; Sun, 05 Jan 2020 05:37:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37715) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1io3HJ-00086T-VN for guix-patches@gnu.org; Sun, 05 Jan 2020 05:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1io3HJ-000744-Qn for guix-patches@gnu.org; Sun, 05 Jan 2020 05:37:01 -0500 Subject: [bug#38941] [PATCH 0/5] Support fluidsynth and opus in sdl(2)-mixer, and other tweaks Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:42515) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1io3H1-0003SS-AW for guix-patches@gnu.org; Sun, 05 Jan 2020 05:36:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1io3Gz-0005BG-6Z for guix-patches@gnu.org; Sun, 05 Jan 2020 05:36:43 -0500 Received: from araneo.si ([90.157.193.204]:40560) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1io3Gx-0004dl-IN for guix-patches@gnu.org; Sun, 05 Jan 2020 05:36:41 -0500 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 741ce65b for ; Sun, 5 Jan 2020 10:36:35 +0000 (UTC) Received: by araneo.si (OpenSMTPD) with ESMTPSA id f2f21c56 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sun, 5 Jan 2020 10:36:35 +0000 (UTC) From: Timotej Lazar Date: Sun, 05 Jan 2020 11:36:34 +0100 Message-ID: <87v9pqdwb1.fsf@araneo.si> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 38941@debbugs.gnu.org Hi, these patches improve sdl- and sdl2-mixer: fix dependencies and configure flags that changed between the two versions, and enable support for fluidsynth and opus libraries. I tested several dependent packages, and everything seems to work OK. The MIDI backends need additional runtime configuration. Fluidsynth requires a soundfont to be installed and specified when running a program that uses sdl-mixer, e.g.: SDL_SOUNDFONTS=3D/gnu/store/=E2=80=A6-fluid-3-2.1/share/soundfonts/Flui= dR3Mono_GM.sf3 If this is not set, the bundled timidity backend is used, which can use the freepats samples. Configuration must be specified since only files under /etc are checked by default, e.g.: TIMIDITY_CFG=3D/gnu/store/=E2=80=A6-freepats-20060219/share/freepats/fr= eepats.cfg I=E2=80=99m not sure if and how default values for these vars can be specif= ied for all programs using sdl-mixer, and I would prefer to leave the choice of backend to the user anyway. However, we should probably document them somewhere. Would a comment be enough? Dependent packages can then wrap binaries to set required paths if needed. Alternatively we can add freepats and/or fluid as inputs to sdl(2)-mixer and patch the source to look for them in the store. Thanks! Timotej Timotej Lazar (5): gnu: sdl-mixer: Use correct inputs for MOD file support. gnu: sdl-mixer: Remove unused configure flag. gnu: sdl2-mixer: Fix configure flags. gnu: sdl-mixer: Enable fluidsynth MIDI backend. gnu: sdl2-mixer: Enable opus support. gnu/packages/sdl.scm | 49 +++++++++++++++++++++++++++++--------------- 1 file changed, 33 insertions(+), 16 deletions(-) --=20 2.24.1