From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: branch master updated (0aa0e1f -> 9b7f9e6) Date: Mon, 24 Feb 2020 21:34:40 +0100 Message-ID: <87v9nvg1wf.fsf@gnu.org> References: <20200224101817.20439.52918@vcs0.savannah.gnu.org> <87blpom285.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:46558) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6KRC-0005pL-4D for guix-devel@gnu.org; Mon, 24 Feb 2020 15:34:47 -0500 In-Reply-To: (zimoun's message of "Mon, 24 Feb 2020 17:36:15 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: zimoun Cc: Guix Devel Hi, zimoun skribis: > On Mon, 24 Feb 2020 at 16:33, Ludovic Court=C3=A8s wrote: > >> guix-commits@gnu.org skribis: >> >> > new d7545a6 ui: Only display link in capable terminals. >> > new 672d3d4 ui: Don't disable colors when INSIDE_EMACS is set. >> >> Forgive me if I missed the discussion, but I thought we had reached >> rough consensus in favor of the status quo. What happened? > > I do not know if we had reached a consensus. :-) More accurately, I think there was no consensus around the proposed changes. Ricardo and I argued in favor of honoring =E2=80=98INSIDE_EMACS= =E2=80=99 and disabling colors when it is set. In terms of process, I think it=E2=80=99s a case where we should make sure = the people involved in the discussion can come to an agreement before going further (info "(guix) Commit Access"). WDYT? > Here [1] is explained the 2 issues. One issue comes from *eshell* and > should be solved upstream, as explained here [2] and has been already > explained by Ricardo there [3]. Upstream bug report is opened, AFAICT, > and merged soon [4]. Great, thanks for filing upstream bugs! > The other issue is "that the OSC is not always supported and some > terminal emulators are not doing the correct thing. For example EShell > or (incorrectly build) Mate of Trisquel. Therefore, instead of > displaying this special character, just print the full path of the > generation file and the commit url." [5]. And this is not related to > Emacs and/or INSIDE_EMACS but related to the support of the OSC by the > terminal emulator. And the highlighting is another topic. As I wrote elsewhere, we avoid working around terminal bugs in Guix itself. In this case, the bugs are in an old VTE version and about to be fixed in Eshell, both of which are good reasons not to try to paper over it in Guix. > Well, from my understanding, the question was about the name of this > variable "INSIDE_EMACS" to replace the OSC by the full path and > how/where to document it, see Pierre's message [6] but then Ricardo > answered [7]: "we should not document it in Guix, nor should we rename > it to GUIX_INSIDE_EMACS". > > Maybe the misunderstanding comes from there. I see reluctance to the proposed changes in (I agree with Ricardo=E2=80=99s concerns). To me, that suggests at least that further discussion would have been needed before pushing these three commits. What should we do now? Thanks, Ludo=E2=80=99.