python2 in git

python2 in git

[Ricardo Wurmus]

Hi Guix,

our “git” package has python-2 among its inputs.  It says this:

    ("python" ,python-2) ; CAVEAT: incompatible with python-3 according to INSTALL

The INSTALL file for git 2.25.1 says this about Python:

	- Python version 2.4 or later (but not 3.x, which is not
	  supported by Perforce) is needed to use the git-p4 interface
	  to Perforce.

The git-p4 script does, however, contain conditionals to accomodate
Python 3.  Here’s an example:

--8<---------------cut here---------------start------------->8---
# support basestring in python3
try:
    unicode = unicode
except NameError:
    # 'unicode' is undefined, must be Python 3
    str = str
    unicode = str
    bytes = bytes
    basestring = (str,bytes)
else:
    # 'unicode' exists, must be Python 2
    str = str
    unicode = unicode
    bytes = str
    basestring = basestring
--8<---------------cut here---------------end--------------->8---

It also uses the Python 3 style “print” call instead of the Python 2
style statement.

I would like to build git with the latest version of Python.  Any
objections?

--
Ricardo

Re: python2 in git

[Maxim Cournoyer]

Hi Ricardo!

On March 3, 2020 12:43:29 PM UTC, Ricardo Wurmus <rekado@elephly.net> wrote:
>Hi Guix,
>
>our “git” package has python-2 among its inputs.  It says this:
>
>("python" ,python-2) ; CAVEAT: incompatible with python-3 according to
>INSTALL
>
>The INSTALL file for git 2.25.1 says this about Python:
>
>	- Python version 2.4 or later (but not 3.x, which is not
>	  supported by Perforce) is needed to use the git-p4 interface
>	  to Perforce.
>
>The git-p4 script does, however, contain conditionals to accomodate
>Python 3.  Here’s an example:
>
>--8<---------------cut here---------------start------------->8---
># support basestring in python3
>try:
>    unicode = unicode
>except NameError:
>    # 'unicode' is undefined, must be Python 3
>    str = str
>    unicode = str
>    bytes = bytes
>    basestring = (str,bytes)
>else:
>    # 'unicode' exists, must be Python 2
>    str = str
>    unicode = unicode
>    bytes = str
>    basestring = basestring
>--8<---------------cut here---------------end--------------->8---
>
>It also uses the Python 3 style “print” call instead of the Python 2
>style statement.
>
>I would like to build git with the latest version of Python.  Any
>objections?

Good analysis! None from me!

Maxim

Re: python2 in git

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

Ricardo,

Ricardo Wurmus 写道：
> I would like to build git with the latest version of Python. 
> Any
> objections?

Quite the opposite.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]