From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:51496)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFlA3-0006pP-IA
 for guix-patches@gnu.org; Sat, 21 Mar 2020 16:56:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFlA2-00006D-GX
 for guix-patches@gnu.org; Sat, 21 Mar 2020 16:56:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42301)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jFlA2-000068-DZ
 for guix-patches@gnu.org; Sat, 21 Mar 2020 16:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFlA2-00065a-Ck
 for guix-patches@gnu.org; Sat, 21 Mar 2020 16:56:02 -0400
Subject: bug#39786: [PATCH] Add dragonfly-reverb.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.39786.D39786.158482414323376.done@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <f1eff2393c8504d3d55ff08b82d57b69a05e3472.camel@zrythm.org>
 <877dzd8xly.fsf@nicolasgoaziou.fr>
 <458932661ece13a229a0ca6e29d6decab90f044e.camel@zrythm.org>
Date: Sat, 21 Mar 2020 21:55:33 +0100
In-Reply-To: <458932661ece13a229a0ca6e29d6decab90f044e.camel@zrythm.org>
 (Alexandros Theodotou's message of "Sat, 21 Mar 2020 19:09:48 +0000")
Message-ID: <87v9mx77i2.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 39786-done@debbugs.gnu.org

Hello,

Alexandros Theodotou <alex@zrythm.org> writes:

> Attaching the updated patch. I also removed some unneeded
> dependencies.

Thank you! I applied your patch, with the following changes :

> +(define-public dragonfly-reverb

I fixed the indentation, which was a bit off,

> +           (lambda* (#:key inputs outputs #:allow-other-keys)

I removed `inputs' as it was not needed.

> +    (synopsis "Concert hall reverb and room reverb effects")
> +    (description
> +     "Dragonfly Reverb is a bundle of two free audio effects: a concert
> +hall reverb and a room reverb.  Both are available as LV2 plugins as well
> +as JACK standalone applications.")
> +    (home-page "https://michaelwillis.github.io/dragonfly-reverb/")

I moved `home-page' above `synopsis'.

Regards,

-- 
Nicolas Goaziou