From: Mathieu Othacehe <othacehe@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 45860@debbugs.gnu.org
Subject: [bug#45860] Improve PostgreSQL service.
Date: Fri, 15 Jan 2021 09:56:41 +0100 [thread overview]
Message-ID: <87v9byo9x2.fsf@gnu.org> (raw)
In-Reply-To: <87a6tb9o84.fsf@cbaines.net> (Christopher Baines's message of "Thu, 14 Jan 2021 21:56:43 +0000")
Hello Chris,
> I haven't read through these changes in detail, but the mixing of the
> record describing the config file, and the record for configuring the
> service introduces the limitation that you can no longer specify any
> lowerable object (like a file) or something like a string to use a
> config file outside of the store. Did you have a reason for mixing the
> records together?
I must admit I overlooked that possibility. The reason for merging the
records is that the "log-destination" is now needed both to enable
"pg_ctl" logging in "postgresql-shepherd-service" and in
"postgresql-config-file" to be written in PostgreSQL configuration.
Plus having a record called <postgresql-configuration> that does not
contain some of the configuration field feels weird.
Is passing a lowerable config file a use case of yours? In that case I
could still add a "raw-config" field to override the configuration file
creation.
Thanks,
Mathieu
next prev parent reply other threads:[~2021-01-15 8:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 13:36 [bug#45860] Improve PostgreSQL service Mathieu Othacehe
2021-01-14 21:56 ` Christopher Baines
2021-01-15 8:56 ` Mathieu Othacehe [this message]
2021-01-16 11:44 ` Christopher Baines
2021-01-18 10:16 ` [bug#45860] [PATCH v2 0/5] services: postgresql: Improve service Mathieu Othacehe
2021-01-18 10:16 ` [bug#45860] [PATCH v2 1/5] services: postgresql: Use Guile datatypes Mathieu Othacehe
2021-01-18 10:16 ` [bug#45860] [PATCH v2 2/5] services: postgresql: Add socket directory support Mathieu Othacehe
2021-01-27 8:35 ` Christopher Baines
2021-01-28 12:04 ` Mathieu Othacehe
2021-01-18 10:16 ` [bug#45860] [PATCH v2 3/5] services: postgresql: Add log " Mathieu Othacehe
2021-01-18 10:16 ` [bug#45860] [PATCH v2 4/5] services: postgresql: Wrap long lines Mathieu Othacehe
2021-01-18 10:16 ` [bug#45860] [PATCH v2 5/5] services: postgresql: Add postgresql-role-service-type Mathieu Othacehe
2021-01-27 8:48 ` Christopher Baines
2021-01-28 12:05 ` bug#45860: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9byo9x2.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=45860@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.