From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4IhsKsAIWWD8DwAA0tVLHw (envelope-from ) for ; Mon, 22 Mar 2021 21:14:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eFVDJsAIWWAiagAAbx9fmQ (envelope-from ) for ; Mon, 22 Mar 2021 21:14:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6435E16142 for ; Mon, 22 Mar 2021 22:14:40 +0100 (CET) Received: from localhost ([::1]:56676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lORsl-0004bi-Id for larch@yhetil.org; Mon, 22 Mar 2021 17:14:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lORsb-0004bL-S6 for guix-devel@gnu.org; Mon, 22 Mar 2021 17:14:29 -0400 Received: from world.peace.net ([64.112.178.59]:48338) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lORsa-0004lU-1M for guix-devel@gnu.org; Mon, 22 Mar 2021 17:14:29 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lORsN-00066G-Eu; Mon, 22 Mar 2021 17:14:15 -0400 From: Mark H Weaver To: Andreas Enge , =?utf-8?Q?L=C3=A9o?= Le Bouter Subject: Re: imagemagick@6.9.11-48 to graft or not to graft with 6.9.12-2 In-Reply-To: References: Date: Mon, 22 Mar 2021 17:12:35 -0400 Message-ID: <87v99iki3l.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616447680; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=9pbX50OYrmPehp/4vlqtnj4M22GCE5Txq6A9kg3iQ3Y=; b=iUIGdLYJ9r1uyBzaQdIyZtsd7xnwl6dXEjL24srSXnXVw/UC7iim3381QTBLDP9mRkr9Uo GPJQSHZdl721puptdODvK0cBJXZYpteYrh8Vzzb8EbexCrpXpR5bOMaaIuZJw23UskXr89 IEOpc9UPk01fuTIh67b5IXk6LIv0k0nYObOjoR7pBNByTnCE5Z9utCqEKSB9Wm9vWFNiSC rYxNqvUnry3kN/DnPqxOOgWYryxz83FdQz9ItfARCvHLkEpd7CVZGSxwSx1y/kGBQAVPC5 xkVRIItG16jHRCS5mxVG7wTGiBsaYjvXkgAfk6+zHhY340PsFI4/Gm7HPoRqfQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616447680; a=rsa-sha256; cv=none; b=NKjmRKfQPtBDrb9tZoO8zasCxeaxrxE5dzvljzwvf3YoAYpbuTPa77tTfniIl0Dy5U7yrX qKK7YnubxtchqglE4L7V21wJoQIEtp3/WVh5O4ymEimsV4u5mQ69lQuiJyPDo0ymJsoA/2 bowWgqTdT3vFxHg7tzrk6DxK1NtFnDQXbJC6JkcdACmtkqQoVpOXFZ6eIadkoMeqrOpGbp mqHUKO/cBg3GXSEs1ngaqnv7SG5iW2bzDFY/UaZOU/mzpwdCtKzN+wTesdJalDjFRywaHc USDmHTZrwmhYKvKPh7Tqf+XZ9fsev/aU4fDg4MjXIIAAknIhhxO9pUMWlr/bOw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 6435E16142 X-Spam-Score: -0.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2rjZVQDBq7Ts Hi Andreas, Andreas Enge writes: > And please let us agree that in the future, we only backport fixes in grafts > and do not update version numbers. I agree that in this particular case, that's what should have been done, and that we should still try to do it. It will be several days at least before I'm able to look at it, though. Would someone else like to try? I also agree that in general, we should be more careful to check for ABI compatibility before grafting. Moreover, if an update includes substantial changes other than bug fixes, I agree that backporting the fixes is highly preferable for grafting purposes. However, I think it would be going too far to adopt your proposal as a general rule for all grafts. In some cases, it can clearly be seen that an upstream release includes little more than bug fixes. For example, if the recent gvfs-1.40.2 security update had required grafting, I would not have hesitated to do so, and that would have been much simpler and IMO cleaner than importing the upstream patches into our tree. I'll also note that fewer imported patches makes for less review work by those of us who try to keep an eye on changes made to Guix, to help guard against the possibility of malicious "fixes" being introduced by our growing list of committers. Note that this could happen without any ill intent on the part of the committer, if their development machine is compromised by a third party. What do you think? Regards, Mark