all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice <me@tobias.gr>
To: guix-devel@gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: Why ban underscores?
Date: Sun, 04 Apr 2021 22:49:45 +0200	[thread overview]
Message-ID: <87v991vkpi.fsf@nckx> (raw)

[-- Attachment #1: Type: text/plain, Size: 2063 bytes --]

Guix, Ludo',

I was surprised by this commit:

--8<---------------cut here---------------start------------->8---
commit 426ade6c8bdab243da719e369a887284368179bb (upstream/master)
Author: Xinglu Chen <public@yoctocell.xyz>

    import: go: Replace underscores with hyphens in package names.

    As per section '16.4.2 Package Naming' in the manual, use 
    hypens
    [sic] instead of underscores in package names.

    * guix/import/go.scm (go-module->guix-package-name): Replace
    underscores with hyphens.

    Signed-off-by: Leo Famulari <leo@famulari.name>
--8<---------------cut here---------------end--------------->8---

Indeed, underscores were explicitly banned in 2014 (commit 
25083588).  Why?

Where's the advantage in renaming the following packages from 
their canonical names?

--8<---------------cut here---------------start------------->8---
λ ./pre-inst-env guix lint -c name # not upstream yet :-)
guix/packages.scm:464:2: efi_analyzer@0.0.0-0.77c9e3a: name should 
not contain '_'
gnu/packages/file-systems.scm:606:10: jfs_fsck-static@1.1.15: name 
should not contain '_'
gnu/packages/installers.scm:36:12: nsis-x86_64@3.05: name should 
not contain '_'
gnu/packages/mingw.scm:47:12: mingw-w64-x86_64@8.0.0: name should 
not contain '_'
gnu/packages/mingw.scm:47:12: mingw-w64-x86_64-winpthreads@8.0.0: 
name should not contain '_'
gnu/packages/perl.scm:2264:10: perl-crypt-unixcrypt_xs@0.11: name 
should not contain '_'
gnu/packages/python-web.scm:2528:10: python-requests_ntlm@1.1.0: 
name should not contain '_'
gnu/packages/ruby.scm:5450:10: ruby-progress_bar@1.1.0: name 
should not contain '_'
gnu/packages/ruby.scm:9222:10: ruby_version@1.0.2: name should not 
contain '_'
gnu/packages/ruby.scm:4808:10: ruby-data_uri@0.1.0: name should 
not contain '_'
--8<---------------cut here---------------end--------------->8---

I'd rather change the manual to allow underscores than blacklist 
them, but am curious why they were cancelled in the first place.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

             reply	other threads:[~2021-04-04 20:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-04 20:49 Tobias Geerinckx-Rice [this message]
2021-04-04 20:54 ` Why ban underscores? Vincent Legoll
2021-04-04 21:05 ` Mark H Weaver
2021-04-05  1:05   ` Bengt Richter
2021-04-17 15:54 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v991vkpi.fsf@nckx \
    --to=me@tobias.gr \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.