all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Guillaume Le Vaillant <glv@posteo.net>
Cc: 48225@debbugs.gnu.org,
	Leo Prikler <leo.prikler@student.tugraz.at>,
	Sharlatan Hellseher <sharlatanus@gmail.com>
Subject: bug#48225: Wrong result of package-name->name+version
Date: Sat, 08 May 2021 12:27:19 +0200	[thread overview]
Message-ID: <87v97t8qrc.fsf@gnu.org> (raw)
In-Reply-To: <8735v0b53e.fsf@yamatai> (Guillaume Le Vaillant's message of "Thu, 06 May 2021 09:10:13 +0000")

Hi Guillaume,

Guillaume Le Vaillant <glv@posteo.net> skribis:

> From 1e37a89b943a818b5274c1d5f31143ca48bad40a Mon Sep 17 00:00:00 2001
> From: Guillaume Le Vaillant <glv@posteo.net>
> Date: Thu, 6 May 2021 10:32:56 +0200
> Subject: [PATCH] build-system: asdf: Work around package-name->name+version
>  bug.
>
> This patch modifies how the name of the main Common Lisp system is extracted
> from the full Guix package name to work around bug#48225 concerning the
> 'package-name->name+version' function.
>
> Fixes <https://issues.guix.gnu.org/41437>.
>
> * guix/build-system/asdf.scm (asdf-build): Fix 'systems' function.
> * guix/build/asdf-build-system.scm (main-system-name): Fix it.

If it works for you, sounds good to me.  Please do rebuild as many CL
packages, with different CL implementations, to make sure we do not
overlook any corner case.

> +          (let* ((lisp-prefix (string-append lisp-type "-"))
> +                 (package-name (hyphen-separated-name->name+version
> +                                (if (string-prefix? lisp-prefix name)
> +                                    (string-drop name
> +                                                 (string-length lisp-prefix))
> +                                    name))))
> +            `(quote ,(list package-name)))

I’d like to see a FIXME in there: this is all guesswork and we should
eventually replace guesses with known-good info.

What would it take to pass the right package name and implementation
name upfront from the package?

Thanks,
Ludo’.




  reply	other threads:[~2021-05-08 10:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04 13:35 bug#48225: Wrong result of package-name->name+version Guillaume Le Vaillant
2021-05-04 19:39 ` Leo Prikler
2021-05-04 20:08 ` Ludovic Courtès
2021-05-05 21:27 ` bug#48225: Simple workaround Sharlatan Hellseher
2021-05-06  9:10   ` bug#48225: Wrong result of package-name->name+version Guillaume Le Vaillant
2021-05-08 10:27     ` Ludovic Courtès [this message]
2021-05-08 12:41       ` Guillaume Le Vaillant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v97t8qrc.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=48225@debbugs.gnu.org \
    --cc=glv@posteo.net \
    --cc=leo.prikler@student.tugraz.at \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.