From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cAaTIyTWQ2HYSgEAgWs5BA (envelope-from ) for ; Fri, 17 Sep 2021 01:41:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qHM9HyTWQ2E/CwAAB5/wlQ (envelope-from ) for ; Thu, 16 Sep 2021 23:41:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EA4BF896E for ; Fri, 17 Sep 2021 01:41:23 +0200 (CEST) Received: from localhost ([::1]:47878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mR10N-000271-3K for larch@yhetil.org; Thu, 16 Sep 2021 19:41:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR102-00023X-Cq for guix-patches@gnu.org; Thu, 16 Sep 2021 19:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46322) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mR101-0004KG-Uv for guix-patches@gnu.org; Thu, 16 Sep 2021 19:41:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mR101-0004e5-PT for guix-patches@gnu.org; Thu, 16 Sep 2021 19:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50620] [PATCH 1/2] guix: packages: Document 'computed-origin-method'. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Sep 2021 23:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50620 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 50620@debbugs.gnu.org, zimoun Received: via spool by 50620-submit@debbugs.gnu.org id=B50620.163183561517782 (code B ref 50620); Thu, 16 Sep 2021 23:41:01 +0000 Received: (at 50620) by debbugs.gnu.org; 16 Sep 2021 23:40:15 +0000 Received: from localhost ([127.0.0.1]:57868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR0zG-0004ck-R9 for submit@debbugs.gnu.org; Thu, 16 Sep 2021 19:40:15 -0400 Received: from world.peace.net ([64.112.178.59]:59558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR0zF-0004cT-Fh for 50620@debbugs.gnu.org; Thu, 16 Sep 2021 19:40:13 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mR0z8-0007jB-TD; Thu, 16 Sep 2021 19:40:06 -0400 From: Mark H Weaver In-Reply-To: <9b6ee27ff10e1042a5d61d0f93d957cf760e9ecb.camel@gmail.com> References: <9b6ee27ff10e1042a5d61d0f93d957cf760e9ecb.camel@gmail.com> <20210916114734.2686426-1-zimon.toutoune@gmail.com> Date: Thu, 16 Sep 2021 19:38:22 -0400 Message-ID: <87v930ay5y.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631835684; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=+MgZdIjYcN4a6V7K8UZVpVEzAFFQVBomRw0ive8XZLg=; b=Dbp+fzMS4U39bW1RhDU3EzBESylLEQTZhGp9MSc2AY5BmeJZ77wB/9fDAO8SxuDBNn07V8 oinP/bqoZ38KeigB/AYkrDpoKFVR6+X6Q9td3EDSRx2gcw6ajrJ1SjcML0oGXUmvrdEC1Z 9/hbowSLOUCpSVZOs4N2hKIfbbmOyipNMhmLP4YkC8Q5fiInhxe23L3QkA9KOity336Gh0 ij13ce9cMS/WiH7nqxbXVTrLHIDst1YT9nHThlvf8fkReClZ/xbn6I6nb7t/rQLbHRV2c1 mPZnHqH6T7YDYXG1jkcTWLqj9hZokbjUHYXTFHyUY+lqGstkxctJSjotheZrBQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631835684; a=rsa-sha256; cv=none; b=tVL3EgeVIOH11PVMvug0Rgk/8ss2QrD20CE6Y5F9KVHHZB9XW+HLS8eF3Yv3QxDVh8IwhG fGqEFr9H+8hElNKFOOQmsRBV6atBWeyOXo8w7EhjLR9vdoiq8rYYPilZJ3bhGxTZnM9Pa8 VTXpAzAIWr0Q/ifZA7S0hjFEx5SAYDnMRUHHqQfq429F5iVMAFq+fMFgdkds0f16UUpcdk uJYoiSxzpHxe1nPPMRxgIPm4Wve1k1bmaYN6OYQl8P2pNnMbYQQuiDiA+HZ/VW20TZhXWv bFPDllasnBFxrNUi3Hic/sJhwvwD1CIY7X7SGJ+6AvMk/wImWcDLmPOlGw1gAw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.40 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EA4BF896E X-Spam-Score: -2.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: Uwhwq8stXlNM Hi Liliana, Liliana Marie Prikler wrote: > I think that rather than putting this into (guix packages) itself, we > might want to put it into its own file like (guix computed-origins) and > choose a method name that is actually a verb, similar to git-fetch or > svn-fetch. Perhaps simply call it compute-origin? These suggestions sound fine to me, although I don't have a strong opinion either way. I'm happy to leave these details to others to decide. > If done this way, there'd be the benefit that modules with packages > using this thing would have to explicitly request the presence of the > symbol through their use-modules clauses. Actually, for better or worse, Guile's '@@' form does not require the named module to be imported using 'use-modules', so I don't think this benefit strictly exists as stated above. However, I agree that it's good practice to list all imported modules in the '#:use-module' clauses at the top of the file wherever possible [*], and that there may be some benefit in declaring the use of 'computed-origins' at the top of each file. Thanks, Mark [*] It's not always possible in the presence of cyclic module dependencies. -- Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about .