From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0JVBDTU+R2HuRAEAgWs5BA (envelope-from ) for ; Sun, 19 Sep 2021 15:42:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mBDRCDU+R2EAdgAAbx9fmQ (envelope-from ) for ; Sun, 19 Sep 2021 13:42:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F16C614E7E for ; Sun, 19 Sep 2021 15:42:12 +0200 (CEST) Received: from localhost ([::1]:51068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRx5A-0006j5-1h for larch@yhetil.org; Sun, 19 Sep 2021 09:42:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRx51-0006dw-1N for guix-patches@gnu.org; Sun, 19 Sep 2021 09:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54382) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRx50-0007Fl-Pq for guix-patches@gnu.org; Sun, 19 Sep 2021 09:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRx50-00083u-FI for guix-patches@gnu.org; Sun, 19 Sep 2021 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50614] [PATCH] build: utils: Add =?UTF-8?Q?=E2=80=98list-when=E2=80=99?= macro. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Sep 2021 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50614 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 50614@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 50614-submit@debbugs.gnu.org id=B50614.163205889730953 (code B ref 50614); Sun, 19 Sep 2021 13:42:02 +0000 Received: (at 50614) by debbugs.gnu.org; 19 Sep 2021 13:41:37 +0000 Received: from localhost ([127.0.0.1]:37695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRx4a-00083B-TD for submit@debbugs.gnu.org; Sun, 19 Sep 2021 09:41:37 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:50678 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRx4Z-00082m-IR for 50614@debbugs.gnu.org; Sun, 19 Sep 2021 09:41:35 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1632058887; bh=1MobOyZeaeyqrFclISZ/MD8BwR4twjLBlp8V4xJOQoA=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=om9nQm73uXILBREHkyRRHNlSU0FiVYzggeNHCuLy6SeTveZnu2+LgwhqekAwzsRTf AGS8J0rPyHw7s0k4AReEAjktikaJVc22IMKJIxyRHx0J3Uf7Jrr6nny5EwskmSgdsN fBJx3jQsYaCLn1l1gyiaPXY0uTG0SHex7Tw/AP0E= In-Reply-To: <86tuijggcr.fsf@mgsn.dev> References: <08db559a4e24a409d332b3552d6a176de6353166.1631867018.git.public@yoctocell.xyz> <86tuijggcr.fsf@mgsn.dev> Date: Sun, 19 Sep 2021 15:41:26 +0200 Message-ID: <87v92wof7d.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: F16C614E7E X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: QepP5/K4KwPv --=-=-= Content-Type: text/plain On Fri, Sep 17 2021, Sarah Morgensen wrote: > Hi, > > Looking at this again I have a couple more comments. > > Xinglu Chen writes: >> +@cindex miscellaneous build utilities >> +This section documents some miscellaneous utilities that are useful to >> +have. > > "that are useful to have" is implied by its presence in the manual, so > it's unnecessary to write it. Good point. > Also, you might consider adding a rule to .dir-locals.el: > > (eval . (put list-when 'scheme-indent-function 1)) > > which would cause it to be indented like this: > > (list-when expr1 > expr2 > expr3) Yes, that would be a good idea. > (I pointed out a couple other minor grammar corrections in the last > review--did you see those?) Oops, looks like I missed those. I will send a v2 with the suggestions applied. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFHPgcVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5ZpQP/0/p2m+XQWnl0m7pXDJtBTuGZr5f 01V38qdlazS0Yn7gD7pHbpuMDn7874nDVDndilxfp9bIddwNqLr1lKsFSELi/gsA ZuvkUO2VfKD2Xw/XmuZLcfG6vwRm22SHIcmjgOZs9QOkb05FRzhe9n8OWVTZypPC QsvUHZJoiiUX0Qn2eAm+rdAYidY2UNp0H/KbbIF9G8sCM9W43mhytpREpWAq5toY doohKSeor5lM6fuJeolwvH85VXJ6PoAR98cZ3eWVKvbqTlmWzWFoQtBZIej6VELn ipukqH4IxE8XIDUXpnuhtNq29CspQ6BM/I/axUdeDBCneqTvZx12UUN3y5NoAW1L aQNUXZxk1BsUil56UAINCr5B66qjajLmDBTThHoX+W+2EZtq6h5kOLe2gcuSKf7/ IMVE7FXGuLWNQYv6R9smAU0/CBikg8alQuAkaPCv+NwbfYc8gqzbhwiKlmDoo5W3 nPMuc4A+EbyPZV26jeJaavhZr03NP8RnyBWuR9pp68243e2vAnjqQSyqiUCgXX2s bb/eIBfCI3Y5xyN2ERdD5bgK224kiZkIi/wLOH5DGJGrYuIK6kYevn8l8nb1V9Oi 1HEhk6Byy/DircVXevmXOOn1UlPvcxCTdFvR4VwbwpmyOTJjDdG2Xcm7ZmVQvNSk FjpvyzTakUHdep2n =mO9A -----END PGP SIGNATURE----- --=-=-=--