From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wDp5E5uUeWENhAAAgWs5BA (envelope-from ) for ; Wed, 27 Oct 2021 20:04:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qGciD5uUeWFeegAA1q6Kng (envelope-from ) for ; Wed, 27 Oct 2021 18:04:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F03DA1AF96 for ; Wed, 27 Oct 2021 20:04:10 +0200 (CEST) Received: from localhost ([::1]:59360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfnHW-0008P7-4e for larch@yhetil.org; Wed, 27 Oct 2021 14:04:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfn5m-0001f1-W4 for guix-patches@gnu.org; Wed, 27 Oct 2021 13:52:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfn5m-0006sD-Lr for guix-patches@gnu.org; Wed, 27 Oct 2021 13:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mfn5m-0007SS-CM for guix-patches@gnu.org; Wed, 27 Oct 2021 13:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51428] core-updates-frozen-batched-changes built and ready to merge Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Oct 2021 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51428 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 51428@debbugs.gnu.org Received: via spool by 51428-submit@debbugs.gnu.org id=B51428.163535710628641 (code B ref 51428); Wed, 27 Oct 2021 17:52:02 +0000 Received: (at 51428) by debbugs.gnu.org; 27 Oct 2021 17:51:46 +0000 Received: from localhost ([127.0.0.1]:50489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfn5V-0007Rs-6p for submit@debbugs.gnu.org; Wed, 27 Oct 2021 13:51:46 -0400 Received: from mail-qv1-f54.google.com ([209.85.219.54]:42891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfn5K-0007RU-N1 for 51428@debbugs.gnu.org; Wed, 27 Oct 2021 13:51:43 -0400 Received: by mail-qv1-f54.google.com with SMTP id jk5so2293184qvb.9 for <51428@debbugs.gnu.org>; Wed, 27 Oct 2021 10:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=TUwYq4G9GiGYivPjpN1RSDd97wnAkNLwAEDCgRMf1U0=; b=k9OkvonLHWjDJnXIYx/Zpa3vTzS1bGvBtNeO9ahmVHE3xFWpe9HKfkbvCTRYDCrIkE ZDBkKtHcXKapB3nCmVKLYdhV33VPl6wZtvFBF7bngf+VH3kxL9sSOCd8hLzAFnBzhgyE CTFShRM4vC4PO3fi6dv4IL4LmCKXhPqjdmOIw6jfbG+b2eJ0iLEDr7lb2RX2gC0Vum/T 0r/4D7xi259ChCYI2tZAjZi+C7nO4AEyq2LsRHeJ42N7Zm9hTpyGKgkPAH+ZNh0KOeKz nBSuUpEnA/l5aMbjg/Lp3TV7xkERXLr8Q9XTw/UtWFlb29XXFx5T52ku5+ibFboqIWua 0peg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=TUwYq4G9GiGYivPjpN1RSDd97wnAkNLwAEDCgRMf1U0=; b=5D0mFmZGsi0vCG+BqXa3NMjyW5aWSxDmty0MluEPJX76Pg/98kSzUs9omg1W9ZNb1L 4mjHY+1/4Jl+aAfYVwnwlYgzfuQ45gw078kgHr8W5DNeFYWk1pvmZBTnShrlh7xKE402 JqFnVhM0NeE1YRCuA6oPhQYRURC9BxLr6TPmlTmCD1n2QevTAavaixdjFtP9JV4ZCI3H RKeukNi3KstfaIgfA5miDmKrehgjBAFyGwRwYf3Dx9zaiaKBf6pCp/XNBrjlkBOTAckZ HPpQ/RCXUf7Cg3HF7KDyjDM9qNx5g00lideQIAfkLA8/xG77yQsGlNVr3KLbccocXHMd fftw== X-Gm-Message-State: AOAM532vqq2/Pjph/Kf5iCwNQrz3JgJxQtKtM0WNzm+dTf+dFcqpTbpQ pFiBnSP8y+LwQWXhfoN7NJ4uNrFVfwI= X-Google-Smtp-Source: ABdhPJyD+bE2CWhCPcLc7pkFXL1fBnZSQ79k4Mrz/ual3csGHbbB1QyPdkzfdEx1mDTPmn1cxDQtCg== X-Received: by 2002:ad4:47ac:: with SMTP id a12mr23838975qvz.51.1635357088748; Wed, 27 Oct 2021 10:51:28 -0700 (PDT) Received: from hurd (dsl-152-69.b2b2c.ca. [66.158.152.69]) by smtp.gmail.com with ESMTPSA id h12sm455567qkp.52.2021.10.27.10.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 10:51:28 -0700 (PDT) From: Maxim Cournoyer References: <20211027045151.9889-1-maxim.cournoyer@gmail.com> <20211027045151.9889-17-maxim.cournoyer@gmail.com> <87mtmufrw3.fsf_-_@gnu.org> Date: Wed, 27 Oct 2021 13:51:26 -0400 In-Reply-To: <87mtmufrw3.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 27 Oct 2021 16:45:32 +0200") Message-ID: <87v91ibbkx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635357851; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TUwYq4G9GiGYivPjpN1RSDd97wnAkNLwAEDCgRMf1U0=; b=FMTper4IvgRS+l1qod+PSUASuG7R+w3FmKGj3/aDPmj5HvOgcVr5lavPykYu+7/TG6dCF+ HYCw2Yldtd5/lxiyVFUNS4B7jscKJ7fk8b6317hGaxlI/EC6fb5M+7uBa+uuptdQj2FyAv XDq+WE+Vyp9rhphPQp+PGgLiJiuvcoVehY/o3400OXD4PlUYJo529zA7ZZ7zaY5NxeOaAS Arg9lmuO1cnfRWjokchvoH78fqM/PIyr3kv+eKVCKZ9VFs9JrEvwmhgtQZsmI36tnmV6zd DxgaSkLH98gyN9nVDMN4WJhHs2kRTYfwMrq/Re9VLM95ANsGeLxGZKPkTohp2Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635357851; a=rsa-sha256; cv=none; b=RyRNuydqMQ/ZAROVEx6au2Mq56yKfmjvxTfDr5lkP4Wrs4Qhdr+GriZIQ+pjiSo/FzZhLW szD0fOxss/dcUEv9oRjdBAN3dmD9G63VPp6R7Kh08Y0qOSBsL30krW6mZMR4GsJCg1aCsK CFVnOzF2bSGu1V/D3PcNyod19BWmbSMVHUVKZCyv6JY8KR9WBRc3xjgwvRNewLUo4n/zQY slxllgv4MfKsRCg/MTBAb0zyJQXsn9hTSnaftzK73J/3TbXIxQrGZMjL9M/2GRpxug0s44 cA87yXf8DRj8nD+2Oj3IMKOr9ejXqQzw1GQ7opj/u0NAar2vP3qHO/b4ogywzw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=k9OkvonL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=k9OkvonL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F03DA1AF96 X-Spam-Score: 0.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: 12rFhp0NuV5s Hello, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> This paves the way toward properly fixing https://issues.guix.gnu.org/50= 957. >> >> * guix/profiles.scm (gdk-pixbuf-loaders-cache-file): Add procedure... >> (%default-profile-hooks): ... and register it as a profile hook. > > [...] > >> + (mlet %store-monad ((%gdk-pixbuf (manifest-lookup-package >> + manifest "gdk-pixbuf")) > > You could call it =E2=80=98gdk-pixbuf?=E2=80=99 since it=E2=80=99s used a= s a boolean. > >> + (gexp->derivation "gdk-pixbuf-loaders-cache-file" build >> + #:local-build? #t >> + #:substitutable? #f >> + #:properties >> + '((type . profile-hook) >> + (hook . gdk-pixbuf-loaders-cache-file))) Good idea; done: modified guix/profiles.scm @@ -1167,8 +1167,8 @@ (define (gdk-pixbuf-loaders-cache-file manifest) (define gdk-pixbuf ;lazy reference (module-ref (resolve-interface '(gnu packages gtk)) 'gdk-pixbuf)) =20 - (mlet %store-monad ((%gdk-pixbuf (manifest-lookup-package - manifest "gdk-pixbuf")) + (mlet %store-monad ((%gdk-pixbuf? (manifest-lookup-package + manifest "gdk-pixbuf")) (gdk-pixbuf-bin -> (file-append gdk-pixbuf "/bin"))) (define build (with-imported-modules (source-module-closure @@ -1178,7 +1178,7 @@ (define build (setenv "PATH" (string-append #$gdk-pixbuf-bin ":" (getenv "PA= TH"))) (generate-gdk-pixbuf-loaders-cache '#$(manifest-inputs manifes= t) (list #$output))))) - (if %gdk-pixbuf + (if %gdk-pixbuf? (gexp->derivation "gdk-pixbuf-loaders-cache-file" build #:local-build? #t #:substitutable? #f =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20 > No showstopper but we should eventually add this to (guix status) for > nicer reporting. > > My 2=C2=A2, > Ludo=E2=80=99. Thanks, I was wondering why the hook message output looked different. Done, like: modified guix/status.scm @@ -381,6 +381,8 @@ (define (hook-message hook-type) (G_ "building CA certificate bundle...")) ('emacs-subdirs (G_ "listing Emacs sub-directories...")) + ('gdk-pixbuf-loaders-cache-file + (G_ "generating GdkPixbuf loaders cache...")) ('glib-schemas (G_ "generating GLib schema cache...")) ('gtk-icon-themes Maxim