all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Attila Lendvai <attila@lendvai.name>
Cc: 53500@debbugs.gnu.org
Subject: [bug#53500] Add 42 rust packages, and update 4 of them
Date: Mon, 24 Jan 2022 13:24:46 +0100	[thread overview]
Message-ID: <87v8y9b9td.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CytKC2eH-Rmfm_TKJ2VV49-7XuVGl1jO5sTQ4Ib_4NWpsZuVM8ROJNtBojYJ_f_LlaITZmZKUo0tgWy4VxRe-Mzfbi8mm63qyHctgBwVin0=@lendvai.name> (Attila Lendvai's message of "Mon, 24 Jan 2022 12:00:56 +0000")

Hello,

Attila Lendvai <attila@lendvai.name> writes:

> this is part of my struggle to package openethereum.
>
> this patch series is a rebase of https://issues.guix.gnu.org/53401 which has unfortunately developed countless merge conflicts.
>
> this one supersedes 53401, which i have closed for good.
>
> please apply at your earliest convenience, before this one also
> develops merge conflicts.

Thank you.

Could you fix some synopses and descriptions of added packages. In
particular, a synopsis cannot start with an article, and the description
is expected to consist of full sentences. At the very least, when
inspiration is not there, you can use "This package provides ..."
template.

> -    (synopsis "Rustc-serialize compatible hex conversion traits")
> -    (description "This package provides rustc-serialize compatible hex
> -conversion traits.")
> +    (synopsis "@code{rustc-serialize} compatible hex conversion traits")
> +    (description synopsis)

Here you removed a decent synopsis+description with something less good.

> +    (synopsis "General bytes-related utilities used in Parity Technologies projects")

I would remove the "used in" part, which is not useful.

> +    (description synopsis)

Hmmm, no :)

> +    (synopsis "Crate used in Parity Technologies projects")
> +    (description synopsis)

See above.

> +    (synopsis "Salsa20 Stream Cipher")
> +    (description synopsis)

Synopsis does not need to be titlecased.

Description should differ from synopsis.

> +    (synopsis "AST representation used by Serde derive macros")
> +    (description "AST representation used by Serde derive macros.  Unstable.")

Description should use full sentences.

> +    (synopsis "The bare essentials of std::io for use in no_std")

Don't start a synopsis with "The"

> +    (description
> +      "The bare essentials of std::io for use in no_std.  Alloc support is optional.")

The first sentence is not complete.

I won't comment each description, you get the picture.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2022-01-24 12:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 12:00 [bug#53500] Add 42 rust packages, and update 4 of them Attila Lendvai
2022-01-24 12:24 ` Nicolas Goaziou [this message]
2022-01-24 18:01   ` Attila Lendvai
2022-01-25  8:21     ` Nicolas Goaziou
2022-01-25 18:31       ` Attila Lendvai
2022-01-28  0:15         ` bug#53500: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8y9b9td.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=53500@debbugs.gnu.org \
    --cc=attila@lendvai.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.