From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UOdrAi0clmIIYgEAbAwnHQ (envelope-from ) for ; Tue, 31 May 2022 15:46:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aAdsAS0clmKfDwAAG6o9tA (envelope-from ) for ; Tue, 31 May 2022 15:46:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 459E32C8E6 for ; Tue, 31 May 2022 15:46:20 +0200 (CEST) Received: from localhost ([::1]:50772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nw2CQ-0007VK-Ux for larch@yhetil.org; Tue, 31 May 2022 09:46:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw2CA-0007Ul-5x for guix-patches@gnu.org; Tue, 31 May 2022 09:46:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nw2C9-0005qZ-TL for guix-patches@gnu.org; Tue, 31 May 2022 09:46:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nw2C9-0008TI-OR for guix-patches@gnu.org; Tue, 31 May 2022 09:46:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55538] [PATCH] gnu: virtuoso-ose: Update to 7.2.7. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 May 2022 13:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55538 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Roel Janssen Cc: 55538@debbugs.gnu.org Received: via spool by 55538-submit@debbugs.gnu.org id=B55538.165400472232509 (code B ref 55538); Tue, 31 May 2022 13:46:01 +0000 Received: (at 55538) by debbugs.gnu.org; 31 May 2022 13:45:22 +0000 Received: from localhost ([127.0.0.1]:47131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nw2BN-0008S2-G5 for submit@debbugs.gnu.org; Tue, 31 May 2022 09:45:22 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]:38410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nw2BK-0008Rk-7u for 55538@debbugs.gnu.org; Tue, 31 May 2022 09:45:12 -0400 Received: by mail-qt1-f174.google.com with SMTP id v1so1512710qtx.5 for <55538@debbugs.gnu.org>; Tue, 31 May 2022 06:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=YiY0cIcBJlh7e2DCdRjm4UjbXIVm5MC6wgSb3e43tkw=; b=Iz45s/o2sfglLlQPIcag3M6WhHoNW8jFhU2MbClLOq31yKPQ+kdRnA7z7l2Xoqyc1x RmHNVCpWlnrQHcVqnVE8XIXf/oMFwkrpVdOx7AU/muBQfKH7ajHQSbNZSFKZxP+/jDZC BW7HPLmSigTh1yDD+OJPuTMvNCqzraca/theRgrFqTXgpsTLVVIEf0PFX9MbobhfKzKc MYk6MXEoLsdKllXfW2P6uurwRH4/vW8No+04i+sd/JKKIZoEUzn4o7wnbGvbuL+rTnZO +UunHQ2kRRA/JB06nEQnvCJnfGMVu5m8zYwIndxXb8qrYrFyLlYMSwIQ7B8VQrk0IsfX 14Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=YiY0cIcBJlh7e2DCdRjm4UjbXIVm5MC6wgSb3e43tkw=; b=799M6FGVZ1dW+sa9aAZtNHB6JRRMQB9gs+wJ6NqFNouiIw3rhR3MMrHPeH61+orGqJ ntFUlNPlW4nKRsINdx36JhSGdPiHJsh6Hu/0zUO8hx9KQGijsJRERA5SNRHyqpF4F28y t8x2FlOHf+9yN4i6fJo6rOiKXdCcXC2zOelJObhbD0TArqkebZOCq12WFc46UuQHX4bo HPQMjiwC0jchX8ccwB2ZZUp5FyDu3f+qWN8kCX5ATwiePqk7u/azJe79bnrggdw5ZKXs ug3/CIDJl2etbkYkbKRbCqlqxAz7vSzXIvmXDYIEnM6N7DWHJeltADGoheXS9+60b/xR mrJg== X-Gm-Message-State: AOAM533XCZ5Q/d+Ujo9gLJCiTme9qbRrdjFx+WhnqA6Z2DsP03+XKxMa 2rs+LWVYze4wJ9YsMvwwc8srdGMX2VHmsQ== X-Google-Smtp-Source: ABdhPJzB7kNYQ+08sgzcngEHFWe9GjSNvmMrkDd4Hynxcv0CCC3D6/uKYemZba6bXTGqMJSundTO2A== X-Received: by 2002:ac8:5890:0:b0:2f9:a67:540a with SMTP id t16-20020ac85890000000b002f90a67540amr47256490qta.343.1654004704113; Tue, 31 May 2022 06:45:04 -0700 (PDT) Received: from hurd (dsl-154-171.b2b2c.ca. [66.158.154.171]) by smtp.gmail.com with ESMTPSA id c15-20020ac84e0f000000b00304a27bde85sm3303598qtw.1.2022.05.31.06.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 06:45:03 -0700 (PDT) From: Maxim Cournoyer References: <875ylt4rep.fsf@gmail.com> <9b71e2c249653a74c0e039670d5a60492c9c2eb0.camel@gnu.org> Date: Tue, 31 May 2022 09:44:45 -0400 In-Reply-To: (Roel Janssen's message of "Fri, 27 May 2022 12:47:18 +0200") Message-ID: <87v8tlrf3m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654004780; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YiY0cIcBJlh7e2DCdRjm4UjbXIVm5MC6wgSb3e43tkw=; b=SFffL1yd2lM5V9WfUelVkSOaBA6KfKAMU+MPAhvdxuiBILBaSMCPZ1TTdoSn+jFUSwwxyG 0Dpksudc01DEjeACTqkao5lz4fIIuuWjGvnJhXxCaFzkFQj9eh5LJD4wvwOCDGOLfdZx5n w6D274/O00IznHgn6BWBOHe8NFqyJcaFJqQxwvLQ0J1BN6nKHFzl5skOcQdz3HI0Tv8bet YyjEK2DDawRQsjs8LcLfoUAVHB18dtQj99rygWbTgauPD0W0IsUooVYVqFR80cnG0hShLZ T2ttTHaop133Xu02e0kyzoiUronomHLxrH2jiIwBzoI6cB7E44tt3QMSo1QwzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654004780; a=rsa-sha256; cv=none; b=uYm9MzXCcb2wycoSAbKkwIijG06BmsOkmElr0Jyc/K1WMNht5BYcR2pZmjQJTswrMQmahN s6Fq2D/u8a0kTKTBzfqEBwVwfl5JACLoooct4SkqBY2dncDlgm3yWAkbGeR0tybiLp5Jlg BuPsfl43B2lH+Ph328/GO0O99sGTf4PnycfL2zl9dqi2KF1etH7sOoDGHn++wSXZUluf75 B8Kw26sjPlHWqQv0vVMLAWvsM5OU5k4f0S3P5iqLt1qZe89CUA3XWD0uiZw/3tRVkX5vk8 ECED4MAARev61pZFRQwm9vOqAqdYcxNA0C0UQWn0jee3Lzbio/rXdIVDtafNrQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="Iz45s/o2"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.66 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="Iz45s/o2"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 459E32C8E6 X-Spam-Score: 4.66 X-Migadu-Scanner: scn0.migadu.com X-TUID: RlUX4fjzzFKf Hello, Roel Janssen writes: > On Wed, 2022-05-25 at 17:51 +0200, Roel Janssen wrote: >> On Wed, 2022-05-25 at 10:29 -0400, Maxim Cournoyer wrote: >> > Hi Roel, >> >=20 >> > Roel Janssen writes: >> >=20 >> > > Dear Guix, >> > >=20 >> > > I'd like to update Virtuoso OSE to the latest release (see attached = patch). >> > >=20 >> > > Other than the version number and checksum bump I noticed that some = JAR files made it in the >> > > build >> > > output.=C2=A0 I tried removing them from the source tarball using a = snippet, but then one needs to >> > > include a patch for various Makefile.am files and run the autogen.sh= script.=C2=A0 I thought this >> > > was >> > > simpler and clearer on what's actually achieved. >> >=20 >> > I fear in the future it would be easy to overlook the introduction of >> > extra bundled jars in the source, that'd get installed.=C2=A0 I feel i= t'd be >> > preferable if we removed them all from a source snippet, at the cost of >> > having to patch the build system (the extra complications you >> > mentioned). >> >=20 >> > Could you try it and send a revised patch? >> >=20 >>=20 >> Thank you for taking a look at it! To be fair, what the patches would do= , would be to avoid >> including the directories that I remove. So removing the current pre-bui= lt binaries in a snippet >> will be equally error-prone. The way I deal with this is to have an allow list of things to preserve in the source instead of a deny list; this way if new binaries get added and need to be handled, the build will break instead of using the bundled binaries silently. Thanks for the package update (and to Efraim for picking up the review where I had left it)! Maxim