From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WADuIil4rGJe6AAAbAwnHQ (envelope-from ) for ; Fri, 17 Jun 2022 14:48:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +LmoIil4rGLLMwEAauVa8A (envelope-from ) for ; Fri, 17 Jun 2022 14:48:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 462AB1D68B for ; Fri, 17 Jun 2022 14:48:41 +0200 (CEST) Received: from localhost ([::1]:48976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2BOt-0005au-Tu for larch@yhetil.org; Fri, 17 Jun 2022 08:48:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2BLS-0002HF-Qb for guix-patches@gnu.org; Fri, 17 Jun 2022 08:45:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50310) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2BLS-0008RM-66 for guix-patches@gnu.org; Fri, 17 Jun 2022 08:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o2BLS-0005ni-0y for guix-patches@gnu.org; Fri, 17 Jun 2022 08:45:02 -0400 Subject: bug#55954: [PATCH] gnu: public-inbox: Fixes to allow the testsuite to run Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 17 Jun 2022 12:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 55954 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thiago Jung Bauermann Cc: 55954-done@debbugs.gnu.org Mail-Followup-To: 55954@debbugs.gnu.org, ludo@gnu.org, bauermann@kolabnow.com Received: via spool by 55954-done@debbugs.gnu.org id=D55954.165546986122208 (code D ref 55954); Fri, 17 Jun 2022 12:45:01 +0000 Received: (at 55954-done) by debbugs.gnu.org; 17 Jun 2022 12:44:21 +0000 Received: from localhost ([127.0.0.1]:44206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2BKn-0005m8-54 for submit@debbugs.gnu.org; Fri, 17 Jun 2022 08:44:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2BKj-0005ls-L8 for 55954-done@debbugs.gnu.org; Fri, 17 Jun 2022 08:44:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58588) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2BKe-0008Mj-2G; Fri, 17 Jun 2022 08:44:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=i+zHqRI/vV25FBKSRYYcQYzEWyo+H51Lzs0/Ks2wKhk=; b=RNqMPoCUA31p1GYQGwMM xR6rMo5VieELYbUs7lGEO+VomYmB8jA4P8WjxATjRAOsxAveRv0mnCKq9nHVSPrqQz/QCXAFccaal Eae9h+wxhljMqkKYSUQG0KKtVUUDbkJSZPCYy/Bg7Ui1ax85sePe1gA4MJ/YoVdbC8dfWaSqhKtVv f81yl3ITI13hKqwBUYcK64IxiBSnijfpghp9Cgl/J1GyxE+QFvEC64tubqDi6OjtFo3KBbRqh21XU Kf2rA96vBX4wmLVrFJHpvzLMObPuZa0bQSAf2qqn0dmQYLTSoLws1PVc9i0mMasAp3bh/xq775TP7 DXoQ5OVlAhoB5w==; Received: from [193.50.110.205] (port=39738 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2BKd-0003vV-MH; Fri, 17 Jun 2022 08:44:11 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220614033223.377744-1-bauermann@kolabnow.com> <87a6adlzzj.fsf@gnu.org> <87bkushu4v.fsf@kolabnow.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 29 Prairial an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de la Pivoine X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 17 Jun 2022 14:44:09 +0200 In-Reply-To: <87bkushu4v.fsf@kolabnow.com> (Thiago Jung Bauermann's message of "Thu, 16 Jun 2022 23:38:50 -0300") Message-ID: <87v8szh33a.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655470121; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=i+zHqRI/vV25FBKSRYYcQYzEWyo+H51Lzs0/Ks2wKhk=; b=BYDwXyixP9WEKgsYhIycGeTjR0FNv82pgBqsyw9FSgOP6wRYqFgZwtDDwmXIkmvpinaix4 iF49lPaw7v9DMRH8N12V1PLu4jm8oyyuI4RzEEY4G6Q+zYRj8fyzRtd2me4nG8nKdmoSWL tj47O2S1RVYTuAOFJX/vccjEutpBla0kteSBftZJRnidD4dMTVqnUROil3etw5q4WVelMV FBgXvSd1/Rg2tb2OyBE5rMLXX47b67DBwZH1BPd4sZ5ZTYw4p4PoukXRPXpZSly5PYpcwv XTIRQttgfjzLTL2lhSq4xTU2ZLIEb1OV+fKa54eDHbtoAWNUiQCLXewEk2AcUQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655470121; a=rsa-sha256; cv=none; b=gqCZ/nZqX8HwmPDy64+YSAL7cm4JXV50nHgrGVxDYHkiCMBnLSE70kZwJMdMQXBUdSeXHo dQFwzlWh49RA/GxMTlzJhdoe/sE3kVgTl3+U06tAs+Sh/ehImnWaKIdzOpS4cab6/+s01x 5/L3GuFCS5/pNio42XXq8FsFX6QDJheucCvL1QWt6ePd2Dqn49js3nj6OesRcBv2UZHA/k zlQbIEll7/Y9AMrfHcRijt5wRlk2bFKonWnGcgUeXOYvVMZ4MisrSnmT9M/c8xDSKjTGJJ RdBJ0E8THXeo9jYuxwKS9M7gt7iobWAq062PvIhqrfOq9mCHaP8F/PRG9hN4ag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=RNqMPoCU; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.19 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=RNqMPoCU; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 462AB1D68B X-Spam-Score: -4.19 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2zTUOC77fbIv Hello, Thiago Jung Bauermann skribis: > Ludovic Court=C3=A8s writes: [...] >> Applied, thanks! > > I guess you had second thoughts. :-) Yes, sorry; I wasn=E2=80=99t sure whether bothering you was a good idea, bu= t I was also dissatisfied with that whole situation (which is not public-inbox=E2=80=99s fault!). >> It=E2=80=99s a bummer that we have to do all this. Would this work: >> >> (replace 'check >> (lambda _ >> (sigaction SIGINT SIG_DFL) >> (sigaction SIGTERM SIG_DFL) >> (sigaction SIGCHLD (lambda _ (waitpid WAIT_ANY WNOHANG))) >> >> ;; Ugly hack to make sure signal handler asyncs get a chance >> ;; to run while we=E2=80=99re in =E2=80=98waitpid=E2=80=99 during = the =E2=80=9Cmake check=E2=80=9D >> ;; invocation. >> (sigaction SIGALRM (lambda _ (alarm 1))) >> (alarm 1))) >> >> ? > > I assume there should be a "make check" in there somewhere. :-) > > Unfortunately, it didn't work. This is the check phase I tried: > > (replace 'check > (lambda _ > (setenv "TEMP" "/tmp") > (setenv "TEMPDIR" "/tmp") > (setenv "TMP" "/tmp") > (setenv "TMPDIR" "/tmp") > > (sigaction SIGINT SIG_DFL) > (sigaction SIGTERM SIG_DFL) > (sigaction SIGCHLD (lambda _ (waitpid WAIT_ANY WNOHANG))) > > ;; Ugly hack to make sure signal handler asyncs get a chance > ;; to run while we=E2=80=99re in =E2=80=98waitpid=E2=80=99 during t= he =E2=80=9Cmake check=E2=80=9D > ;; invocation. > (sigaction SIGALRM (lambda _ (alarm 1))) > (alarm 1) > (unless (zero? (status:exit-val (system* "make" "check"))) > (error "`make check' exited with error")))) > > > And this was the end of the output of the phase: > > =E2=8B=AE > Bailout called. Further testing stopped: daemon still running (PID:5282) > FAILED--Further testing stopped: daemon still running (PID:5282) > make: *** [Makefile:4141: check-each] Error 255 > error: in phase 'check': uncaught exception: > misc-error #f "~A" ("`make check' exited with error") #f > phase `check' failed after 27.7 seconds > > =E2=80=9Cdaemon still running=E2=80=9D means that lei's daemon process wa= sn't reaped. Damnit, I wonder how that can happen. >> If not, the solution you propose LGTM. > > Thanks. Hopefully this can be fixed in Guix's build machinery itself in > the core-updates branch and all the packages that are using this hack > can drop it then. Yeah. Anyway, applied for good this time, thanks for taking extra time on this! Ludo=E2=80=99.