From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 58156@debbugs.gnu.org
Cc: kiasoc5@disroot.org
Subject: [bug#58156] [PATCH] gnu: Add emacs-circadian.
Date: Thu, 29 Sep 2022 11:48:49 +0200 [thread overview]
Message-ID: <87v8p6bjem.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <95dbafb1ebd166bb70758e94285a966e66d43caa.1664425321.git.kiasoc5@disroot.org> (kiasoc's message of "Thu, 29 Sep 2022 00:22:02 -0400")
Hello,
kiasoc5 via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-circadian): New variable.
Thank you.
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://stable.melpa.org/packages/circadian-"
> + version ".el"))
Tarballs from Stable MELPA are not considered stable (!). Could you use
GitHub as upstream?
> + (sha256
> + (base32
> + "1pypy9bhg4lmmjjj0yqvlqs478i84x3awgzzjzdmrj1jlqbbvdj7"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/guidoschmidt/circadian.el")
> + (synopsis "Theme-switching for Emacs based on daytime")
> + (description "emacs-circadian tries to help reduce eye strain that
Circadian reduces eye strain…
or
Circadian may reduce…
In any case the project is named Circadian, "emacs-circadian" being the
name of the Guix variable bound to the package.
> +may arise from the difference of the display brightness and surrounding
> +light by automatically switching between light and dark themes. It is
> +inspired by color temperature shifting tools and brightness adaption
> +software.")
> + (license license:expat)))
Licensing is ambiguous. The LICENSE file is expat, but the sole ".el"
file is explicitly GPL3+. So I guess this would be (list gpl3+ expat).
Could you also activate tests for this package? See for example
"emacs-go-mode" for an example. You will need to add emacs-el-mock
and emacs-ert-runner to the list of native inputs.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2022-09-29 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 4:22 [bug#58156] [PATCH] gnu: Add emacs-circadian kiasoc5 via Guix-patches via
2022-09-29 9:48 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8p6bjem.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=58156@debbugs.gnu.org \
--cc=kiasoc5@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.