From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YT6IMh0bdmNBuwAAbAwnHQ (envelope-from ) for ; Thu, 17 Nov 2022 12:29:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AGiTMR0bdmMfOAAAauVa8A (envelope-from ) for ; Thu, 17 Nov 2022 12:29:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 91B108898 for ; Thu, 17 Nov 2022 12:29:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovd4v-0002li-Iy; Thu, 17 Nov 2022 06:29:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovd4o-0002jx-01 for guix-patches@gnu.org; Thu, 17 Nov 2022 06:29:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovd4n-0007HZ-Md for guix-patches@gnu.org; Thu, 17 Nov 2022 06:29:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovd4n-0005UI-Ic for guix-patches@gnu.org; Thu, 17 Nov 2022 06:29:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59239] [PATCH] gnu: Add python-synapseclient. Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 17 Nov 2022 11:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59239 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= Cc: 59239@debbugs.gnu.org Received: via spool by 59239-submit@debbugs.gnu.org id=B59239.166868453121075 (code B ref 59239); Thu, 17 Nov 2022 11:29:01 +0000 Received: (at 59239) by debbugs.gnu.org; 17 Nov 2022 11:28:51 +0000 Received: from localhost ([127.0.0.1]:59313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovd4c-0005Tq-IV for submit@debbugs.gnu.org; Thu, 17 Nov 2022 06:28:50 -0500 Received: from sender4-of-o50.zoho.com ([136.143.188.50]:21099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovd4Z-0005Td-VB for 59239@debbugs.gnu.org; Thu, 17 Nov 2022 06:28:50 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1668684525; cv=none; d=zohomail.com; s=zohoarc; b=OCNCkrQTFTm6DxJ9JoiN99MyiNba4MnpGBX1U93h2ygjU11NdbLdMg+EI/VxtU7FPqe12eFcrEU19Yj2zqgk6tDpMKrzg5PXY6M+riwr+QKrhQByZtd4z7PdVpSB7B3v5c1J+QPbc5PvQZXKC7p32iiyMkAYHi1m2qHYsDMYVio= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668684525; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=UnjXGaBclqFlGiLQVNDLghpYli0QcIhckNsBECCYeNY=; b=JonZVy1QY4JzbldbzWDS69vPTmRRIhJJg+uiHkGeaVH4megojPNNtjAjdgw5qliBTZ8Lt2iOWoGYfAK26Q5Wjyvt63ecvbb9IhQeUU/Ay8Whwe+GOHI+Lsi8uKgsVEj2onB1EbVgPvXhzoYArN2DDjUEcRD0VyRlZK6xhqFENTM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1668684525; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=UnjXGaBclqFlGiLQVNDLghpYli0QcIhckNsBECCYeNY=; b=Debxq+xWoCqGGu7VDJ7z5+BZN0IzF7K2mpkQ0QRTivW/8VZIq68S7sGqQlrgY/Au nsd+YPWrFKIVKjTXR1D3PrBlODqeGf1cT7FTUZHT7xO51oL+ak/yYxK/K22wIl97hMr iBuOTFZZavS6eLwFl5XEQrgkcVQZwX4shAvP298g= Received: from localhost (66-108-142-46.pool.kielnet.net [46.142.108.66]) by mx.zohomail.com with SMTPS id 1668684522194433.83292486014204; Thu, 17 Nov 2022 03:28:42 -0800 (PST) References: <20221113054308.5582-1-madalinionel.patrascu@mdc-berlin.de> User-agent: mu4e 1.8.9; emacs 28.1 From: Ricardo Wurmus Date: Thu, 17 Nov 2022 12:24:27 +0100 In-reply-to: <20221113054308.5582-1-madalinionel.patrascu@mdc-berlin.de> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87v8ndu8ew.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668684573; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UnjXGaBclqFlGiLQVNDLghpYli0QcIhckNsBECCYeNY=; b=e/v7oz5+BhiBtkUHKywj9OkChc9ZUJpmLxXUHIEsOfk2vjLMz5fOlAVjrAsPBWgDrYjmi+ E67tnTpaDcjkHOyEwS5EVm7sm/9HznZ7UQjRrplgSfPbX4FRVnb28dVavqIs0CUk33jzBE O6JM+V/s68/bXbiUIlECanHCKD3NDGrDH97yPKsiRhkX0JERBijqzIUpm7pjJOCrW8ZoCa hZlYuRNwv+ghljlTRiKcjVjZ2qW8H+s8O6j3bgQC6zSCX1WV28hvhc/rNjq+LmgtzmghaC fIzG4D4b4xflLtUZWUxPn5M6/ngKqk7WtyP6ToDhK4AcR2uMKv5emdclPlKeAQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1668684573; a=rsa-sha256; cv=fail; b=QqzV3II1eAK+3/yjT5gGGFMum2k0iLM5bpkXqqRtes9y55047hJJXDU2kZ2DixPZm8hgoi PrEQ+xqP9rKbRA6ktG27GzrsPqRXbSZ8ozgPGHsXl9EeQp3+1OPn2URBSuo9Dbt9aQcU6b TDl22ALPSN4NFoecW2AstN0XbWriXl5tK9FSbfiOhktnJ1Y6XvnlsGp1tOAngoq6o4ZVQi /WRJa0XKVE84rR/bI14ToXU46/yAlLmp+oeSOEzQOpu22w0Vjzd326qujUjv5/WNtw3cX7 y1hKIqM9c+8MaVJsprV3ZA0lZOpfpWjvZrQZAtVANT1HlVsa1uAUzTJ3VKxO+A== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=Debxq+xW; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.48 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=Debxq+xW; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 91B108898 X-Spam-Score: 1.48 X-Migadu-Scanner: scn0.migadu.com X-TUID: f9cwtVAt3wQt Hi M=C4=83d=C4=83lin, > * gnu/packages/python-xyz.scm (python-synapseclient): New variable. [=E2=80=A6] > + ;;(method url-fetch) > + ;;(uri (pypi-uri "synapseclient" version)) > + ;;(sha256 > + ;; (base32 > + ;; "1g2n5bbq5vkvprk4ap3sbz2q39cjwl8igy3krlskg34c1q7if7r4"= )))) Please remove this commented code. > + (build-system python-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'relax-version-requirements > + (lambda _ > + (substitute* "setup.py" > + (("keyring>=3D15,<23\\.5") "keyring>=3D15") Is this really a good idea? Upper bounds usually exist for a reason. We currently have version 23.9. Can you please clear this with upstream first? > + (("keyrings\\.alt=3D=3D3\\.1") "keyrings.alt>=3D3.1")))) > + (add-before 'build 'set-homeless-shelter > + (lambda _ > + ;; could not create '/homeless-shelter': Permission denied > + (setenv "HOME" "/tmp"))) We=E2=80=99re setting HOME, not homeless-shelter. > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (when tests? > + ;; these tests require server authentification SynapseNo= CredentialsError > + (delete-file-recursively "tests/integration/synapseclient= ") > + (delete-file-recursively "tests/integration/synapseutils") > + (invoke "pytest"))))))) typo: =E2=80=9Cauthentication=E2=80=9D. What exactly does this error mean?= Does it talk to the internet? How are these tests supposed to be run? Is it possible to disable these tests with an option to pytest? That would seem better than conditionally deleting them. Finally, I think the test files should be deleted unconditionally, so that =E2=80=9Ctests?=E2=80=9D only governs whether the tests are *run* inst= ead of also causing other side effects. --=20 Ricardo