From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KAnyCQrLpGNiwAAAbAwnHQ (envelope-from ) for ; Thu, 22 Dec 2022 22:24:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id Sk/1CArLpGNsfwAAG6o9tA (envelope-from ) for ; Thu, 22 Dec 2022 22:24:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A9EF23F728 for ; Thu, 22 Dec 2022 22:24:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p8T2j-0000yM-0V; Thu, 22 Dec 2022 16:23:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8T2g-0000y4-Ho for guix-devel@gnu.org; Thu, 22 Dec 2022 16:23:54 -0500 Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p8T2f-0001pT-0W for guix-devel@gnu.org; Thu, 22 Dec 2022 16:23:54 -0500 Received: by mail-qt1-x829.google.com with SMTP id a16so2363611qtw.10 for ; Thu, 22 Dec 2022 13:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ey5HBm8MO1JjZ5GmJ5sie41sxtFTG15ootDUOdHeNRk=; b=cYtNU1UJeg7byAnoQs59SdgV2u0r18LxaGquAGZGCbkUpQIz6d+SzDq65EF/TXOJWf tvXZa07SpWKrPxuzAoSx0ubS9GSNoAY8PBTsZsr4c++g+BDv7GNQUnXb6aslKABFw9n+ k15gJnXbYSLoJsIVjNoYNzlmTLqKwZkN+gIoVGc985Nz3AoOkJfh40fKp1HYl54IL5gM rXye43hn5zMDXvs/99BVgvWAXnDRSWoOGzyHwR9BPcQrHC4MMmZ4AIAY9qW/Xzb/ZjCg YsMpjNzcv51p9r1io21VL7HQ/zACj6wGB77sEEVVC+koFDJQfTexguH38a3G7i24fkTX NGbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ey5HBm8MO1JjZ5GmJ5sie41sxtFTG15ootDUOdHeNRk=; b=ZLx4SUXByEB2rol93q8LPIi5QEhVrvOtwAnwlIXBs9CaV5V3o/7EFl5iSxe1KM+y2/ 1Ulhhf+LUF/a6rR1WH6SXU4H2tAI4fv0SO63YXdts5jMM5mGyW3pM0hSL0j5mnI+pAFB ED0b7fbM294iOCzNR1k3W4gqfYoEugoNxmbFqPr/7Wh7LqO0aLOUbwPt/f2AOU/REYbX ZcOmO77BLd02wZIG/XucTLSg+6cMyqjdLJcYI5K48HNvbpeq1cD/dbwl50+GfT+ahfga +16WhF92gZ4xhLVefid6vE77jl9csvBSvyQd1iu5Yj4bbfSZBEN3PI9LH9OKQMbL4uXE cY7Q== X-Gm-Message-State: AFqh2kqf905dE1U3U9ye/K2pwEOaIl1up7OkJfpBdk1NHt12AqX3LM4l DFmoRFMYTN9dzSFiUnj78xKqc09AI04/Xg== X-Google-Smtp-Source: AMrXdXsKh0g9qu7WAnsdNnN0pl+TPxsYezNiHuxu9RuW4wdwba5AofQEQa17fW2gL06GpP8/SeQvgQ== X-Received: by 2002:a05:622a:4006:b0:3a9:818f:db3d with SMTP id cf6-20020a05622a400600b003a9818fdb3dmr9627454qtb.53.1671744231233; Thu, 22 Dec 2022 13:23:51 -0800 (PST) Received: from hurd (dsl-159-186.b2b2c.ca. [66.158.159.186]) by smtp.gmail.com with ESMTPSA id e7-20020ac845c7000000b003a81029654csm936644qto.31.2022.12.22.13.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 13:23:50 -0800 (PST) From: Maxim Cournoyer To: Vagrant Cascadian Cc: guix-devel@gnu.org Subject: Re: u-boot-am335x-boneblack -> u-boot-am335x-evm-boneblack References: <87len0y1kk.fsf@contorta> Date: Thu, 22 Dec 2022 16:23:49 -0500 In-Reply-To: <87len0y1kk.fsf@contorta> (Vagrant Cascadian's message of "Wed, 21 Dec 2022 11:54:51 -0800") Message-ID: <87v8m3w2sa.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::829; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x829.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671744265; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Ey5HBm8MO1JjZ5GmJ5sie41sxtFTG15ootDUOdHeNRk=; b=CmkHoIs2dRZyeDDHsQPecSZ8mO3eKOKDLj6DjpfQUpCcGGRXzPqaDEf6vyvUHrFKegXjMz O/5u6e7OzcGliMn/DPX33p+AeI+WT2LPh+Vhu2bkKsDeRyHQQzbkfmRIv4W4rqNqLJ0gT8 1UE3XfQD7NwT1c45FY4wl0eNVaKnG/mpP2x1TmgKa+URTNgnYnIMThlg3eImqUOvH5J0dB 1cK5Wd4WxY51gC666iK6FFrSbHbH3abbrQN931CHpI30HKB8kLd6ZG2v31wU6NV3At46U5 6UgyPgE1qvYB9fuNw70E7KnJX0anRFugMq/HEsH4SmJkvAvYCIQI4Ts0QxEhiA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cYtNU1UJ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671744265; a=rsa-sha256; cv=none; b=UxrBorKDV77acQhm0QcZGEbk1nHqn+ooJlfkaBOlSjSRSNMsmFfTIz+m7y5erWxs1fATGB 1Qyz/JJuORYV5ue/6rpSeG0c/Jv6JHTS92uyuTCrFPi9oOb+/ZqzkOS4q+yXoyHfzOH1Rr Zj5iIHJo9NuvGTr9Do9HRDLdQHTDoxffFmcYM2h9vQB+qmClWWidFJdVVTu08Uuh+h/jHK WsJjNIHSOrsOxfgEDdHFJxAOuDwXUvyZyxRzAyWTV/Ui/7HpDOkl4pnKbIxQ5IwbwXQEzP X+cz5Xi9MJmLmAKXk76vwLvgbhytYQnznbDT9pjTZx6L7mlzseHWhw8LJPvRbw== X-Spam-Score: -6.05 X-Migadu-Queue-Id: A9EF23F728 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cYtNU1UJ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -6.05 X-TUID: NPdVdn37Qp9u Hi Vagrant, Vagrant Cascadian writes: > Wondering what necessitated this change from the old variable name to a > new name... > > commit c04528d2a2597d79278833f3607c806278253446 > Author: Maxim Cournoyer > Date: Tue Dec 20 21:25:27 2022 -0500 > > gnu: u-boot-am335x-evm-boneblack: Fix variable name. > > * gnu/packages/bootloaders.scm (u-boot-am335x-boneblack): Rename to... > (u-boot-am335x-evm-boneblack), to match the package name. > * gnu/bootloader/u-boot.scm (u-boot-beaglebone-black-bootloader): Adjust > accordingly. > ... > diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm > index bd9f7bb577..c8b8adbc93 100644 > --- a/gnu/packages/bootloaders.scm > +++ b/gnu/packages/bootloaders.scm > @@ -889,7 +889,7 @@ (define*-public (make-u-boot-package board triplet > (define-public u-boot-malta > (make-u-boot-package "malta" "mips64el-linux-gnuabi64")) > > -(define-public u-boot-am335x-boneblack > +(define-public u-boot-am335x-evm-boneblack > (make-u-boot-package > "am335x_evm" "arm-linux-gnueabihf" > ;; Patch out other device trees to build an image small enough to fit > > The u-boot-am335x-boneblack was named to match the original target that > was removed from upstream, adapting the upstream am335x-evm to fit into > a smaller gap in the partition tables... (e.g. 2MB partition offset > instead of 4MB offset required by the default am335x-evm board > configuration). The problem was that the *name* of the package was "u-boot-am335x-evm-boneblack", as computed by the MAKE-U-BOOT-PACKAGE procedure, which includes the board argument in its name (it's been like this since its inception in 862e38d5518, 2017). If the previous variable name should have been its name, the name field would have needed to be overridden to it (or perhaps we could introduce a #:name argument that would take precedence over any cleverness). I noticed of the problem when trying to build the package; "guix build u-boot-am335x-boneblack" would tell me it didn't exist. I considered making a deprecated alias but decided against, because in the past we didn't when moving/renaming packages *variables*. -- Thanks, Maxim