From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4PQZIB7vq2NhOgAAbAwnHQ (envelope-from ) for ; Wed, 28 Dec 2022 08:24:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0EQbIB7vq2NeggEA9RJhRA (envelope-from ) for ; Wed, 28 Dec 2022 08:24:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A3662022F for ; Wed, 28 Dec 2022 08:24:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAQnE-0005BC-Dj; Wed, 28 Dec 2022 02:24:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAQnC-0005B1-VR for guix-patches@gnu.org; Wed, 28 Dec 2022 02:24:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAQnC-0001CW-Np for guix-patches@gnu.org; Wed, 28 Dec 2022 02:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAQnB-0006z7-P7 for guix-patches@gnu.org; Wed, 28 Dec 2022 02:24:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60365] [PATCH 0/4] Rationalize 'PS1' handling in home, system, and shell Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 28 Dec 2022 07:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60365 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 60365@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 60365-submit@debbugs.gnu.org id=B60365.167221219626788 (code B ref 60365); Wed, 28 Dec 2022 07:24:01 +0000 Received: (at 60365) by debbugs.gnu.org; 28 Dec 2022 07:23:16 +0000 Received: from localhost ([127.0.0.1]:57024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAQmR-0006xz-JG for submit@debbugs.gnu.org; Wed, 28 Dec 2022 02:23:15 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAQmP-0006xl-R2 for 60365@debbugs.gnu.org; Wed, 28 Dec 2022 02:23:14 -0500 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id 07477C000B; Wed, 28 Dec 2022 07:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1672212187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+8uEQcbSe/WxIdeseGdnqtzEwby7B3BNiQsCkz9guTM=; b=FQm6+T4iu1rEfTLjRKN/de/+Dm/uTHCCBkmHAb3VB2WCUsMrPdPxxhpvIkS86LS0NAq3/o M6L/3UF2QWaGBxxfOpnw6VV2OxIcj7NOYqNB15E4aOEJ0+IrUJ4gBcSftiFynNfex85vS0 Xv2f9u6dXfAgMbvaOb51obiBQlD+PleVCNHgEybpsabrkKUh9gvD6g0XNI/DKtD5Cv8uLV IghxRiag2Z561reYS2iPGNWEhH8xncGiXFExTb1DMXn6QsFwF+j17f7mPd3UPTJOjguWG5 XqaJ1no8BpcXmABogdw7u6P6h4zb/g8OJhFq7CC2ZfdJQk2b/IEbx3nlWp1s9A== From: Andrew Tropin In-Reply-To: <20221227212342.17939-1-ludo@gnu.org> References: <20221227212342.17939-1-ludo@gnu.org> Date: Wed, 28 Dec 2022 11:23:03 +0400 Message-ID: <87v8lwf0vc.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672212254; a=rsa-sha256; cv=none; b=I4KD35KgJx5amdfBN/GQMTAjA97eQTGUcveuqfPMZieQh7/SF015Ohr0SQ2y1gl3FOZEVE pyTJfF+PzqeSuklM72UOWrcoCrNTBlRxdubuV0p8jmihZ2nyXYXXnA7SAmbdpqsT+wPcca 8eGduybB8CtpaBmEcdZnoyyjtDBGRniaVmOnXWmMnOdT1xbqOOgPhLNLRRBwJbW2Rt/p1E 35raIc4kP2ob9C+K2vTEILwcxjKtS4r2M75KmFa2Ms+0SQ+AE0+pa90ATsfbe16sNF0E45 PMWGAonlvPPguNH4TlubTSdIKymSQP5N1QrH2xIlKj4r8/ZGtlihgg09PttQBw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=gm1 header.b=FQm6+T4i; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672212254; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=+8uEQcbSe/WxIdeseGdnqtzEwby7B3BNiQsCkz9guTM=; b=hldesZ+/J5mFDs05GI1DsK47FOFR/3GG1Tj1OAAO0EsBqXjtAp/GTJDq0+x/cyeVFQu3t4 vV/h71HJN1D+n9l2wX774xhG8uvg28zhXtUCoHXVGUtSw3HCiNUSRyZnn/BfS83qU4a1h0 vs3Ml4AE2+bXMLzOk6gxBPAtDqGMdDXXUsIwFrn1eo3xh37jL9AKGewu1np6/doZTO0blW 7vXqgiSsMtmc8Dsxc5hPF0G5btbb9CiPcVB3CqNs9IYup+XOqeX0MvxZVcXpKHgqi4WGYn zbuEaStDyFCHub0Zd5jyWgJxp2FZIt1AoEt1fJAbrKxbWMtLSySoIYvRZq/rkw== X-Spam-Score: -3.73 X-Migadu-Queue-Id: 4A3662022F Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=gm1 header.b=FQm6+T4i; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.73 X-TUID: W6/HR3Jw7I3T --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-12-27 22:23, Ludovic Court=C3=A8s wrote: > Hello! > Hi Ludovic! > I found some things could be improved in how we deal with =E2=80=98PS1=E2= =80=99 in > Guix Home, Guix System, and =E2=80=98guix shell=E2=80=99 (my initial moti= vation was > making it easy to change =E2=80=98PS1=E2=80=99 from a Home configuration). > > These patches fiddle with =E2=80=98PS1=E2=80=99. The most visible effect= is that > Guix Home=E2=80=99s ~/.bashrc will no longer provide a default =E2=80=98P= S1=E2=80=99. > > Thoughts? Factorization of bashrc is great! Not sure about moving PS1 to /etc/bashrc as it won't work on foreign distros and guix environment won't be noticable in the prompt. Warning is useful, but I would expect prompt work OOB, when guix-defualts? is #t. The possible alternative solution is to factorize bash_profile and put PS1 here, so both skeleton and home provided bashrc have it, after that setting PS1 with environment-variables field will start working. > > Ludo=E2=80=99. > > Ludovic Court=C3=A8s (4): > system, home: Factorize default '.bashrc'. > system: Define default 'PS1' in /etc/bashrc rather than ~/.bashrc. > environment: Simplify 'PS1' suggestion on '--check'. > environment: Avoid false positive on 'PS1' check. > > gnu/home/services/shells.scm | 41 +++--------------------------------- > gnu/system.scm | 3 +++ > gnu/system/shadow.scm | 33 +++++++++++++---------------- > guix/scripts/environment.scm | 12 ++++++----- > 4 files changed, 28 insertions(+), 61 deletions(-) > > > base-commit: 9369c1ccf47d9bf6f2e28a9454c1c329a2044f19 > prerequisite-patch-id: aae3af39aa7753dd7ed6d0584587a06d51402386 =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmOr7tcACgkQIgjSCVjB 3rC3DQ/9EbUwBi+Co39BP1nnHczQ/Fj+BxVXAQP/PMRqS/LIBFShTMB+GpHhQpEK gKeUWFt31sWD2vO1Go9Rp7yMm3rZTtzxP8C7Xm/Yzk+UQ5qfHKjIcu7L/pBkAQX8 Que+jKJBCzqo1m2vKf/ojx6vEvCqId5rYe3jpzfuecIhdUOE3PCnWdzYGxK/XqCe Ap7Jk/JRTpNAisbaDZ47KgspbbxWtXbbxpgmZvCY9GF78bSQCJKoLVlkKQCx/ldl qsF+UpOiKxexcY+KDaGkaH+EX3Czby/wfKgF89fhLkDsBcfWc8HV8i3bq04Jd3Uc 3T+bfY3h2oX8VRsTFByey7ED2yyWkpfpQW8aqw8wpYvf3L2rYlN3NqPKWpw0iB/E RcBFpwBaBecxVIpytjGyKWyHZvaJ9nuqiW02/McZPCbdKfvkjhiyhfAo8fjGSPHG CHpUu/FnGaO5qqvQEx+7a0h5Muo4hrcXztqKwErOq1JrB73kpDnJXNFAkoOxZej+ WWCVLa+BfHYcPXUC3gpQf1zXHhp8UA/OvEBMsh+RED8/iXXnVYIamp1yDu61hbs/ FDYSdoXYfkWaTeT3/NkP4EsyDvJ9F0TI95THD29889wanDAytk1IIntQXmMy1vVW h3/0kqhIX3tg8f/yXdYqPUAxx6UMXsztPl1t1QfziuFHq/qPQa4= =kSH8 -----END PGP SIGNATURE----- --=-=-=--