From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id aM1hJ6RbLGS0iwAASxT56A (envelope-from ) for ; Tue, 04 Apr 2023 19:17:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kD5VJ6RbLGTyRwEA9RJhRA (envelope-from ) for ; Tue, 04 Apr 2023 19:17:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BE5073D6B4 for ; Tue, 4 Apr 2023 19:17:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjkHM-0006Ns-Ay; Tue, 04 Apr 2023 13:17:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjkHI-0006Ni-6o for guix-patches@gnu.org; Tue, 04 Apr 2023 13:17:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjkHG-000259-Pd for guix-patches@gnu.org; Tue, 04 Apr 2023 13:17:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pjkHG-0007c5-4i for guix-patches@gnu.org; Tue, 04 Apr 2023 13:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43442] Subversion keyword substitution Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 04 Apr 2023 17:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43442 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43442@debbugs.gnu.org, zimoun Received: via spool by 43442-submit@debbugs.gnu.org id=B43442.168062861529249 (code B ref 43442); Tue, 04 Apr 2023 17:17:02 +0000 Received: (at 43442) by debbugs.gnu.org; 4 Apr 2023 17:16:55 +0000 Received: from localhost ([127.0.0.1]:50063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjkH9-0007bg-4e for submit@debbugs.gnu.org; Tue, 04 Apr 2023 13:16:55 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjkH6-0007bO-8p for 43442@debbugs.gnu.org; Tue, 04 Apr 2023 13:16:53 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7C7215C0048; Tue, 4 Apr 2023 13:16:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 04 Apr 2023 13:16:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680628606; x=1680715006; bh=dNzICEQ3slAztOw1VULCSq+UDPQ9cUKy7lF CqmIGMkM=; b=e6GbhsHN8pQtK/PdY/lu2WDxNnRQBzrQ+BkphmqIEXKU5utdYzq +sneW8AY6mvwWMO4SuHAC59W4f6kzJJvJ+XbUtHumIVK3fBXPnU3kSoATBm3GbN+ 1FejdDK6lnDqQsaW0gh5naRg6hGV/mVgkN0he1R4gPdUkzsr9NikCnfODDcluOIT h+IfkXMrtSjwzJfL10LOWMThOnqdkQdLaCDFp1OBcocrEQiy1Bi1bHzGCHnKG1DG Q3k6gIe8R4ckkdHsSuswlw+/8exyP1x/TxuSpUfmDQ/l+mcglyL2UR97zz8ZTKez oARQCaQ3FRAPPkXEbR0NyFE7KHW2qAFnA7A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeiledgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfhi mhhothhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheqnecugg ftrfgrthhtvghrnheptdekvefgkeevgeffhedtgfevtedvudekfeffhedvveetgedtvedu iefgfedttedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhplhgvthesnhhghihrohdrtghomh X-ME-Proxy: Feedback-ID: i4721425c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Apr 2023 13:16:45 -0400 (EDT) From: Timothy Sample References: <20200916081411.5801-1-zimon.toutoune@gmail.com> <20200916081642.6716-1-zimon.toutoune@gmail.com> <87o8lyj090.fsf@gnu.org> <86zh5iol1n.fsf@gmail.com> <87h7rocvkt.fsf@gnu.org> <877dsi44lu.fsf@gnu.org> <87y2knhei3.fsf@gnu.org> <87jzzbms54.fsf_-_@gnu.org> <87jzz8xva8.fsf@ngyro.com> <871qle6p4x.fsf_-_@inria.fr> <87v8ipwwt4.fsf@ngyro.com> <87v8imimyw.fsf@inria.fr> Date: Tue, 04 Apr 2023 11:16:43 -0600 In-Reply-To: <87v8imimyw.fsf@inria.fr> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 27 Mar 2023 11:04:55 +0200") Message-ID: <87v8iby3d0.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680628644; a=rsa-sha256; cv=none; b=IA5FlvSldV3pPwcGM9FUSh1NHLuXmvUzktuQSkf2Me/MUnyMIAx7/l6eOHTDQENiz7M78n n8c7mi0KcRovfi6z50NbuCO8wZkl98LnfFq+PjoULO13poAgZnjQ1/adTP9oRN2nbiraC5 hvHBES1kl2cFlSh9C690S1ZuaglY0AbFx8CXemVEcws2z34tZMW5fdesU8z3JbDut3Da2x ewMaglKQ+/fvp2bz3QKIfJWMafWA1+VUAjtoKL2pWWffS9WWZnRqLfz7DNBDyW82LJjhBY yeIOLEOAhKN+DZUxElpVajyEa+vJVjPhZx81kI7qP0v1+5UEFIWzdnN449rXmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=e6GbhsHN; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680628644; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dNzICEQ3slAztOw1VULCSq+UDPQ9cUKy7lFCqmIGMkM=; b=I1LyudoOYN8smtBK7oUB6RwychZVeVAJQBrK4KaPdskh9Ry9zo5jniVPspmuFQFdVbeohg nSku94J/L91+VZqvYy9lPN/Vk0ABjEeuD5qbROgFqHiDXwtqpoTyKeHWGU2faUSElfs4VO C+/un3bE6RLV7nCqeXpaEMQtGs0U9ikOG4hG6/6YssDk3YbR97IwJeH5oOL0fTRmwAJkGT ub0bGWvxuFxn2Z4fnAodKrCtpN6CEbf47OrJo8w1J8biQM+r88Bs+uov87v+q8n0hJDwap ZiOw4gGkqdTde20Zkjzu/00rNczBIKhBKtJVDzopaYHk3GrsY8r1MVWE0tFDbA== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=e6GbhsHN; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.02 X-Spam-Score: -2.02 X-Migadu-Queue-Id: BE5073D6B4 X-TUID: SchmYvxQTz+M Hi! Ludovic Court=C3=A8s writes: > OK. I=E2=80=99ll submit a patch to that effect, unless you beat me at it= . :-) I=E2=80=99m on it! It might take me another day or two to actually submit = the patch. The keyword expansion change affects =E2=80=98texlive-bin=E2=80=99,= which means a lot of rebuilds, so I guess we will need to coordinate a feature branch or whatever (my understanding is that core-updates is essentially frozen and deprecated at this point). > Timothy Sample skribis: > >> Thinking entirely abstractly, the keywords should be expanded. I=E2=80= =99m not >> really long enough in the tooth (old enough) to know how people use >> keywords, but one might be tempted to do something like: >> >> printf ("This is foo version %s\n", "$Revision$"); >> >> If that ever happens, processing the keywords would be very important. > > =E2=80=9CVery=E2=80=9D might be an overstatement. :-) > > In practice, these were typically used in source file headers, so that > if you exported or copied files around (outside version control), they=E2= =80=99d > have a timestamp of sorts at the top. I ended up finding 17 origins that make use of keyword expansion. Two of them indeed do so outside of comments. (1) The =E2=80=9Ctexlive-scripts= =E2=80=9D source has some Perl scripts that do the Perl equivalent of my example above. (2) There=E2=80=99s some Java code (=E2=80=9Cgeronimo=E2=80=9D) tha= t uses keywords in Javadoc comments, which might show up in generated documentation. So no, definitely not =E2=80=9Cvery=E2=80=9D important! :) >> Huh. My scripts tell me that we haven=E2=80=99t needed it at all in the= last >> three years. That=E2=80=99s a suspicious enough result that I wonder if= there=E2=80=99s >> a bug in my scripts. The results are looking good so far, but there are >> a few things I still need to look over. > > Looks like it might be easily addressed! I=E2=80=99ll switch the =E2=80=98recursive?=E2=80=99 field to =E2=80=98#f= =E2=80=99 by default as part of the series I send in. -- Tim