From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2BrEKs2biWQ9ewEASxT56A (envelope-from ) for ; Wed, 14 Jun 2023 12:51:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mN8hKs2biWQkEwEAauVa8A (envelope-from ) for ; Wed, 14 Jun 2023 12:51:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6B5293B917 for ; Wed, 14 Jun 2023 12:51:57 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9Nu3-0000rK-0D; Wed, 14 Jun 2023 06:39:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Nu2-0000rC-Br for guix-patches@gnu.org; Wed, 14 Jun 2023 06:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9Nu2-0005aZ-3H for guix-patches@gnu.org; Wed, 14 Jun 2023 06:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9Nu1-0005Wl-V4 for guix-patches@gnu.org; Wed, 14 Jun 2023 06:39:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63926] [PATCH] services: postgresql: Add more role fields. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Jun 2023 10:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63926 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Miguel =?UTF-8?Q?=C3=81ngel?= Moreno Cc: Christopher Baines , 63926@debbugs.gnu.org Received: via spool by 63926-submit@debbugs.gnu.org id=B63926.168673912921223 (code B ref 63926); Wed, 14 Jun 2023 10:39:01 +0000 Received: (at 63926) by debbugs.gnu.org; 14 Jun 2023 10:38:49 +0000 Received: from localhost ([127.0.0.1]:43811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Nto-0005WE-T0 for submit@debbugs.gnu.org; Wed, 14 Jun 2023 06:38:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Ntm-0005W2-NC for 63926@debbugs.gnu.org; Wed, 14 Jun 2023 06:38:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Ntf-0005XS-Go; Wed, 14 Jun 2023 06:38:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=b6utA5TiVy2gyTr619GJ2ldZclNBxq9p/L3OQq4NH9M=; b=gY0k/O7A18Vxh4mT+fxt qUjsCGyXDrrJCROoUzbg+0KrPbsqKYCPYQfqXZFZ1Bipa65TqsMhw5I7fJf3InHkLHuDNLh5rcvSd YQ9RjnzdymROJuclueHyVci7F/GklCb/GkWJL78n2KRfst/awf8CwGW15TINv3siKR4iw8pwhu5Ci Uy8tZlmQ8itJVQfklvnm/+kbTb5ywQTHPiypvc8BDthWvufPsKzKYdAQjq6sgz5rKQ0ehglkt4Uir p47YCP2hzurw9NNikCGWiYHz5xeV+8nL2gbS/2Hj9jCRMm/dU0npx8NpoALmqp8BuuTSMSOLEwrMi jhsfaVrQOY5jpQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Ntf-0005C1-3y; Wed, 14 Jun 2023 06:38:39 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <86legxos70.fsf@mianmoreno.com> Date: Wed, 14 Jun 2023 12:38:36 +0200 In-Reply-To: <86legxos70.fsf@mianmoreno.com> ("Miguel =?UTF-8?Q?=C3=81ngel?= Moreno"'s message of "Tue, 06 Jun 2023 11:28:35 +0200") Message-ID: <87v8fqs503.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686739917; a=rsa-sha256; cv=none; b=ruOIxO5/ffCOetiXn7ljfamFDlr3930mTZBhWZzn9/y2lHSJnFqcGOUpPoukhDL/ND1GGo JWx5A4y3CSh5JpylKgMWFOSzpwbAx5McKh4VZm3BxxDr0Ga04Nkh4w7RL11hHUnRdvCUX3 tpzGhCvnxy21/zdeWpbj4uWFdFCEu7vboQkw8uBXR7NMWtU5S+bxVfu5pEiPU+WC3F8xY3 frHWobzWc/SzmrUZu4AgWDFOGpW2y7xdpkShyY+HqMc1Wl8vX3KrU6FEZpTKoEUNXr2LSc hGKStabcDx7alzyCojlyv6RlmfGYbqA08kf5j6BNhqpHNGLGJrAnmhL+tEPjfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="gY0k/O7A"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686739917; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=b6utA5TiVy2gyTr619GJ2ldZclNBxq9p/L3OQq4NH9M=; b=J5I89f4DIQusC6A4gb64E1prwD/7yQIcuKzUo8MlDL4uO8fVUBK/GUNnr+ft8IAIDBrZnZ cAsClFODIgot4IygMXzpfv5oo9pnk4BfmnF6Xf6dA86UeR/tRDAxwOfyMXb4nb6lrTfMJX 3f644MPimJpVrNPSF/zC6FcdK55clbCzcJQE51HvlrYKLLdEoa6BrGRsPr1kTENvPJduqf W2eH7qXIYt2vvsXFuVmZQbYWmN53InkJVhJRwn4cvNUeRgz/BHNupM1jIXXMsB/P3ulaQc Y0PYnknmloDz2UmxmXaT1WtYuzfEm807Lel3VJDB+fJdR4FRSC4SuOY0s6Kj/A== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="gY0k/O7A"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.73 X-Spam-Score: -3.73 X-Migadu-Queue-Id: 6B5293B917 X-TUID: VQNN01lMBSU9 Hi, (Cc: Christopher Baines who knows pgsql better than I do.) Miguel =C3=81ngel Moreno skribis: > * gnu/services/databases.scm (postgresql-role): Add more role fields. > (postgresql-create-roles): Honor it. > * doc/guix.texi (Database Services): Document it. That looks like an improvement! Some comments: > @item @code{create-database?} (default: @code{#f}) > -Whether to create a database with the same name as the role. > +whether to create a database with the same name as the role. This change is unnecessary (leftover?). > +@item @code{encoding} (default: @code{"UTF8"}) > +The character set to use for storing text in the database. Or "UTF-8"? It might be worth mentioning the naming convention for encodings, especially if it differs from . > +@item @code{collation} (default: @code{"en_US.utf8"}) > +The string sort order locale setting. > + > +@item @code{ctype} (default: @code{"en_US.utf8"}) > +The character classification locale setting. > + > +@item @code{template} (default: @code{"template1"}) > +The default template to copy the new database from when creating it. > +Use @code{"template0"} for a pristine database with no system-local > +modifications. Are these defaults equivalent to those that were previously in effect? If would be ideal. Thanks, and apologies for the delay! Ludo=E2=80=99.