From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AOewOgG4z2To+wAASxT56A (envelope-from ) for ; Sun, 06 Aug 2023 17:10:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6JBCOgG4z2S74wAAauVa8A (envelope-from ) for ; Sun, 06 Aug 2023 17:10:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 84DF14E2D8 for ; Sun, 6 Aug 2023 17:10:57 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=G3RFEa7d; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691334657; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=eemZYJW4Lld03wn93N0oe4vULNwRtmIxoJr3l2vijdI=; b=dN6FmH9IJd95go6TbMStbNMhwLi9palxKf3yIEqo2Dp0AfaIhKfpcHJfoaBVzNzJJC6TSi YCTApRBsSHwtEcNvj6P2A6NQOJo8u/3bROwAIPLfe+Tp9f2oY46SWTjQwJS3IQ2MwkEPeh jDBmF1dQiZojIWPrY4aCpqwc7VkHlzlFaLtVxw4j/eiHAGcyBMMBRpTSEkQYCwzt8fOsRH iCTvd9v33Y1sscXbrA9vc6rEiJyoUMg9wetP6X7Y+fUuJxunTo4E3b5LF5zOCpDdyRaJ5w 4GfThfbgb7fhWppvMl/xhwA9rrIJRrb+GbbmaMnAJd7MgCwuClGWpfRiGrrb1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=G3RFEa7d; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691334657; a=rsa-sha256; cv=none; b=T8LhehPnIZO+YBwZLt1KdfoxzjrYII2I78FQMp3ihdZ+9fPebh3k2UGxixaZ+tQJv8tg/x JSlgtRt0phIEI3brNGqnI16n46BEVbtn6QILhFGuUzIWUikkwoeJYyP+BeHedn+AsluiQY 1QyVzk5ltbVQay4l7V/wt+kqsjnRcH7v25j236iZ6s8w4Ahyr1IeXvWAijZcbkc/tUJoAl r6BJ1sDNI0fwmFRlDwRPIG1vmSox79H8axr/q7FgVeUc63DYEejXbYTO5EfDcL0fzkV+Mj 1S4nmiOxjN85N75DpTNwuEPNmG384+Y+iBqgiD/GCJEL/r1rVe/kvCiUd+wfAA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSf6y-0002Yx-41; Sun, 06 Aug 2023 10:52:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSf6x-0002Yp-4x for guix-patches@gnu.org; Sun, 06 Aug 2023 10:52:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSf6w-0005J2-TT for guix-patches@gnu.org; Sun, 06 Aug 2023 10:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSf6w-0001cw-An for guix-patches@gnu.org; Sun, 06 Aug 2023 10:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65107] [PATCH] gnu: Add gf. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Aug 2023 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65107 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: dan Cc: 65107@debbugs.gnu.org Received: via spool by 65107-submit@debbugs.gnu.org id=B65107.16913335126239 (code B ref 65107); Sun, 06 Aug 2023 14:52:02 +0000 Received: (at 65107) by debbugs.gnu.org; 6 Aug 2023 14:51:52 +0000 Received: from localhost ([127.0.0.1]:59783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSf6m-0001cY-D7 for submit@debbugs.gnu.org; Sun, 06 Aug 2023 10:51:52 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:33322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSf6h-0001cL-UL for 65107@debbugs.gnu.org; Sun, 06 Aug 2023 10:51:51 -0400 Date: Sun, 06 Aug 2023 22:51:30 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1691333496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eemZYJW4Lld03wn93N0oe4vULNwRtmIxoJr3l2vijdI=; b=G3RFEa7dU2oIxcDqR6KKY0rN4uh9dSa8NXMZTCucomuUsQOKNN5jUJLZKYOS6pZwTPcNDh Q7p23BjHli90/x635nZGtnu4Sr+oHArGlMieOSwHK7cI1t1wsatlHRzklITxdWduZ0HebX HzbqtMp6ZUtvSnqww/R9x1IaGWxXOA2dMNwb+CB0XO306yjNq8Tgz84RyXfAE3q4m3okyC 7aohPMijkYSebLCrAWvsNxzIMrFzZhrut7VIPNCHE/s+eO40eZwqidJnGZe6ZFDrSijefU zMF0hgZXwmQ73dQnAfaHgWJmXoFtRNkX0CGuIGqmvJC5G7HL2Ar4A7ZKre+zbA== Message-ID: <87v8ds4425.wl-hako@ultrarare.space> In-Reply-To: <20230806055213.29704-1-i@dan.games> References: <20230806055213.29704-1-i@dan.games> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 84DF14E2D8 X-Migadu-Scanner: mx1.migadu.com X-Spam-Score: -6.66 X-Migadu-Spam-Score: -6.66 X-TUID: 7CDk+mo7xgEy Hi dan, On Sun, 06 Aug 2023 13:52:12 +0800, dan wrote: > > --- > gnu/packages/debug.scm | 56 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/gnu/packages/debug.scm b/gnu/packages/debug.scm > index e2a29a3ae9..104ecc3091 100644 > --- a/gnu/packages/debug.scm > +++ b/gnu/packages/debug.scm [...] > + (build-system gnu-build-system) > + (arguments > + (list #:tests? #f ; no test > + #:phases #~(modify-phases %standard-phases > + (delete 'configure) > + (replace 'build > + (lambda* _ > + (invoke "g++" > + "gf2.cpp" > + "-o" > + "gf2" > + "-g" > + "-O2" > + "-lX11" > + "-lfreetype" > + "-pthread" > + (string-append "-I" > + #$freetype > + "/include/freetype2") I think #$freetype can be changed to #$(this-package-input "freetype") > + "-DUI_FREETYPE" > + "-DUI_NO_COLOR_PICKER" > + "-DUI_SSE2" > + "-Wall" > + "-Wextra" > + "-Wno-unused-parameter" > + "-Wno-unused-result" > + "-Wno-missing-field-initializers" > + "-Wno-format-truncation"))) Can you move these flags to #:make-flags? For example: --8<---------------cut here---------------start------------->8--- (arguments (list [...] #:make-flags #~(list "-g" "-O2" [...]) #:phases #~(modify-phases %standard-phases (replace 'build (lambda* (#:key make-flags #:allow-other-keys) (apply invoke `(#$(cxx-for-target) "gf2.cpp" "-o" "gf2" ,@make-flags))))))) --8<---------------cut here---------------end--------------->8--- > + (replace 'install > + (lambda* _ > + (install-file "gf2" > + (string-append #$output "/bin"))))))) > + (inputs (list libx11 libxext libxcursor freetype)) > + (propagated-inputs (list gdb)) There're「"gdb"」occurrences in the source, can adding gdb to inputs and substituting them avoid the propagation? --8<---------------cut here---------------start------------->8--- (substitute* "gf2.cpp" (("\"gdb\"") (format #f "\"~a\"" (search-input-file inputs "/bin/gdb")))) --8<---------------cut here---------------end--------------->8--- (A keyword argument inputs should be added to the relevant procedure) And the program seems to depend on Vim as well. > + (home-page "https://github.com/nakst/gf") > + (synopsis "GDB frontend") > + (description "A graphical GDB frontend for Linux.") > + (license license:expat)))) > > base-commit: c4b9f726e3a1889b92a4b14a2af1c25f10798469 > -- > 2.41.0 I have built the package locally, running it with xvfb-run reports "vim: command not found". XWayland is disabled in my setup so I haven't checked whether the program works. Thanks