From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id cAWFFMNd6mSR+gAA9RJhRA:P1 (envelope-from ) for ; Sat, 26 Aug 2023 22:17:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cAWFFMNd6mSR+gAA9RJhRA (envelope-from ) for ; Sat, 26 Aug 2023 22:17:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0001C607BE for ; Sat, 26 Aug 2023 22:17:06 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=i4FfPu9q; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693081027; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DMsa9oPWJ9tdmz1lysNmJsOD+CI7GdQN+lz/LIKZSZw=; b=bfi3D4q2aUSdwxJm/ib+vNFP6idtmgVk4SGnkgQdO68iHZtWUIr1nq2Mgrtzk/rux8Dhk3 cZXx2leY3Wn1sjR637BZGaKb0lu4qNuI73iSDbztPKkr96Qw5NVPP59uVPkobuLfLOFuVX Y7TXkipvPPMEFJzMVqtKylly2xgNVKYXun/sY/2BoeafeUZTiLk6d1t+YxAVDHVB7gKqqW K3H2EE7F5E55fCYTOxdg1weGawRQoMMQdJxOFNW2BdaCap/EmLWTvSjqDphHyzQuhTxkOd 0jssu/Rnso8DrFnS+PCba2uCsf+awUrViI0gJ8eLWx0A4uC0g5d9x6CD7/CfXQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693081027; a=rsa-sha256; cv=none; b=rTnrky0Bk8su4h2pi9/4Qe0/lwHIpNFPBA7e4k963zZ6v2zcKnXnlWFTtHC9e08gi2ln3b MPNzHB99Mnoi7Wt8VK4if/eEsaqXZ+5DsburSkJ1cbqdyUUwhs2TaHLA9E8M1+cOaz+u0I ZEqrfkJLp0lO2DZzwWz7SrOa3fNeLrykUoNzZBXr9tjHfdAmFU658AfyCGU1/9dp9aFYZG gWGt2oEUFLWTFtNs4FtpqOC+urYIaeu/gmGU5jNPEkAJL7+2tcxuun0wlkjlKj8bJMgM7e STffHfIW+DkpymWzXAvF91jwjKO21e4mgGn5qdfxFPLdNgV+EhXTowiixR7vUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=i4FfPu9q; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZziN-0005Ux-KJ; Sat, 26 Aug 2023 16:16:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZziL-0005UZ-Fi for bug-guix@gnu.org; Sat, 26 Aug 2023 16:16:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZziL-0007kV-7h for bug-guix@gnu.org; Sat, 26 Aug 2023 16:16:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZziQ-0001JV-BH for bug-guix@gnu.org; Sat, 26 Aug 2023 16:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#64317: [Cuirass] Download products can disappear, leading to HTTP 500 Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 26 Aug 2023 20:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64317 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 64317-done@debbugs.gnu.org Cc: ludo@gnu.org, ludovic.courtes@inria.fr Received: via spool by 64317-done@debbugs.gnu.org id=D64317.16930809624949 (code D ref 64317); Sat, 26 Aug 2023 20:17:02 +0000 Received: (at 64317-done) by debbugs.gnu.org; 26 Aug 2023 20:16:02 +0000 Received: from localhost ([127.0.0.1]:43498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZzhR-0001He-Hx for submit@debbugs.gnu.org; Sat, 26 Aug 2023 16:16:01 -0400 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]:49403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZzhO-0001HN-BC for 64317-done@debbugs.gnu.org; Sat, 26 Aug 2023 16:16:00 -0400 Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-412137ae07aso8026511cf.2 for <64317-done@debbugs.gnu.org>; Sat, 26 Aug 2023 13:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693080947; x=1693685747; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=DMsa9oPWJ9tdmz1lysNmJsOD+CI7GdQN+lz/LIKZSZw=; b=i4FfPu9qM7pn2o6pNBF2PjI13JqfDdmoZOSTIm5+eXbGNcv8hBDJLEAZi1zs49JsmJ iF+Da4NOWWe4czODqL7W/KJ0AWwb08G/EiQc5uaOt/mbUXER5hSO6q5OGbmFcGWWyC1k gMGUndkCQdHPcYunQbFe7sA1of3X3JC7IMV5vtkiT80+lREQuLhe1npx9XH79rH5mgZn QeacxljTiSZ+r42Nn1fSumOp73viF868YJ/b5L7Bdoffsur9g+w60ZiXxxlq1K5d/vUb 1LqyE3X+3kmHttAGwYgXZgXrg7fkx74/rV5a1VsnDNCoDSL84ABbdbti1YXM/+cRV95z uiIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693080947; x=1693685747; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DMsa9oPWJ9tdmz1lysNmJsOD+CI7GdQN+lz/LIKZSZw=; b=IaSAlvUKtRFyF7QL2mN5WRp5UZsj6+dIlVtAGzhx2OMGEYSjJrFw08AZQAt9b/pVsk NNW5DjP8t7xUpKEbPSE7rfHpcT+vyTxagdLRgMiBAwA+mN5/4FpQOpVaUfmxt0e4WVhx hvKYUA/tLV6pynGsvLa2+h0WPMUNmFyxvge9OgjWvIpIL/XtTg0vsR8peGpFpcUz5T5b /unfOmPwJ/lPwx6Swe0DWmgy+4Lovfo7PBO1Mt16KNAmQzzYI8rH1iAsCZ44jtk/VtQ/ SNIlXDx5xaBoK0krnhSkbsnLafsENeFUQugcDA5umczM3+cT/89aiBt6vE89cBmGS1Mo nfHQ== X-Gm-Message-State: AOJu0Yzb0IbP1GeecED74npXgvwganHDIjPcom0QkJYbbW890I1x0H8w PLJ/B8yxNWPQooMsWKfDGg4mDU03n7Y= X-Google-Smtp-Source: AGHT+IHlwmoRV01kT9FAjjlvh1EOo8ZSH9JCtXx0Pq1DOwXLZ17gHyvacEdV+TWz9XSyDooYGht27Q== X-Received: by 2002:ac8:5fc2:0:b0:410:90c7:518d with SMTP id k2-20020ac85fc2000000b0041090c7518dmr22881057qta.11.1693080947176; Sat, 26 Aug 2023 13:15:47 -0700 (PDT) Received: from hurd (dsl-155-106.b2b2c.ca. [66.158.155.106]) by smtp.gmail.com with ESMTPSA id ic7-20020a05622a68c700b00401f7f23ab6sm1291321qtb.85.2023.08.26.13.15.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Aug 2023 13:15:46 -0700 (PDT) From: Maxim Cournoyer References: <87bkh1uhdf.fsf@inria.fr> <875y54xy6t.fsf@gnu.org> Date: Sat, 26 Aug 2023 16:15:45 -0400 In-Reply-To: <875y54xy6t.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 24 Aug 2023 17:22:18 +0200") Message-ID: <87v8d1mufi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.12 X-Spam-Score: -5.12 X-Migadu-Queue-Id: 0001C607BE X-Migadu-Scanner: mx1.migadu.com X-TUID: t1UJgX1mrJ4S Hello, Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> The /download endpoint refers directly to store items. However, they >> can be GC=E2=80=99d in the meantime, in which case the HTTP handler fails >> gracelessly (HTTP 500 or so) as shown here: >> >> 2023-06-27 16:02:24 GET /download/718 >> 2023-06-27 16:02:24 Uncaught exception in task: >> 2023-06-27 16:02:24 In fibers.scm: >> 2023-06-27 16:02:24 172:8 1 (_) >> 2023-06-27 16:02:24 In ice-9/boot-9.scm: >> 2023-06-27 16:02:24 1685:16 0 (raise-exception _ #:continuable? _) >> 2023-06-27 16:02:24 ice-9/boot-9.scm:1685:16: In procedure raise-excepti= on: >> 2023-06-27 16:02:24 In procedure open-file: No such file or >> directory: >> "/gnu/store/bnsh1yk4l913af8swqi3x7xp1xsa8gq7-guix-binary.tar.xz" >> >> The solution IMO is to (1) register GC roots for these, (2) periodically >> remove old GC roots, and (3) return 404 when the file has vanished. > > Fixed with these Cuirass commits: > > 9e897d8 'create-build-outputs' registers a GC root on build products. > 103a6ec http: Gracefully handle missing files in "/download". > 5e3e49c http: "/download" returns 404 rather than 500 for "not found". Yay! Thanks for fixing this long standing issue! --=20 Thanks, Maxim