From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sLRoADn4+WQdKAEA9RJhRA:P1 (envelope-from ) for ; Thu, 07 Sep 2023 18:20:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sLRoADn4+WQdKAEA9RJhRA (envelope-from ) for ; Thu, 07 Sep 2023 18:20:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BA0F132EA1 for ; Thu, 7 Sep 2023 18:20:08 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=SKOqBfYN; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694103608; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lhBSuzJPgX78mmykQ5qfMKDinPN8OqG7PO6gZ8o54hY=; b=DYtOmu5/ZUull0QAfwJ+B+TmP8/DH4hBPMo+HgSStmx7J0ScHhCrSvNwjRBhnGeKaibmvo 1JNZiifpqnnm5Z2PlC0JniKtvG+6LjeDMaVCC03GT69NaNHhjgfwtolqkZ2Tlb0DP5Plql bQzTnh/oirYRW5scg6EOiKNrC1P2u6+adTDWTdZoyeXhbueM2ngwNPBbrEBUNd2lszZ6lK JlQAz4pH1ZI2hJL2msXJoZOxFbNjEXeTGFhmpR6ho4s0S5LfQg63nWd9t0ZcFl8qPUtJGB 5pRXfuRUOgbTN69MoThGc7B4qc45GwYxmcMPrTqU3lkc8dfLNd/bbDro/5j5eA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694103608; a=rsa-sha256; cv=none; b=LFp3d1m0UPMvhNAx9cBI1tMjMNY50mPiqjB+T/hzR6kA75JwwAFQfVcr0Ac5x+RD6T9Sqi 8pZ3ADqS6/LGzdQCfBxeCLelE8f093tPPtFqhfir3pUVq/WAQznP7SaG2wn6uppQbfagEe JE0S0OcfSiYycnWTk+aDfmEtIYNqgnm99QYHDeAuwM4svoDb4btWYK7+N/H7fAKVtdPkFf 9ahk2lRZXCbLZ+Gcn0Dy3x+Mhx56haTdjOll+ms6wYJT6Zq0cFl95i+SWvIXqOhuKvyxhU grtNVZ2QdrXAxc/Uh9Gvs1ooZrT50leIy/NE9bonKaWiiJ3S8npf3/GKD+JKFA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=SKOqBfYN; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeHjE-0000x3-KK; Thu, 07 Sep 2023 12:19:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeHjB-0000wi-U6 for guix-devel@gnu.org; Thu, 07 Sep 2023 12:19:33 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeHj9-00009d-8e for guix-devel@gnu.org; Thu, 07 Sep 2023 12:19:33 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 3563F1AD30; Thu, 7 Sep 2023 09:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1694103566; bh=VNq5tyK7HocIF/071xS07ZXx8UBpTC1QcTpmaIv7m10=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SKOqBfYNIUl8dBWUb4KaOeNfXVi/m4CD6qH5bI199vQ3LkTPVvZX7MoJLnXGGRA+0 auDyUvJwtwkryPSb8IH7xoTqkziO1NSQSq8HxjpNU4UVc56/JDPZDtI8J4ij4XcNU6 MQriYSYWadQ4ZRYyu8tjdQvY61SqAMrATxL6/GXVTeY2UZ+M148pDko4qZSMP0qiB3 gH/v9lpXJNH0Cf9iZZPla/85kJhsOeYl5Wc06KS81FnoENiGwoR860/AGAMR+7bzzf ECVP0Sflm61B+DWzaAU9Q+5CIJwAkh0g7FO1jne2hGhdwSn9FjV0vtaz3wm2m1gvNv jvcKb/EZNhtVA== From: Vagrant Cascadian To: Maxim Cournoyer , Simon Tournier Cc: Christopher Baines , guix-devel@gnu.org Subject: Re: Process for reviewing patches as someone without commit access In-Reply-To: <87jzt2og1z.fsf@gmail.com> References: <87o7ifb66o.fsf@cbaines.net> <86sf7qn996.fsf@gmail.com> <87jzt2og1z.fsf@gmail.com> Date: Thu, 07 Sep 2023 09:19:22 -0700 Message-ID: <87v8cmklbp.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -11.42 X-Migadu-Queue-Id: BA0F132EA1 X-Migadu-Spam-Score: -11.42 X-TUID: +SmA0sFblU9r --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2023-09-06, Maxim Cournoyer wrote: > Simon Tournier writes: >> On Wed, 06 Sep 2023 at 16:55, Christopher Baines wrot= e: >> >>> Once we know what tags to use, I can have the QA frontpage do something >>> similar to the "Mark as moreinfo" links, so it's easy to just click a >>> button then send the email to change the state of a issue. >> >> That=E2=80=99s cool! >> >> Well, using emacs-debbugs and then >> >> C-u M-x debbugs-gnu-usertags guix-patches RET >> >> the list of usertags is: >> >> guix-patches for-core-updates >> guix-patches reviewed-looks-good >> >> And if instead of guix-patches we consider guix then it reads, >> >> guix build-system >> guix cross-compilation >> guix for-core-updates >> guix looks-good >> guix patch >> guix plz-work >> guix powerpc64le-linux >> guix ready-to-review >> guix reproducibility >> guix reviewed >> guix reviewed-looks-good >> guix test-tag >> guix v1.3.0 >> >> However, I do not know how to list all the bugs for the package >> guix-patches that matches the usertag reviewed-looks-good. Anyway! > > Clicking on an entry in the above list shows them; I'm sure we could > define a procedure to directly show the bugs associated with a usertag, > which would be useful. > >> I think that the usertag =E2=80=99reviewed=E2=80=99 is a good idea. Tha= t would be a >> very good start. Then if it helps, we could add other usertags as >> reviewed-julia for patches that the Julia team can merge. > > +1 for the 'reviewed' usertag (using the 'guix' user). > >> Discussing about idea, would it be possible that the QA infrastructure >> automatically send a message to Debbugs for tagging? For example, the >> usertag =E2=80=99qa-ok=E2=80=99 or whatever other meaningful name. :-) > > +1 for that as well, maybe 'qa-passed'. Overall, I like this! The only concern is that it is maintaining QA information in multiple places, the QA service itself, and trying to mirror it to the bug tracker... QA might fail with a later patch iterations, so it should also then go and remove the qa-passed tag? Should it remove the tag when QA is currently in an unknown state? live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZPn4CgAKCRDcUY/If5cW qnuZAQC6fZyDhFZkdzBGRokoeRXq45qdayJBiUFzpoGEZwEriwD/ZPP34C2AkrtX YbWUjUMtT2ESm1QkUHYaBi8Lao8rtgg= =eGUj -----END PGP SIGNATURE----- --=-=-=--