all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: 67198@debbugs.gnu.org
Cc: tristan@cott.am, cox.katherine.e+guix@gmail.com,
	liliana.prikler@gmail.com, andrew@trop.in
Subject: [bug#67198] [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Wed, 15 Nov 2023 18:11:19 +0100	[thread overview]
Message-ID: <87v8a3x7pk.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <0e781a8a92a4ac67cb659643c2a5a42acc0b9e87.1700051896.git.tristan@cott.am> (Tristan Cottam via Guix-patches via's message of "Wed, 15 Nov 2023 13:38:16 +0100")

Hello,

Tristan Cottam via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-adwaita-dark-theme): New variable.

Thank you.

> +(define-public emacs-adwaita-dark-theme
> +  (let ((commit "a97d5d5f5657a52c3b4c4b146b4d307dfb1a7a74")
> +        (revision "0"))
> +    (package
> +      (name "emacs-adwaita-dark-theme")
> +      (version (git-version "1.1.0" revision commit))

The last commit is actually a version bump to "1.1.1", so you can bind
`version' to "1.1.1", drop `revision' and use that commit instead.

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://gitlab.com/jessieh/adwaita-dark-theme")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "0g8fjqmz805fhqspbzmpvb90kpzwigl4z56bkykywgy2cwb9ljzh"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://gitlab.com/jessieh/adwaita-dark-theme")
> +      (synopsis "Adwaita-inspired dark color scheme for Emacs")
> +      (description
> +       "adwaita-dark-theme is an Adwaita-inspired dark color scheme for
> +Emacs.")

Nitpick: "Adwaita Dark is an Adwaita-inspired…"

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou






  reply	other threads:[~2023-11-15 17:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15 12:38 [bug#67198] [PATCH] gnu: Add emacs-adwaita-dark-theme Tristan Cottam via Guix-patches via
2023-11-15 17:11 ` Nicolas Goaziou via Guix-patches via [this message]
2023-11-15 18:41   ` Liliana Marie Prikler
2023-11-15 20:07     ` Nicolas Goaziou via Guix-patches via
2023-11-15 18:40 ` Liliana Marie Prikler
2023-11-15 21:59 ` [bug#67198] [PATCH v2] " Tristan Cottam via Guix-patches via
2023-11-18 11:31 ` [bug#67198] [PATCH v3] " Tristan Cottam via Guix-patches via
2024-01-07 15:04   ` bug#67198: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8a3x7pk.fsf@nicolasgoaziou.fr \
    --to=guix-patches@gnu.org \
    --cc=67198@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=liliana.prikler@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    --cc=tristan@cott.am \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.