From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id MJLGNVTq8GW7tQAAqHPOHw:P1 (envelope-from ) for ; Wed, 13 Mar 2024 00:50:45 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id MJLGNVTq8GW7tQAAqHPOHw (envelope-from ) for ; Wed, 13 Mar 2024 00:50:44 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm3 header.b=n1cKXwGS; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=aYgNg7+c; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710287444; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xXfg+l1qG64n/ThkuM6uKrm0ZO3xXibbBnZDBGVanh4=; b=AblzB8SlF+RaUfsSz98Ck/doEi4JC7WjkvIT9kEOvm8+T6SMXkqN5dCtVIsYKAsplEnsIO N6+wlBZKqM8d5+sGemMyvy1Yzy4bSSlB/CHiC16Tykx0bDt4dEGcY1k8GrWmFr9dFS5Sa4 4xxaz5Ah/PqRrAoggrQoSqTtOOMZuj7iQZoeuOutq62SHTvc8abV6tTQz6GVd8LRgryCoi 59noo+vIWG2XXTXKpKSNoYI/W1BIRQbnzdI0wkPorXqbqjVeZxw+2+PJ/VbavR7ROI8oZK 5DsSJvTB3BhlYHlI6GS+Xp/URp2q6v/o6k5EA/3UZ5e0tBZf+pRe33EqEhRMTg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1710287444; a=rsa-sha256; cv=none; b=aiDjNMhkuMkZHj5qhYKUBhPpmoaYqrAY9Xh17YA8epFIIPfGR9I2vG0Ay5FEVifVJgycz1 jN3oMUsiigOdkIwHZbxeWxkfY/wkFZpC3BwECVkP2M9qCPCjzGs/Qi3egLNIXwWM1wlNZt Ionbbgm1lced83tLiHJNG4QQZZzr4d1zbjvesx/pMLNEVJfSSkznRqiXE/e9ARVt15n/X1 aC7hfFiYR8KeO957KTV/0BrIiwia32sM9UZ20j5n8WFmDjpmDYV0GcKBDQsVFZEamM0bsj FzH6RzmuE2mxq23bt81+9zsDYE+eAjYHkErD6el+zEz3aUJqdhK8L5oDrMHqkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm3 header.b=n1cKXwGS; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=aYgNg7+c; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5A3B03876C for ; Wed, 13 Mar 2024 00:50:43 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkBt9-0007np-OJ; Tue, 12 Mar 2024 19:50:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkBt5-0007ng-Vk for guix-patches@gnu.org; Tue, 12 Mar 2024 19:50:28 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkBt5-0000gR-Nv for guix-patches@gnu.org; Tue, 12 Mar 2024 19:50:27 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rkBte-0003Ho-EM for guix-patches@gnu.org; Tue, 12 Mar 2024 19:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#68197] [PATCH 0/5] gnu: yt-dlp: Update to 2023.12.30 References: In-Reply-To: Resent-From: Ian Eure Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Mar 2024 23:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68197 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 68197@debbugs.gnu.org, ian@retrospec.tv Received: via spool by 68197-submit@debbugs.gnu.org id=B68197.171028741812572 (code B ref 68197); Tue, 12 Mar 2024 23:51:02 +0000 Received: (at 68197) by debbugs.gnu.org; 12 Mar 2024 23:50:18 +0000 Received: from localhost ([127.0.0.1]:44176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkBsw-0003Gh-Af for submit@debbugs.gnu.org; Tue, 12 Mar 2024 19:50:18 -0400 Received: from fhigh4-smtp.messagingengine.com ([103.168.172.155]:45889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkBss-0003GU-LX for 68197@debbugs.gnu.org; Tue, 12 Mar 2024 19:50:16 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 7A2DA11400FD; Tue, 12 Mar 2024 19:49:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 12 Mar 2024 19:49:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm3; t=1710287374; x=1710373774; bh=xXfg+l1qG6 4n/ThkuM6uKrm0ZO3xXibbBnZDBGVanh4=; b=n1cKXwGS/dAQXr8YEuNBs5XeVJ gbVZQ3SOtIhYTLgj9ewr/gPSHzKgXEhUoNVgRk2oJhFQEx/HRRnBw9UREoAGGjNb EODQLS4Z4+h8yrimgFayocb3ObWcB4f3UykRqgXBff146mtyyO+vdNCubMHiX7Aw RyoWL8upZN/99qnkzF+T82tpM7aaMVfX63WrGDmaXrhw62Hssmrg7zG2/4emI7Y5 9ujYq1ipB9sH9NfhwmFrF/nqolcwgUpdBzxAyDJqnh0ZryTGxwUr15tEYASOxs5s EGSOqzoM9MNGLGA616sdjY2cMeK19i/ieDGpXeV69uWhELsZWQbKCo+AERFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1710287374; x=1710373774; bh=xXfg+l1qG64n/ThkuM6uKrm0ZO3x XibbBnZDBGVanh4=; b=aYgNg7+caEBMQ1TILeXiuRFzpRoTYvBpm7aktpxzc6Ww MXYO+smLRNETcCs4qLoTdTQoUUU7cr2QP6l7nI1loIW6mdpAHztrc0HaDkC2rcyx 6Dq/fCGK4adKzxtzags5b4EZ3+ktqga5QRVPvwo5TriYKNtyL3mVX9Ftq74iUa2q UDjqf5EsN+6nPK+Bh95Efh02Nn++rk8A4XccygFUr3UtjDui94gFaof05shcmSpy qypXfLY0DVc1yTDql4VUyGt0IMq/0ETc1mKoE4WzfVNoyH64MOwGSPn/gIL5Nfsc qOtCZCPZAwwxEjdTjSZyOH+Ar3D3cY1RfQ7GZwSl5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrjeeggddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfgfhvffufffkgggtgfesthhqredttd erjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhv qeenucggtffrrghtthgvrhhnpeduueekgfdtuedtuefggeeuudduheekfeegjeegteefje elteejveefgfegleevueenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrhgvthhroh hsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Mar 2024 19:49:33 -0400 (EDT) User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure Date: Tue, 12 Mar 2024 16:23:30 -0700 Message-ID: <87v85rui2c.fsf@meson> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.89 X-Spam-Score: -4.89 X-Migadu-Queue-Id: 5A3B03876C X-Migadu-Scanner: mx11.migadu.com X-TUID: RW240knzYlhb Hi, thanks for doing this. Few things: I don=E2=80=99t think it makes sense to add version 2023.11.16 in one=20 patch, then replace it with 2023.12.13 in the next. I=E2=80=99d go=20 straight to 2023.03.10, which was just released. Do you know how many packages python-requests would require=20 rebuilding? Since it=E2=80=99s a minor version bump, I=E2=80=99d expect it= =20 wouldn=E2=80=99t break builds, just require a lot of rebuilds, since it=E2= =80=99s=20 a fairly popular library. If possible, I think we should update=20 and rebuild instead of adding a second version. It=E2=80=99s not clear to me why urllib3 2.x is getting added. The=20 requirements for 2023.12.13[1] say that 1.26.17 or newer is=20 acceptable; 1.26.15 is in Guix presently. It seems inadvisable to=20 use a library with a major version greater than yt-dlp expects. I=20 think it=E2=80=99d be simpler to update to 1.26.18 (the latest 1.x=20 release) and not maintain two versions. It looks like this was=20 last updated around a year ago, in commit=20 3e8d608dac2eb9f387431bd8976f78de9ea7a701, and I don=E2=80=99t see anything= =20 special about that, so that makes me think this would be a=20 relatively safe course. > - (arguments > - ;; FIXME: Some tests require network access. > - '(#:tests? #f)) > + (arguments (list #:tests? #f)) > +(define-public python-requests > + (package > + (inherit python-requests-2.31) > + (name "python-requests") > + (version "2.28.1") > + (source (origin > + (method url-fetch) > + (uri (pypi-uri "requests" version)) > + (sha256 > + (base32 > +=20 > "10vrr7bijzrypvms3g2sgz8vya7f9ymmcv423ikampgy0aqrjmbw")))) > + (build-system python-build-system) ; Tests require network=20 > access. Looks like this comment migrated away from the context it=E2=80=99s=20 helpful for. > @@ -3609,7 +3632,7 @@ (define-public python-urllib3 > (base32 > "01dkqv0rsjqyw4wrp6yj8h3bcnl7c678qkj845596vs7p4bqff4a")))) > (build-system python-build-system) > - (arguments `(#:tests? #f)) > + (native-inputs '()) A comment on the empty (native-inputs) would be good, I think. (I=E2=80=99m not a Guix committer, so I can=E2=80=99t actually move this fo= rward /=20 my thoughts are just my own. I=E2=80=99d just like to see a yt-dlp=20 update.) Thanks, =E2=80=94 Ian [1]:=20 https://github.com/yt-dlp/yt-dlp/blob/9f40cd289665b2fb8a05ccaf9721b3b2ca0f3= 9c7/requirements.txt#L7