From: "Ludovic Courtès" <ludo@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 71622@debbugs.gnu.org, jgart <jgart@dismail.de>
Subject: bug#71622: mumi CLI client features for review checklists
Date: Thu, 27 Jun 2024 14:21:55 +0200 [thread overview]
Message-ID: <87v81u7ezg.fsf@gnu.org> (raw)
In-Reply-To: <87r0cv6vj0.fsf@systemreboot.net> (Arun Isaac's message of "Mon, 17 Jun 2024 23:42:43 +0100")
Hi Arun,
Arun Isaac <arunisaac@systemreboot.net> skribis:
> # Idea 1
>
> Projects provide a review checklist in their .mumi/config. For example,
> something like
>
> ((review-checklist . (((name . good-commit-message)
> (description . "Are the commit messages written well?")
> (tag . review-good-commit-message))
> ((name . good-synopsis-description)
> (description . "Are the synopsis and description written well?")
> (tag . review-good-synopsis-description))
> ((name . tests-run)
> (description . "Are the package tests being run (if available)?")
> (tag . review-tests-run))
> […]))
> […])
[...]
> # Idea 2
>
> A second much simpler idea is to implement templates for `mumi
> compose'. Projects provide templates under .mumi/templates. For example,
> $ cat .mumi/templates/review
> [ ] Are the commit messages written well?
> [ ] Are the synopsis and description written well?
> [ ] Are the package tests being run (if available)?
I prefer #2: it’s familiar to anyone used to Git{Hub,Lab}, it’s simpler,
good enough, and doesn’t go too far to provide a technical solution to a
social problem.
Alongside, a ‘mumi approve’ command that would set the
‘reviewed-looks-good’ tag would be a great step forward.
Thank you!
Ludo’.
prev parent reply other threads:[~2024-06-27 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 22:42 bug#71622: mumi CLI client features for review checklists Arun Isaac
2024-06-18 4:16 ` Suhail Singh
2024-06-27 12:21 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v81u7ezg.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=71622@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.