From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id YK0MGBWxgGYXegAA62LTzQ:P1 (envelope-from ) for ; Sun, 30 Jun 2024 01:12:53 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id YK0MGBWxgGYXegAA62LTzQ (envelope-from ) for ; Sun, 30 Jun 2024 03:12:53 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JfYQfaFD; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719709973; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=1YSUyAPHORLqRzWesO+5YrHIACxFGiBAnMS0gOagJWA=; b=hACR7yxKX5cqJniqaZAA8wjQpK3+c1aA8Ru4GNkmLimDrOqTKaf/50elTiGRAPqvyT3jer 6i/8UGTHVZlUjCbwXLrpaBGb3v7V2X30hxg5iSlOpbEI2Tvpb5Uva8CBfb/xlkRBsV2Nsz u/19qY7INWdGrbb5hPvSinDDzsLCzQn6Dey2fPeC3FxIM5zltJVs5TX2mK6iZ6AEox+6Vb 62bx1uzmGXnqkMPcR6nOHy8P2SaNFB/YGX78ihHz7L7VL+Vi88pcSWgdgnZTrJFtThziSv zhieTmaZ8OMrJB2H08pWFnpVs7vFlLimNFs2osdBgTcyZGiKEBkPP+U0LMGt4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JfYQfaFD; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1719709973; a=rsa-sha256; cv=none; b=rrFaSMK263DkaOXtXqhNzFXd32cyfJUhuKIMIRxIaWZaznIWPNWAwQ113221w2xiLOuL1N dkAdUdbBuQ3UfDLx/1pZVp+Ln80InBLRU7s/ka4mkFO6IDG7Rxkb4T0MmT7S1825XutHuG VvIvQuqZkH3Nx1nUrMtF5QBgYQyeKBUTBxBrs3EK/g7yNkojGRNfOEfvS4hR97Th+iW/vM dFfFaap1HnV8aPKNgUcGFpKu7u1j8L+QFItEBYDSo56MssKesmoa0QZAHQq78vX3lbkNmj 289x+6zjqsdXzvpI6xLXptP0z34cTwSvX4pRjxwfN0IgYhJQZWBWT/PgP72M7A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CABA26732E for ; Sun, 30 Jun 2024 03:12:52 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNj6u-0005t5-Qn; Sat, 29 Jun 2024 21:12:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNj6s-0005sZ-A3 for guix-devel@gnu.org; Sat, 29 Jun 2024 21:12:06 -0400 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNj6q-0001go-PA for guix-devel@gnu.org; Sat, 29 Jun 2024 21:12:06 -0400 Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-79d6bc90b90so105662185a.0 for ; Sat, 29 Jun 2024 18:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719709922; x=1720314722; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1YSUyAPHORLqRzWesO+5YrHIACxFGiBAnMS0gOagJWA=; b=JfYQfaFDGak0L6d/NHMrd8dKHTzAYH6g6hXT9eSFOip2JFQbr3KfTfFLbPDb/fReqM LtU28eHt/3jAqOxKwItczkEdj7B3dt94kjBOgHSCKy2uEyhS9WjFbyo5iicdu/BBxWqY cO9BMRlYqIk7XskwzHvKBRm+nWhOIk7ns9VxQXSF6G0QdcT2jcXmrcayqcXOUpLdTFWf 1wY+zjKsF0+t+CaZOfauc3E5RBj91ZLOeRbRB19NDkGQMWmJ5r0RaKAFUlnJwfbtiVYN OM7UOr0Tco/Cqp4pNYP8ErK8kw4C5oDswc812iZYl8WfrSUTMZHHxAIeotkboT+nfBsS cI1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719709922; x=1720314722; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1YSUyAPHORLqRzWesO+5YrHIACxFGiBAnMS0gOagJWA=; b=PQMRb0+peo9oYz+kbNfyjD/ZzFmyprg9ohkm4EukkVVAEiw7ogP17X0KZ4QfHn+Cve w1nF6jkSh2zGrkON6DCfNRAuUpDx5HWcZNJ2roVExcaUFnpdVJIm3AkleAnBg47EZBDY /n8MPCLRc8JhnT0m4jZbRt9ptdSTHU9vlg0Sp07Iy/abSBNNxYJpTbIb5k14/iG6l+JM bsGNIgvx3C2FsQLtj7WVXVfJQ1XbAVif1CHmns8Hk8DhzWA1u+Ei6DYyYgX7VEaRhWKB pGi3zGp0akXKv4pBdUHe3EGcbpEFXSNoEVIwSmULQY91pFL2hODJRd9uuPp9sorDfMhd G1Ig== X-Forwarded-Encrypted: i=1; AJvYcCVIP8A33BsiJ5wyvvGxQ716BmwLLK3FffY42VJOzYzkLdKTbJ6pG81jW8UUDnV+dMyUFFrNg2QcZj28cDbrBqbl5cs= X-Gm-Message-State: AOJu0YxVSEQOxYiRMrT3bUpxHZnQ6iyHko5aUMoGTKM8fdsKKpYcZtVZ H5ogJAKziQ6G4G7MyqFC74J9ZTuv/nrPuI+Ao+emGlDeTQD/mAubX5qnfQ== X-Google-Smtp-Source: AGHT+IEH4hSzC7EYFanNHe/gSfmhT8X2Flq/CfbjluuhvL95jHseWPAsvJsaHhw4gw/IDVM6MdA5IQ== X-Received: by 2002:a05:620a:ec5:b0:792:cd45:8e2b with SMTP id af79cd13be357-79d7babb05bmr224136285a.78.1719709921873; Sat, 29 Jun 2024 18:12:01 -0700 (PDT) Received: from hurd ([204.48.95.10]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79d692eac65sm207181185a.90.2024.06.29.18.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jun 2024 18:12:01 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Cc: Richard Sent , guix-devel@gnu.org Subject: Re: Codifying/Documenting Guix commit message conventions? In-Reply-To: <833a84d6421dca2f91c80668430a03b445c91475.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 29 Jun 2024 08:51:59 +0200") References: <87bk3mvvfy.fsf@freakingpenguin.com> <877ce8a6yh.fsf@gmail.com> <833a84d6421dca2f91c80668430a03b445c91475.camel@gmail.com> Date: Sat, 29 Jun 2024 21:11:59 -0400 Message-ID: <87v81r8c9s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::732; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x732.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: CABA26732E X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -8.72 X-Spam-Score: -8.72 X-TUID: kWwLEtgXWZ0b Hi Liliana, Liliana Marie Prikler writes: > Hi Guix, > > Am Freitag, dem 28.06.2024 um 21:11 -0400 schrieb Maxim Cournoyer: >> Richard Sent writes: >>=20 >> > Another one seems to be the [security fixes], [fixes CVE-...], and >> > [fixes TROVE-...] blocks added to certain header lines. What other >> > tags exist? There seems to be inconsistency here when referring to >> > multiple CVEs. For example, when a fixes tag references multiple >> > CVEs you can find. >> >=20 >> > [fixes CVE-2020-10700, CVE-2020-10704]=C2=A0 [5] >> > [fixes CVE-2020-3898 & CVE-2019-8842]=C2=A0=C2=A0 [6] >> > [fixes CVE-2023-{28755, 28756}]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 [7] >>=20 >> I think these are likely to bust the 70 characters limit for a git >> commit summary line, so perhaps we could standardize on [fixes CVE- >> XXX] for single CVEs or [security fixes] when there are more than one >> (listing the CVEs in the commit message body instead then). > > I think we should use a "Fixes: [short description] " footer for > both Guix and upstream bugs, that can easily be parsed =E2=80=93 hopefull= y by > both humans and machines. That would give the interested reader the > (contextual) information they need, while also leaving the main body to > a more thorough description of the patch itself. That's a good idea, and I already use a "Fixes:" git trailer for fixed bugs, but I also like to be able to see from the 'git log' output which commits were security related (I see value in the summary [security fixes] "tag"). --=20 Thanks, Maxim