bug#71936: [Cuirass] ‘cuirass remote-server’ crashes badly when it receives garbage

bug#71936: [Cuirass] ‘cuirass remote-server’ crashes badly when it receives garbage

[Ludovic Courtès]

From the ‘cuirass remote-server’ log:

--8<---------------cut here---------------start------------->8---
2024-07-01 13:33:35 error: invalid log received from 141.80.181.254
2024-07-01 13:33:37 fetching 3 outputs of '/gnu/store/608c7ch5d34h9z0mavmpjm8h5jn0wjmf-exult-1.8.drv' from http://141.80.167.185:5558
2024-07-01 13:33:38 Uncaught exception in task:
2024-07-01 13:33:38 In fibers.scm:
2024-07-01 13:33:38    186:20 16 (_)
2024-07-01 13:33:38    145:21 15 (_)
2024-07-01 13:33:38 In ice-9/boot-9.scm:
2024-07-01 13:33:38   1752:10 14 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
2024-07-01 13:33:38 In cuirass/scripts/remote-server.scm:
2024-07-01 13:33:38    687:11 13 (_)
2024-07-01 13:33:38 In ice-9/boot-9.scm:
2024-07-01 13:33:38   1747:15 12 (with-exception-handler #<procedure 7f5cf21c9600 at ice-9/boot-9.scm:1831:7 (exn)> _ #:unwind? _ #:unwind-for-type _)
2024-07-01 13:33:38 In cuirass/scripts/remote-server.scm:
2024-07-01 13:33:38     430:6 11 (serve-build-requests _ #<<channel> getq: #<atomic-box 7f5cf2dbaa60 value: (() #(#<atomic-box 7f5cd4f233d0 value: W> #<procedure resume (thunk)>))> getq-gc-counter: #<atomic-box 7f5cf2dbaa50 value: 22> putq: #<atomic-box 7f5cf2dbaa30 value: (())> putq-gc-counter: #<atomic-box 7f5cf2dbaa20 value: 39>>)
2024-07-01 13:33:38 In ice-9/boot-9.scm:
2024-07-01 13:33:38   1752:10 10 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
2024-07-01 13:33:38 In cuirass/scripts/remote-server.scm:
2024-07-01 13:33:38    436:25  9 (_)
2024-07-01 13:33:38 In cuirass/remote.scm:
2024-07-01 13:33:38    483:41  8 (receive-message _ #:router? _)
2024-07-01 13:33:38 In ice-9/iconv.scm:
2024-07-01 13:33:38     75:20  7 (bytevector->string _ _ _)
2024-07-01 13:33:38 In ice-9/rdelim.scm:
2024-07-01 13:33:38    160:18  6 (read-string _)
2024-07-01 13:33:38 In ice-9/suspendable-ports.scm:
2024-07-01 13:33:38    591:33  5 (read-char _)
2024-07-01 13:33:38    522:13  4 (peek-char-and-next-cur/iconv #<input: string 7f5cd6c72150>)
2024-07-01 13:33:38 In unknown file:
2024-07-01 13:33:38            3 (port-decode-char #<input: string 7f5cd6c72150> #vu8(130 163 101 110 99 165 99 108 101 97 114 164 108 111 97 100 129 163 99 109 100 175 95 112 114 101 112 95 97 117 116 104 95 105 110 102 111 0 0 0 160 162 141 207 92 127 0 0 0 0 0 0 0 0 0 0 3 0 0 0 0 0 0 0 21 0 0 0 0 0 0 0 96 163 159 214 92 127 0 0 0 0 0 0 0 0 0 0 3 0 0 0 0 0 0 0 21 0 0 0 0 0 0 0 192 162 141 207 92 127 0 0 0 0 0 0 0 0 0 0 3 0 0 0 0 0 0 0 95 160 108 42 163 128 255 255 0 0 0 0 0 0 0 0 95 139 120 42 163 128 255 # ?) ?)
2024-07-01 13:33:38 In ice-9/boot-9.scm:
2024-07-01 13:33:38   1685:16  2 (raise-exception _ #:continuable? _)
2024-07-01 13:33:38   1683:16  1 (raise-exception _ #:continuable? _)
2024-07-01 13:33:38   1685:16  0 (raise-exception _ #:continuable? _)
2024-07-01 13:33:38 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
2024-07-01 13:33:38 Throw to key `decoding-error' with args `("decode-char" "input decoding error" 84 #<input: string 7f5cd6c72150>)'.
2024-07-01 13:33:38 build succeeded: '/gnu/store/608c7ch5d34h9z0mavmpjm8h5jn0wjmf-exult-1.8.drv'
2024-07-01 13:33:38 Uncaught exception in task:
2024-07-01 13:33:38 In fibers.scm:
2024-07-01 13:33:38     172:8  1 (_)
2024-07-01 13:33:38 In ice-9/boot-9.scm:
2024-07-01 13:33:38   1685:16  0 (raise-exception _ #:continuable? _)
2024-07-01 13:33:38 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
2024-07-01 13:33:38 Throw to key `psql-query-error' with args `(#f #f "no connection to the server\n")'.
2024-07-01 13:34:24 1 items queued for eventual download
2024-07-01 13:34:24 Uncaught exception in task:
2024-07-01 13:34:24 In fibers.scm:
2024-07-01 13:34:24     172:8  2 (_)
2024-07-01 13:34:24 In cuirass/notification.scm:
2024-07-01 13:34:24    164:15  1 (_)
2024-07-01 13:34:24 In ice-9/boot-9.scm:
2024-07-01 13:34:24   1685:16  0 (raise-exception _ #:continuable? _)
2024-07-01 13:34:24 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
2024-07-01 13:34:24 Throw to key `psql-query-error' with args `(#f #f "no connection to the server\n")'.
2024-07-01 13:34:31 Uncaught exception in task:
2024-07-01 13:34:31 In fibers.scm:
2024-07-01 13:34:31     172:8  2 (_)
2024-07-01 13:34:31 In cuirass/scripts/remote-server.scm:
2024-07-01 13:34:31    424:10  1 (_)
2024-07-01 13:34:31 In ice-9/boot-9.scm:
2024-07-01 13:34:31   1685:16  0 (raise-exception _ #:continuable? _)
2024-07-01 13:34:31 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
2024-07-01 13:34:31 Throw to key `psql-query-error' with args `(#f #f "no connection to the server\n")'.
2024-07-01 13:35:24 1 items queued for eventual download
--8<---------------cut here---------------end--------------->8---

Apparently, this happens as a result of a scanner on the MDC network (?)
sending garbage on open ports.

Ludo’.