From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 4CNEMNza+ma7RQEAe85BDQ:P1 (envelope-from ) for ; Mon, 30 Sep 2024 17:07:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 4CNEMNza+ma7RQEAe85BDQ (envelope-from ) for ; Mon, 30 Sep 2024 19:07:40 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=M0WN32g6; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=gGcDkJh3; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727716060; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yexSzdGRqvBO4qxAmusgReqKmUIy8Hgcuyi/56WFXg4=; b=JEsyNVl9bk0/usTkw4xh11+U7Bu3exEEk51HjsZN1C5Bakqz7HHGzyAMSTgL08EnD0LBcb UbMUt8tTeyGNNj3ffLKYm/HJUuUIDI4B6hQXHseitHPW4N3yZHKnkphGfZTrEFzOqRh0+b SM00XibhD2NNN5VJ1V4oWTTpU6l4VxjlMUzuCYgN+uqF6cFrPaoK5tWd+TKOsJJTWVkdpL fsg0CoyB++tmzQGHME3N7bCPzLv6jfrSc3f0BlqHllzrII2FubmsEUipuDPatEOBpHntV3 wHHgSFxBUyXTODPV4JBmv8b2pGMw2DT3KZPhRofq0xBbh8xWwqLdGRlsQbB2AQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727716060; a=rsa-sha256; cv=none; b=IlnOM70Qy8sKd7X5xn7of9RsMHSYXzaFgo87nE5V83msB9C0NSU/9+PkG4x3RUWNlMY275 F9Yoj9EtxRywLU8LkE7DkEP7eNJ6hy8n8ygV7W7ijXRhnRym5hLjOdqbmHnOeE4PGiLmYY HnPPrtG2KRChjMKfUd8QFs+utjInfUaOT8TbL+oXGPA1bXoPjvpecJz+GTGMm8i/VYKt4e PDEA+fAZNbirCAVHuEPG2N9cw7H6xI9SvXHOmL6VwhJgiwIJNJta/Vtvba8h9LydL2BNLO id7y+G4OvkB4pY/poYbnKLOXdQNhBrm7eUIrtZzDcqa2fOJhKEXQyntY3EhRsg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=M0WN32g6; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=gGcDkJh3; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 43F6D7DCDB for ; Mon, 30 Sep 2024 19:07:40 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svJrv-0006gJ-PB; Mon, 30 Sep 2024 13:07:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svJru-0006fx-2A for guix-patches@gnu.org; Mon, 30 Sep 2024 13:07:30 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svJrt-0001B8-JA for guix-patches@gnu.org; Mon, 30 Sep 2024 13:07:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=yexSzdGRqvBO4qxAmusgReqKmUIy8Hgcuyi/56WFXg4=; b=M0WN32g6vrLL7N/IavtkT5GYqZHtHWPR+ldtTlp+CiKJDErBsB7+K7ILjgClwhhFozzCxDawdWLtMOdX/YM7Qd5JtG5iaaqzjbeR5G/qdCxN/dfG/e61Rw0ytdGTh1QISeR7ZEFjbqpEA0wSaqLzn3MihZB46O45XrOaI+LLbRw1DImRl18CkbK5GKJw6x+iDBrfGWGXmpF79lKPPvKRXBW31AK6uivpCTk8tR3SSU9IBRrmwjerRTMiBvyBQT/HJ5AkyV/KKGxQQJOqS3TgE7HzJrpSiHfOL1qHCSklgurFSF43oAog5DYB76faE+z4fqegLnqK67B939B6Fyl5Tg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svJsQ-0006l6-Fy for guix-patches@gnu.org; Mon, 30 Sep 2024 13:08:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73260] Add libguestfs Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 Sep 2024 17:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73260 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Giacomo Leidi Cc: 73260@debbugs.gnu.org Received: via spool by 73260-submit@debbugs.gnu.org id=B73260.172771606825948 (code B ref 73260); Mon, 30 Sep 2024 17:08:02 +0000 Received: (at 73260) by debbugs.gnu.org; 30 Sep 2024 17:07:48 +0000 Received: from localhost ([127.0.0.1]:45912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svJsB-0006kS-KZ for submit@debbugs.gnu.org; Mon, 30 Sep 2024 13:07:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svJs8-0006jO-Ru for 73260@debbugs.gnu.org; Mon, 30 Sep 2024 13:07:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svJrW-00018y-Jj; Mon, 30 Sep 2024 13:07:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=yexSzdGRqvBO4qxAmusgReqKmUIy8Hgcuyi/56WFXg4=; b=gGcDkJh3bsZ85OZms03r Ri09XMqP6qtW3TNye2GunS20kF1ezgEFpTiN+t7Z3F6vuTAzOqWqCRj/ijuerHn9vW1yWT9gkiAca DzJFqFxCrIWnOB0+u6v4U1Qp6T6Z/jYHUR7Fy2m8Ini2UwK/b/nokxF1fAiQNYUmij0c5iw+lsHUM vbunGBY7zRk6I9UtbIJFriPk03anZWloUF2f56KfwVq4IIfz8y7vznU2z67ahIOD7LA0n2t2gdFVl qjCfFuJhTDKF7JaUjbJhNTwyQKsqOdSSV0/CneIam3kDPRwE4ZEK4zYuvQ3rzIrkHsbadHUk7j93z StCU3FgjsOzG0w==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Giacomo Leidi's message of "Sat, 14 Sep 2024 23:20:57 +0200") References: <247263a340d7dedbf4671ebaf75da540e7e62734.1726348858.git.goodoldpaul@autistici.org> Date: Mon, 30 Sep 2024 19:07:04 +0200 Message-ID: <87v7yd5avb.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 43F6D7DCDB X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -4.00 X-Migadu-Spam-Score: -4.00 X-TUID: riYz13VmmdmD Giacomo Leidi skribis: > * gnu/packages/virtualization.scm (libguestfs-minimal): New variable. > * gnu/packages/patches/libguestfs-syms.patch: Add file. > * gnu/local.mk: Add it. > > Change-Id: Ide22707724ecd41145243c9f41adc3f5557c593e [...] > +++ b/gnu/packages/patches/libguestfs-syms.patch > @@ -0,0 +1,26 @@ > +diff -urN a/lib/Makefile.am b/lib/Makefile.am As suggested by =E2=80=98guix lint=E2=80=99 :-), please add a couple of lin= es at the top explaining what the patch does and what its upstream status is. [...] > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-makefiles > + (lambda _ > + (for-each patch-shebang > + (find-files ".")) > + (for-each (lambda (makefile) > + (substitute* "ocaml/Makefile.am" > + (("\\$\\(DESTDIR\\)\\$\\(OCAMLLIB\\)") > + lib/ocaml))) > + '("ocaml/Makefile.am" > + "ocaml/Makefile.in")))) > + (replace 'bootstrap > + (lambda _ > + (invoke "autoreconf" "-vif"))) You can arrange to only modify =E2=80=98Makefile.in=E2=80=99, in which case= the =E2=80=98bootstrap=E2=80=99 phase is unnecessary and autotools can be remov= ed from the inputs. > + ;; The =E2=80=98validate-runpath=E2=80=99 phase = fails to find libguestfs.so.0. > + (invoke (string-append #$(this-package-native-in= put "patchelf") > + "/bin/patchelf") > + "--add-rpath" (string-append #$output "/= lib") sofile)) > + '("perl/blib/arch/auto/Sys/Guestfs/Guestfs.so" > + "ocaml/dllmlguestfs.so")))) Same comment as on the previous patch. :-)