all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 74508@debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#74508] [PATCH v2 1/3] services: mingetty: Add additional configuration options.
Date: Mon, 02 Dec 2024 12:05:48 +0100	[thread overview]
Message-ID: <87v7w2wdir.fsf@gnu.org> (raw)
In-Reply-To: <3735b134a382255528e7da6706828ee5d80f50a5.1732550735.git.~@wolfsden.cz> (Tomas Volf's message of "Mon, 25 Nov 2024 17:05:33 +0100")

Hi,

Tomas Volf <~@wolfsden.cz> skribis:

> +@item @code{chdir} (default: @code{#f})
> +When set to a string, change into that directory before calling the
> +login program.
> +
> +@item @code{chroot} (default: @code{#f})
> +When set to a string, call @code{chroot} with that directory.

How about ‘working-directory’ and ‘root-directory’ for these two, in
line with widespread naming convention?

And instead of “call chroot”, I’d write “use this directory as the
process's root (``chroot'' into it).” (again in an effort to avoid
jargon and abbreviations).

Other than that LGTM!

Ludo’.




  parent reply	other threads:[~2024-12-02 11:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-24 14:28 [bug#74508] [PATCH 0/2] Improvements for mingetty-service-type Tomas Volf
2024-11-24 14:31 ` [bug#74508] [PATCH 1/2] services: mingetty: Add additional configuration options Tomas Volf
2024-11-25  1:45   ` Maxim Cournoyer
2024-11-25 15:37     ` Tomas Volf
2024-11-24 14:31 ` [bug#74508] [PATCH 2/2] services: mingetty: Support waiting on shepherd services Tomas Volf
2024-11-25  1:49   ` Maxim Cournoyer
2024-11-25 16:05 ` [bug#74508] [PATCH v2 1/3] services: mingetty: Add additional configuration options Tomas Volf
2024-11-25 16:05   ` [bug#74508] [PATCH v2 2/3] services: mingetty: Rename misnamed accessors Tomas Volf
2024-11-25 16:05   ` [bug#74508] [PATCH v2 3/3] services: mingetty: Support waiting on shepherd services Tomas Volf
2024-12-02 11:05   ` Ludovic Courtès [this message]
2024-12-03  0:18     ` [bug#74508] [PATCH v2 1/3] services: mingetty: Add additional configuration options Tomas Volf
2024-12-03  0:11 ` [bug#74508] [PATCH v3 " Tomas Volf
2024-12-03  0:11   ` [bug#74508] [PATCH v3 2/3] services: mingetty: Rename misnamed accessors Tomas Volf
2024-12-03  0:11   ` [bug#74508] [PATCH v3 3/3] services: mingetty: Support waiting on shepherd services Tomas Volf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v7w2wdir.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=74508@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=~@wolfsden.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.