From: ludo@gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: Git.
Date: Sun, 01 Sep 2013 21:48:47 +0200 [thread overview]
Message-ID: <87txi4gw68.fsf@gnu.org> (raw)
In-Reply-To: <20130901152708.GA5741@debian> (Andreas Enge's message of "Sun, 1 Sep 2013 17:27:08 +0200")
Andreas Enge <andreas@enge.fr> skribis:
> On Thu, Aug 29, 2013 at 10:16:37PM +0200, Cyril Roelandt wrote:
>> So, I've just tried to make git work. The attached patch allows me
>> to build Git on my x86 machine, but the build fails on my x86-64
>> machine. Any idea ?
>
> For me, everything works on x86_64 and with --system=i686-linux.
>
> The tests fail, but a few simple operations (stash, diff, pull) on the
> guix tree work. Shall I push the attached patch despite the test failures?
Yes, please (I’ll try to look at the test failures, though I’m happy to
share that with someone else.)
> + (lambda* (#:key #:allow-other-keys #:rest args)
> + (let ((configure (assoc-ref %standard-phases 'configure)))
> + (apply configure args)
> + (substitute* "Makefile"
> + (("/bin/sh") (which "sh"))
> + (("/usr/bin/perl") (which "perl"))
> + (("/usr/bin/python") (which "python")))))
Please indent according to scoping, and check the return value of
CONFIGURE:
(let ((configure (...)))
(and (apply configure args)
(substitute* ...)))
Thanks!
Ludo’.
next prev parent reply other threads:[~2013-09-01 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 20:16 Git Cyril Roelandt
2013-08-29 21:21 ` Git Ludovic Courtès
2013-09-01 15:27 ` Git Andreas Enge
2013-09-01 16:06 ` Git Nikita Karetnikov
2013-09-01 16:08 ` Git Andreas Enge
2013-09-01 19:43 ` Git Cyril Roelandt
2013-09-01 21:15 ` Git Andreas Enge
2013-09-01 19:48 ` Ludovic Courtès [this message]
2013-09-01 19:55 ` Git Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txi4gw68.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.