From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Python-build-system does not honour phases Date: Tue, 10 Sep 2013 19:48:30 +0200 Message-ID: <87txhsbma9.fsf@gnu.org> References: <20130907222607.GA28990@debian> <87hadtfzk4.fsf@gnu.org> <20130910082655.GA8621@debian> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJS8D-0003Yp-Fi for guix-devel@gnu.org; Tue, 10 Sep 2013 13:53:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJS85-0004dQ-Bg for guix-devel@gnu.org; Tue, 10 Sep 2013 13:53:41 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:47390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJS85-0004dL-4m for guix-devel@gnu.org; Tue, 10 Sep 2013 13:53:33 -0400 In-Reply-To: <20130910082655.GA8621@debian> (Andreas Enge's message of "Tue, 10 Sep 2013 10:26:55 +0200") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Andreas Enge skribis: > On Mon, Sep 09, 2013 at 11:35:55PM +0200, Ludovic Court=C3=A8s wrote: >> The problem is that both the gnu-build-system and the >> python-build-system were getting imported, and both export a >> =E2=80=98%standard-phases=E2=80=99. > > That is what I thought. I tried to add a > #:use-module ((guix build-system gnu) > #:select (gnu-build-system)) > but that was not enough. You=E2=80=99re mixing different things: the line above is on the host side, whereas the patch I proposed changes the modules imported on the build side. >> The fix is to use only python-build-system: > > That also does not seem to work. Could you be more specific? :-) With the patch I sent, the builder should start with: (begin (use-modules (guix build python-build-system) (guix build utils)) ...) So the global variable named =E2=80=98%standard-phases=E2=80=99 here is nec= essarily that of (guix build python-build-system). Can you try this patch to check the value of =E2=80=98phases=E2=80=99? --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm index 8429979..1b5eaa8 100644 --- a/guix/build/python-build-system.scm +++ b/guix/build/python-build-system.scm @@ -96,6 +96,6 @@ (define* (python-build #:key inputs (phases %standard-phases) #:allow-other-keys #:rest args) "Build the given Python package, applying all of PHASES in order." - (apply gnu:gnu-build #:inputs inputs #:phases phases args)) + (apply gnu:gnu-build #:inputs inputs #:phases (pk 'the-python-phases phases) args)) ;;; python-build-system.scm ends here --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [...] > Maybe we should try to use a variable name %python-standard-phases instea= d. That would be cheating. ;-) And really, it=E2=80=99s unnecessary. Ludo=E2=80=99. --=-=-=--