all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] guix package: allow multiple arguments after -i, -r, and -u
Date: Fri, 13 Dec 2013 23:35:35 +0100	[thread overview]
Message-ID: <87txecxtu0.fsf@gnu.org> (raw)
In-Reply-To: <87sitwfpig.fsf@netris.org> (Mark H. Weaver's message of "Fri, 13 Dec 2013 15:46:15 -0500")

Mark H Weaver <mhw@netris.org> skribis:

> From 95c205364cd0cececb0a464fea6f4a328467ef54 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Fri, 13 Dec 2013 15:37:57 -0500
> Subject: [PATCH] guix package: allow multiple arguments after -i, -r, and -u.
>
> * guix/scripts/package.scm (%options): Adapt option processors to accept and
>   return a second seed value: 'arg-handler', which handles bare arguments (if
>   not false).  The install, remove, and upgrade option processors return an
>   arg-handler that repeat the same operation.  All other option processors
>   return #f as the arg-handler.
>   (guix-package): Procedures passed to 'args-fold*' accept the new seed value
>   'arg-handler'.  The 'operand-proc' uses 'arg-handler' (if not false).

Looks great to me!

Could you add a test in guix-package.sh, which could be just

  guix package -i guile gcc -n

or similar?

Likewise, could you add an example in guix.texi that uses this syntax,
say just after “@var{options} specifies...”?

Thanks!

Ludo’.

  reply	other threads:[~2013-12-13 22:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 20:46 [PATCH] guix package: allow multiple arguments after -i, -r, and -u Mark H Weaver
2013-12-13 22:35 ` Ludovic Courtès [this message]
2013-12-14 19:13   ` Mark H Weaver
2013-12-14 21:09     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txecxtu0.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.