From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: gnu-build-system should set DESTDIR
Date: Mon, 10 Feb 2014 13:56:49 +0100
Message-ID: <87txc7yvla.fsf@gnu.org>
References: <20140210081934.GA15977@jocasta.intra>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48934)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WCqPw-0000D7-Cj
	for guix-devel@gnu.org; Mon, 10 Feb 2014 07:57:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WCqPr-0006tL-2x
	for guix-devel@gnu.org; Mon, 10 Feb 2014 07:56:56 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:40843)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WCqPq-0006tH-SY
	for guix-devel@gnu.org; Mon, 10 Feb 2014 07:56:51 -0500
In-Reply-To: <20140210081934.GA15977@jocasta.intra> (John Darrington's message
	of "Mon, 10 Feb 2014 09:19:34 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org

John Darrington <john@darrington.wattle.id.au> skribis:

> I think the make install target in gnu-build-system should set DESTDIR to=
 "/" (or "/.")
> Rationale:
>
> Many upstream makefiles (eg:=20
>
> https://git.gnome.org/browse/gnome-themes-standard/tree/themes/HighContra=
st/icons/Makefile.am)=20

We=E2=80=99re talking about GNOME makefiles only, I think.  The snippet bel=
ow is
clearly a hack IMO.

> assume that when DESTDIR is unset (or is "") then the package is being in=
stalled in a "live" system:
>
> if test -z "$(DESTDIR)"; then \
> 		echo "Updating Gtk icon cache."; \
> 		$(gtk_update_icon_cache); \
> else \
> 		echo "*** Icon cache not updated.  After (un)install, run this:"; \
> 		echo "***   $(gtk_update_icon_cache)"; \
> fi
>
> I have noticed that a number of packages in /nix/store/ have their own ve=
rsion=20
> of icon-theme.cache leading to warnings when doing guix package --install
>
> So we need to set DESTDIR to *something* and to arrange for some kind of =
post-install hook to update
> the cache.  The same goes for top level info nodes.

What about this: we add a GNOME build system doing a few things, such as
handling schemas [0] and setting DESTDIR if that=E2=80=99s a common idiom.

WDYT?

The post-install hook is definitely on the to-do list, but it needs a
bit of thought.

Thanks,
Ludo=E2=80=99.

[0] http://lists.gnu.org/archive/html/guix-devel/2013-10/msg00171.html