all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: ‘strip’ phase
Date: Mon, 27 Oct 2014 10:05:41 +0100	[thread overview]
Message-ID: <87tx2panmi.fsf_-_@gnu.org> (raw)
In-Reply-To: <87k33m179b.fsf@netris.org> (Mark H. Weaver's message of "Mon, 27 Oct 2014 00:11:44 -0400")

Mark H Weaver <mhw@netris.org> skribis:

>> I DO get a load of messages such as
>>
>>   strip:/gnu/store/icz59y35qqmm4jcrnkqx7d73xlzsq0lq-ruby-1.8.7-p374/lib/ruby/1.8/rexml/attlistdecl.rb:
>>   File format not recognized
>>
>> is there a way to prevent files with a .rb extension or ruby shebang
>> to be stripped?
>
> In theory the default 'strip' phase could be replaced by one that's more
> selective, but please don't do that.
>
> The problem happens in almost every package, so the improvements should
> be made in the default 'strip' phase.  The relevant procedure is 'strip'
> in guix/build/gnu-build-system.scm, but beware that changing that file
> (or just about anything else in that directory) will trigger a full
> rebuild of all packages.  It would be nice to do at some point, but it's
> quite far down on our TODO list.

I think the ‘strip’ phase is fine this way: sure, it ends up invoking
‘strip’ on files that are not ELF files, but it’s harmless.  So we get
these extra warnings in the build log, but they are really harmless.

Conversely, attempts to be more selective may miss actual ELF files.

WDYT?

Ludo’.

  reply	other threads:[~2014-10-27  9:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-26 20:31 [PATCH] gnu: Add ruby 1.8.7 Pjotr Prins
2014-10-26 23:33 ` Mark H Weaver
2014-10-26 23:44   ` Pjotr Prins
2014-10-26 23:53     ` Pjotr Prins
2014-10-27  0:53       ` David Thompson
2014-10-27  1:44         ` Pjotr Prins
2014-10-27  1:43     ` Mark H Weaver
2014-10-27  1:56       ` Pjotr Prins
2014-10-27  4:11         ` Mark H Weaver
2014-10-27  9:05           ` Ludovic Courtès [this message]
2014-10-27  9:28             ` ‘strip’ phase Mark H Weaver
2014-10-27 12:16               ` Ludovic Courtès
2014-10-27 14:23                 ` Mark H Weaver
2014-11-22 11:53                   ` Ludovic Courtès
2014-10-27  5:17   ` [PATCH] gnu: Add ruby 1.8.7 Pjotr Prins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx2panmi.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.