From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: Add gnugo. Date: Thu, 19 Feb 2015 18:39:36 -0500 Message-ID: <87twyhfp3b.fsf@netris.org> References: <1424354241-31310-1-git-send-email-david.hashe@dhashe.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOags-0006OG-RB for guix-devel@gnu.org; Thu, 19 Feb 2015 18:39:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOago-0000nJ-LG for guix-devel@gnu.org; Thu, 19 Feb 2015 18:39:30 -0500 Received: from world.peace.net ([50.252.239.5]:34807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOago-0000mf-GZ for guix-devel@gnu.org; Thu, 19 Feb 2015 18:39:26 -0500 In-Reply-To: <1424354241-31310-1-git-send-email-david.hashe@dhashe.com> (David Hashe's message of "Thu, 19 Feb 2015 07:57:21 -0600") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: David Hashe Cc: guix-devel@gnu.org Hi! David Hashe writes: > --- > gnu-system.am | 1 + > gnu/packages/gnugo.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 45 insertions(+) > create mode 100644 gnu/packages/gnugo.scm I agree with the feedback from Alex Kost and Andreas Enge, and will only add two more comments: * It needs a proper commit message. Assuming that it ends up in games.scm, the commit message would be: --8<---------------cut here---------------start------------->8--- gnu: Add gnugo. * gnu/packages/games.scm (gnugo): New variable. --8<---------------cut here---------------end--------------->8--- * Regarding the 'texinfo' input: I'm not sure if it's needed or not, but if it turns out to be needed, it certainly belongs in 'native-inputs', not 'inputs'. The difference is only important when cross-compiling. Thank you, and welcome to our community :) Mark