From: Mark H Weaver <mhw@netris.org>
To: Paul van der Walt <paul@denknerd.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] bump mu/mu4e to version 0.9.11
Date: Thu, 26 Feb 2015 19:00:56 -0500 [thread overview]
Message-ID: <87twy86x53.fsf@netris.org> (raw)
In-Reply-To: <87wq34nu5j.fsf@denknerd.org> (Paul van der Walt's message of "Fri, 27 Feb 2015 00:13:28 +0100")
Paul van der Walt <paul@denknerd.org> writes:
> Here's my first modest patch. I use mu4e, and therefore it bothered me
> that the version in Guix was about a year old. The upgraded version
> seems to work fine for me, so that's nice.
Looks good to me, modulo a few minor nits. Please see below.
> * gnu/packages/mail.scm: Bump mu version from 0.9.9.5 -> 0.9.11
By our usual conventions, the commit log should look like this:
--8<---------------cut here---------------start------------->8---
gnu: mu: Update to 0.9.11.
* gnu/packages/mail.scm (mu): Update to 0.9.11.
--8<---------------cut here---------------end--------------->8---
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index dc33c8c..b450e91 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
Please add your copyright line to the top of the file.
> @@ -304,18 +304,21 @@ repository and Maildir/IMAP as LOCAL repository.")
> (define-public mu
> (package
> (name "mu")
> - (version "0.9.9.5")
> + (version "0.9.11")
> (source (origin
> (method url-fetch)
> - (uri (string-append "https://mu0.googlecode.com/files/mu-"
> + (uri (string-append "https://github.com/djcb/mu/archive/v"
> version ".tar.gz"))
Please add (file-name (string-append "mu-" version ".tar.gz")) as
another field to the 'origin' form, so that the file name in /gnu/store
will include "mu-" in the name. This is rarely needed, but is needed
here because the name of the file in the URI (after the last '/')
doesn't include the package name.
Otherwise it looks good to me. Can you send an updated patch?
Thanks!
Mark
next prev parent reply other threads:[~2015-02-27 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 23:13 [PATCH] bump mu/mu4e to version 0.9.11 Paul van der Walt
2015-02-27 0:00 ` Mark H Weaver [this message]
2015-02-27 0:26 ` Paul van der Walt
2015-02-27 1:58 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twy86x53.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=paul@denknerd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.