From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/5] gnu: Add efl. Date: Fri, 27 Feb 2015 17:56:28 +0100 Message-ID: <87twy7mgxv.fsf@gnu.org> References: <1424910673-17665-1-git-send-email-sleep_walker@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRODJ-0007m2-Ts for guix-devel@gnu.org; Fri, 27 Feb 2015 11:56:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRODH-0002fP-6D for guix-devel@gnu.org; Fri, 27 Feb 2015 11:56:33 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRODH-0002fH-2C for guix-devel@gnu.org; Fri, 27 Feb 2015 11:56:31 -0500 In-Reply-To: <1424910673-17665-1-git-send-email-sleep_walker@suse.cz> (=?utf-8?B?IlRvbcOhxaEJxIxlY2giJ3M=?= message of "Thu, 26 Feb 2015 01:31:09 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Cc: guix-devel@gnu.org Tom=C3=A1=C5=A1 =C4=8Cech skribis: > * gnu/packages/efl.scm: New file > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. Nice work! > + (uri (string-append "http://download.enlightenment.org/rel= /libs/efl/efl-" version ".tar.gz")) Please keep lines below 80 chars. > + (inputs > + `(("alsa-lib" ,alsa-lib) > + ("bash" ,bash) Adding Bash is most likely unnecessary, or if it is, you=E2=80=99ll have to= add a comment to justify it. :-) > + (propagated-inputs > + `(("bullet" ,bullet) > + ("dbus" ,dbus) > + ("eudev" ,eudev) > + ("fontconfig" ,fontconfig) > + ("freetype" ,freetype) > + ("fribidi" ,fribidi) > + ("glib" ,glib) > + ("libpng" ,libpng) > + ("libsndfile" ,libsndfile) > + ("luajit" ,luajit) > + ("openssl" ,openssl) > + ("pulseaudio" ,pulseaudio) > + ("util-linux" ,util-linux))) That=E2=80=99s a lot! Normally we put a comment to justify why an input is propagated. The usual reasons are: installed headers include headers of a propagated input, or .pc file refers to one of them. Could you double-check whether all these are needed, and add comments? > + #:phases > + (alist-cons-before > + 'configure 'patch-config-files > + (lambda _ > + (substitute* "po/Makefile.in.in" > + (("/bin/sh") (which "bash")))) > + %standard-phases))) po/Makefile.in.in is not used, so I believe this phase is not needed. > + (home-page "http://www.enlightenment.org") > + (synopsis "Enlightenment Foundation Libraries") > + (description > + "EFL is toolkit used mainly for Enlightenment, but is used for more= applications because it is resource friendly and energy efficient.") =E2=80=9CToolkit=E2=80=9D is vague; could you say a couple of words about w= hat it provides? My understanding is that it=E2=80=99s partly a graphical toolkit= , but also partly a library of data structures, file system convenience functions, and such, right? Also, s/Enlightenment/the Enlightenment desktop environment/ or something like that. > + (license (list license:bsd-2 license:lgpl2.1 license:zlib)))) ; diff= erent parts under different licenses Please move the comment above to keep the lines below 80 chars. Thanks! Ludo=E2=80=99.